Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
    Tim Spence
    @TimWSpence
    Do you mean there’s something else that needs brought over @ChristopherDavenport ?
    Christopher Davenport
    @ChristopherDavenport
    Something else. It needs to pull the token from env, That was my fault.
    I knew I had more I needed to pull in but second guessed myself for what you had.
    @TimWSpence Do you mind if we add the Scala CoC to the project as well? Would be nice to ensure a welcoming atmospher.
    Tim Spence
    @TimWSpence
    Not at all!
    I’ve created fthomas/scala-steward#462 btw
    Christopher Davenport
    @ChristopherDavenport
    Woot, I’ll put my template in with your information.
    #6 up with fixes. Basically it was using local credentials which didn’t exist. Now it uses the ones pulled in from Env correctly.
    Christopher Davenport
    @ChristopherDavenport
    Your license is in the wrong spot to be seen do you mind if I move LICENSE.txt to LICENSE?
    Oh nevermind. Thats my script wrong not yours.
    Tim Spence
    @TimWSpence
    Woop, it passed! :)
    Christopher Davenport
    @ChristopherDavenport
    @TimWSpence I see you link the docs in text, do you want a link to the first one in the header bar?
    Tim Spence
    @TimWSpence
    oh yeah, good idea
    Christopher Davenport
    @ChristopherDavenport
    Site builds, but I’m not 100% if it will self-redirect or not. If it does it will need a different filename.
    I also think you need to turn of circle-ci as it seems the project config was lost at some step so the build is now consistently failing there.
    Ross A. Baker
    @rossabaker
    A nice thing on all these magic files Chris is creating is https://github.com/TimWSpence/cats-stm/community
    Gives you a good overview of the things with magic Github integrations. Like making sure the license is in the right place and such.
    Christopher Davenport
    @ChristopherDavenport
    It never likes my CoC for some reason.
    Would love to know why.
    Ross A. Baker
    @rossabaker
    I experimented with this. You have to use a canned one.
    It's unfortunate, but I think it's their way of preventing the CoC from being anything but.
    Christopher Davenport
    @ChristopherDavenport
    @rossabaker If you could take a look at #9 I think I got most of the stuff that can be overlooked.
    Christopher Davenport
    @ChristopherDavenport
    @TimWSpence I know its a drag to PR on your own repo, but its very hard for others who are helping to follow along if you push directly to master. If you PR in it means there is a clear log of changes to the mainline of the repository.
    Tim Spence
    @TimWSpence
    Yep fair! Sorry Chris
    Christopher Davenport
    @ChristopherDavenport
    No worries, just spent quite a bit trying to figure out how the internals changed before I realized something had bypassed what I can see via the repository watch.
    Tim Spence
    @TimWSpence
    Just as a heads up: the handling of orElse is still not quite correct. I’ve got plans to fix it when I have some time
    Christopher Davenport
    @ChristopherDavenport
    :+1:

    Do you have a test that can demonstrate the error. As with that others can normally take the shot at it. Or even an issue that describes the issue such that others can look into it.

    Not required. But can be useful to be able to lower some of the burden off yourself.

    Tim Spence
    @TimWSpence
    Thanks! I haven’t got a test yet but I’ve got a pretty good idea to produce one. I’ll at least push that somewhere asap
    Do you have any advice on where to put that code? Just as a snippet on an issue? Or a branch?
    Ross A. Baker
    @rossabaker
    I'd open an issue with it.
    Christopher Davenport
    @ChristopherDavenport
    @TimWSpence Updating now. I was thinking about adding the Reindeer problem as another doc? Hoping that helps me through understanding the system fully as well.
    Tim Spence
    @TimWSpence
    Cheers Chris! Yeah, the reindeer problem would be awesome! If it runs, would be a great test of what we’ve got so far as well
    Christopher Davenport
    @ChristopherDavenport
    Totally was wondering if it would interact with the retry conditions you were fixing.
    Very nice fixes. They look clean.
    Tim Spence
    @TimWSpence
    Thanks! :) There’s actually one more fix to come: TimWSpence/cats-stm#15 Currently, we miss some opportunities to retry a txn if it involves an orElse. The build for that currently fails because of mima but your comment on your PR seemed to suggest mima wasn’t currently configured to fail builds?
    Christopher Davenport
    @ChristopherDavenport
    Did you release a new version?
    Tim Spence
    @TimWSpence
    Yeah, a couple of days ago
    Christopher Davenport
    @ChristopherDavenport
    Yeah, version will likely need to be bumped again.
    Tim Spence
    @TimWSpence
    What is the behaviour of the plugin?
    (without me Googling a bunch of stuff :) )
    Christopher Davenport
    @ChristopherDavenport
    Thats a custom function to follow server.
    *semver
    Tim Spence
    @TimWSpence
    So for both your PR and mine, we would have to bump the major version to make mima happy?
    Christopher Davenport
    @ChristopherDavenport
    No, since we are in 0.x, we can bump minor.
    Going 1.x is only once we are very happy with the design.
    Tim Spence
    @TimWSpence
    yeah sorry, just saw if (major >= 1) Range(0, minor).inclusive.toList else List(minor)
    :+1:
    Christopher Davenport
    @ChristopherDavenport
    Http4s/Doobie still haven’t gone 1.0 yet. We want to get to a point of stability in minor versions before we consider that.