We hold regular community meetings, see the calendar here: https://opencensus.io/community/
but you can fix it :)
I'm building it now and will report back on the results shortly.
It pretty well works as-is. I had to fiddle with the BUILD file a little. @bogdandrutu the traces are connected now! I do still see some
<trace-without-root-span> in ObfuscatorServer results, though.
Hey, drag and drop worked. Slick.
I'm also pushing up my changes, after merging your PR.
Pushed.
and one with 1 span
So can see what is there
:)
I don't have time right now to run this
sorry
:(
otherwise I would have done that, your example is very nice and we should include it in our repo
:)
My bet is that these Spans are from prometheus or from our library pushing to jaeger
@bogdandrutu there's the three-span example
Also, thanks! Let me know if there's anything I can improve in the example to make it easier to include in the repo.
Don't know what is in that 1 span
There's the expanded one span, just for completeness.
This one appears to just be the gRPC roundtrip.
It's the only 2 span I could find generated. All the others are singletons.
Interesting. So, my wkr run is
wrk --duration=1s --threads=1 --connections=1 http://localhost:8080 and I can't turn up any partial traces. wkr reported 2846 requests, jaeger seems to have them all and none are partial.
Must be something goofy with all-in-one jaeger docker image.
@bogdandrutu cool! This was very helpful. I'll open a feature request as you suggested.
need to catch a flight
happy to help if more debugging is required
I noticed that the unit tests for https://github.com/census-instrumentation/opencensus-php/pulls started failing recently. It apppears to be for the integration / php71-32bit tests.
@mackenziestarr Yes, in order to do that you need to define your own view with the additional key, and put the key-value into scope before an outgoing RPC. Something like
TagKey KEY = TagKey.create("some_id");
View latencyById = View.create(
Name.create("latency_by_id"),
"client latency by ID",
RpcMeasureConstants.GRPC_CLIENT_ROUNDTRIP_LATENCY,
Aggregation.Distribution.create(bucketBoundaries),
Arrays.asList(RpcMeasureConstants.RPC_METHOD, KEY));
Stats.getViewManager().registerView(latencyById);
...
try (Scope ss = tagger.emptyBuilder().put(KEY, "id12345").buildScoped()) {
// RPC
}