Is it no longer possible to inherit from JSONAPI::ResourceController in 0.10.4 on rails 6.0? I'm working on an upgrade from rails 5.2, but I'm also experiencing the same problem if I create a new app following the docs. Whenever I make a request I get the error:
#<NameError: uninitialized constant JSONAPI::ResourceController
Did you mean? JSONAPI::ResourceControllerMetal>Tried setting config.autoloader = :classic but that didn't change anything.
I've been able to work around this by using:
class MyController < ActionController::Base
include JSONAPI::ActsAsResourceController
endThis is the only relevant commit that I've been able to find so far that might be causing this
Thanks! (I'm on ruby 2.7.2)
10 replies
class Api::V1::TagAssociationResource < JSONAPI::Resource
model_name 'TagAssociation'
attributes :tag_id, :tag_type_id, :taggable_id, :taggable_type, :time_range_appointment_id
# def self.creatable_fields(_context)
# super - [:time_range_appointment_id]
# end
before_save do
if !@model.taggable && @model.time_range_appointment_id.present?
time_range = TimeRange.find_by(appointment_id: @model.time_range_appointment_id)
@model.taggable = time_range
end
end
endResponse body: {"errors":[{"title":"Param not allowed","detail":"time_range_appointment_id is not allowed.","code":"105","status":"400"}]}
class Api::V1::TagAssociationResource < JSONAPI::Resource
model_name 'TagAssociation'
attributes :tag_id, :tag_type_id, :taggable_id, :taggable_type, :time_range_appointment_id
def time_range_appointment_id=(val)
@time_range_appointment_id = val
end
def time_range_appointment_id
nil
end
def self.fetchable_fields(_context)
super - [:time_range_appointment_id]
end
before_save do
if !@model.taggable && @time_range_appointment_id.present?
time_range = TimeRange.find_by(appointment_id: @time_range_appointment_id)
@model.taggable = time_range
end
end
end
Hi all! What would be the best way to define an attribute on each of a resource's records just before returning it? The use case is to mark resources as "recommended" on the fly. I've tried to override the records method as such:
def self.records(options = {})
objects = super
# sets the attr_accessor `recommended = true` on the model
Recommender.new(context[:current_team]).mark_recommended(objects)
objects
endThis doesn't work though, the response still shows recommended: nil. From what I've dug so far we lose this attribute somewhere during resource_klass.sort_records in apply_request_settings_to_records of ActiveRelationResource
7 replies
def self.fetchable_fields(_context)
super - [:time_range_appointment_id]
end
config.top_level_meta_record_count_key = :record_count, and I get a meta object at the top level with a record count, but it seems to return the full count of the model rather than the full count after filters. Is this as designed? Do I need to implement my own processor? I would think so except the processors documentation for v0.9 says that would be redundant, if I'm reading it right. (I'm using v0.10 but there are no docs for processors for that version)
I'd like to be able to query this type of resource with includes/filters/sorts, but I can't get the index to include the polymorphic relation.
Maybe I'm missing something simple.
jsonapi-resources 0.10.4
See the reply under this for a bug report template.
12 replies
Hello, hard working maintainers!
I ran into some error (or was unable to find answer in documentation) - I work with quite complex project which uses Ruby on Rails, and our PG db tables are divided in schemas.
When I request "index" for resource I get this error:Internal Server Error: ActiveRecord::JDBCError: org.postgresql.util.PSQLException: ERROR: missing FROM-clause entry FOR TABLE "schema_name.table_name" POSITION: 8:
SELECT "schema_name.table_name"."id" AS "schema_name.table_name_id",
schema_name.table_name.id
FROM "schema_name"."table_name"
WHERE "schema_name"."table_name"."type" IN ('StiType')
ORDER BY schema_name.table_name.id ASCHave I missed something in documentation, is db schemas unsupported, or is it a bug?
3 replies
JSONAPI: Could not find resource ''. (Class Api::V1::Resource not found). I was able to pin-point it to type_for_source
[1] pry(main)> InvoicePayment.find(11).payer_bank_detail
=> nil
[2] pry(main)> InvoicePayment.find(11).payer_bank_detail_type
=> ""
[3] pry(main)>Hi all. Could really use some guidance on fixing an N+1 query when fetching nested resources. for example http://localhost/api/v1/customer/{customer_id}/phonenumbers/
Fetching the phonenumbers works fine, but exhibits an N+1 query. Adding an includes to the phonenumber query works, but I can't pinpoint how to get the resource to add includes to the query. I see that the phonenumbers controller gets hit with the index_related_resources action. I can't figure out how /where I need to set up my query. I tried prefetching the phonenumbers in the controller and injecting it into the context object, but I don't know where to read in that value so the resource knows about it. any help would be greatly appreciated!
3 replies
self.apply_includes is that inside of a Resource class?
1 reply
index action. I'm wondering if its an issue because I'm using Mongo?uninitialized constant JSONAPI::ActsAsResourceController::ActiveRecord /Users/ckmatt/.rvm/gems/ruby-2.7.2/gems/jsonapi-resources-0.10.4/lib/jsonapi/acts_as_resource_controller.rb:134:inrescue in process_operations'`Appreciate any guidance!
1 reply
Hi folks, I've got a Rails app running on Ruby 2.7.3p183, and I'm upgrading Rails from 6.0.3.7 to 6.1.3.2. I'm using jsonapi-resources v0.9.12, and when I run bundle exec rake db:create db:migrate, I get the following error:
rake aborted!
NameError: uninitialized constant Digest::SHA2
.../repo/vendor/bundle/ruby/2.7.0/gems/jsonapi-resources-0.9.12/lib/jsonapi/configuration.rb:132:in `initialize'If I change that line as follows, inspired by https://www.ruby-forum.com/t/nameerror-uninitialized-constant-digest-sha2/156441/3:
# Resource cache digest function
# Provide a callable that returns a unique value for string inputs with
# low chance of collision. The default is SHA256 base64.
- self.resource_cache_digest_function = Digest::SHA2.new.method(:base64digest)
+ self.resource_cache_digest_function = Digest::SHA256.new.method(:base64digest)then I no longer get the error.
I haven't yet been able to reproduce the error in the jsonapi-resources repo itself by running the tests, but do you think it would be acceptable to make the above change? It would also make it more explicit which algorithm is being used.
Hey all, I could use a hand with an odd issue we're experiencing (Using v0.10.1).
The gist is that the json response data returned isn't the same as what JR gathered at the ResourceSet step, but we can't figure out what would case this. As far as we can tell, the only thing after that step is serializing the response.
For anyone inclined to take a peek, here's a sample of the data we have in our database; ids ordered by a date column. This is what we want. https://gist.github.com/pvilchez/636d251839323ed5f8d9c839215e2ac0
We put in a breakpoint in the JR code to inspect the ResourceSet to be returned. Plucking the id's, we get the following array: https://gist.github.com/pvilchez/f9ebe653e9688212ca05c3c05b15b7c8. Some of the ids seem out of order, but that only happens when the date is the same between rows, which is still acceptable for us.
Finally, this is the JSON response we get (edited to include only ids for clarity): https://gist.github.com/pvilchez/ce3c9d4378a51fc8799d1627aa756adf.
It is paged to 10 records, which is fine. The first ID is 39823, which in the database and in the ResourceSet was actually near the end of the list as expected based on its date entry.
Does anyone have any ideas on what could cause a reordering of records between gathering the ResourceSet and serializing the response?