These are chat archives for ceylon/ceylon-ide-eclipse

26th
Mar 2015
David Festal
@davidfestal
Mar 26 2015 11:05
are you there ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 11:05
Ya
David Festal
@davidfestal
Mar 26 2015 11:06
Good.Let me eat quickly then
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 11:06
Sure. Take your time. :)
David Festal
@davidfestal
Mar 26 2015 11:06
and we'll discuss after
David Festal
@davidfestal
Mar 26 2015 13:34
I'm here again
I've taken more time than expected
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:38
That's fine. Please excuse me if I went offline time to time. It just suddenly started rain heavily here in Sri Lanka
David Festal
@davidfestal
Mar 26 2015 13:39
Ah, OK !
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:39
I went through the detailed description you have given in #1152
David Festal
@davidfestal
Mar 26 2015 13:39
And things get clearer ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:40
  • #1252
Things are clear however I'll have lot of things to ask when implementing..
David Festal
@davidfestal
Mar 26 2015 13:41
I can imagine
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:41
I'd like to continue with this project.
David Festal
@davidfestal
Mar 26 2015 13:41
For the moment, you could have a look to CeylonJDIDebugTarget in the IDE code
OK, good news
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:45
com.redhat.ceylon.eclipse.core.debug.model.CeylonJDIDebugTarget ?
David Festal
@davidfestal
Mar 26 2015 13:45
Yes
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:45
I'll refer that source
David Festal
@davidfestal
Mar 26 2015 13:46
You mean in your proposal ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:46
no no. I mean I'll go through it
David Festal
@davidfestal
Mar 26 2015 13:46
I was just saying that for you to find entry points to catch a bit of the context in which you will have to work
Apart from what I've explained in #1252, which is the pure Evaluation engine implementation, there will be some other points to manage of course
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:48
Shall I mention those steps in the proposal as well?
David Festal
@davidfestal
Mar 26 2015 13:49
implement a SourceViewer that will allow to write the snipper code and get completion according to the current debugging location
I don't think you have to enter the detail of #1252 in your proposal
but explain the main steps such as :
  • Build a Ceylon Evaluation engine integrated with the existing Eclipse Ceylon debugging code
  • Build editing utilities to provide embedded Ceylon snippet / expression editors with completion
  • With these 2 basic components build :
    • Ceylon conditional breakpoints (with the related UI and condition editor)
    • Ceylon watches and inspect value (with the related contextual menu entries)
    • A Ceylon Snippet Editor / Runner (similar to the JDT "Display" view)
David Festal
@davidfestal
Mar 26 2015 13:54
This message was deleted
This message was deleted
wdyt of something like that ?
David Festal
@davidfestal
Mar 26 2015 13:59
And yes, in the first point (evaluation engine) we could detail a bit with :
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 13:59
That's good. So basically 3 components right.
David Festal
@davidfestal
Mar 26 2015 14:00
2 components and 3 usages of these components
=> for the first one we could detail :
  • Specific parsing of the evaluated code in the context of a line of a currently edited Ceylon file
  • Gathering of the necessary variables
David Festal
@davidfestal
Mar 26 2015 14:05
  • Creation, parsing, typechecking and bytecode generation of the evaluation static function
  • Push of the evaluation bytecode to the debugged application and execution
This message was deleted
For the proposal do you need to detail the time you're expecting to spend for each step ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:11
They do expect a timline
David Festal
@davidfestal
Mar 26 2015 14:12
That you have to prepare for the submission tonight ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:12
I have till tomorrow.
David Festal
@davidfestal
Mar 26 2015 14:12
Ah OK
How long is the GSOC ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:13
It can be either a one which describe weekly goals or a one which describe phases
David Festal
@davidfestal
Mar 26 2015 14:13
OK
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:13
coding starts from May 25- August 24th.
But they announce selected students on April 27th
David Festal
@davidfestal
Mar 26 2015 14:14
@FroMage : since you are the GSOC man, I just added you to this room
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:14
So from April 27th can start working on the project.
David Festal
@davidfestal
Mar 26 2015 14:14
sicne we're discussing about @rehrumesh 's GSOC
So you have 3 months ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:17
Yes. But can consider 4 months as they announce selected students on April 27th
Let me double check again
27 April:
19:00 UTC
Accepted student proposals announced on the Google Summer of Code 2015 site.
David Festal
@davidfestal
Mar 26 2015 14:19
But I assume your proposed timeline should be based on 3 months
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:22
It is better to create proposal with 3 months.
David Festal
@davidfestal
Mar 26 2015 14:22
Yes, I suppose also
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:22
I'll use April 27th to May 25th to get familiar with the code
David Festal
@davidfestal
Mar 26 2015 14:22
OK
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:23
documentation and other coding standards.
David Festal
@davidfestal
Mar 26 2015 14:24
did you work on Eclipse much until now ? and with JDI ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:26
Not with the JDI but yeah I started working in the #1136 to get familier with the code
David Festal
@davidfestal
Mar 26 2015 14:26
ok
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:27
About half of the work done. But since proposal deadline coming up thought of finalizing it first
David Festal
@davidfestal
Mar 26 2015 14:27
Yes, sure
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:28
You described about the first component. Can you describe me the second component as well?
David Festal
@davidfestal
Mar 26 2015 14:29
not sure there's much to describe here without going into unnecessary details ...
or maybe we could dispatch that in the next 3 points
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:31
That would be great
David Festal
@davidfestal
Mar 26 2015 14:33
Just a moment let me check something
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:33
Ok
David Festal
@davidfestal
Mar 26 2015 14:46
By the way, is you work on #1136 pushed somewhere ?
a branch ? a git fork ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:48
No not yet since it is not completed. But I have it local. I could push the current work though. I have forked the ceylon-ide-eclipse project
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 14:59
David Festal
@davidfestal
Mar 26 2015 15:01
so you didn't implement the change itself then ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 15:04
I had few issues. while manipulating the code. That's why I said I managed to complete half of the task so far earlier. But this weekend I'll complete the rest.
David Festal
@davidfestal
Mar 26 2015 15:04
the commented code is your or gavin's
?
David Festal
@davidfestal
Mar 26 2015 15:06
OK thanks !
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 15:07
earlier you were referring only the last commit right?
David Festal
@davidfestal
Mar 26 2015 15:07
yes, it seems
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 15:08
Since I had garbage comments I removed them in the last commit.
Please give me 15 mins.
David Festal
@davidfestal
Mar 26 2015 15:12
no problem
Lucas Werkmeister
@lucaswerkmeister
Mar 26 2015 15:16
@davidfestal by the way, as far as I can tell you’re not in any special room… I got emails from gitter about what I missed in ceylon/ceylon-ide-eclipse
David Festal
@davidfestal
Mar 26 2015 15:16
Because you're in this room. yes
but you can leave it if the mails bother you
I prefered discussing here since we can reference IDE issues directly
Roland Tepp
@luolong
Mar 26 2015 15:17
just configure your notification settings. That should do it
Lucas Werkmeister
@lucaswerkmeister
Mar 26 2015 15:17
I thought you said you were in a special room
okay, easier issues is right
David Festal
@davidfestal
Mar 26 2015 15:17
and go into implementation details that are not interesting for ceylon/user
@lucaswerkmeister : at the beginning yes, but I changed for this one
And after all, all this is not that private !
Lucas Werkmeister
@lucaswerkmeister
Mar 26 2015 15:18
okay, then everything’s clear :)
David Festal
@davidfestal
Mar 26 2015 15:20
@rehrumesh : in the 2nd point (Build editing utilities) we could add the following children :
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 15:26
@davidfestal I'm back.
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 15:57
@davidfestal you there?
David Festal
@davidfestal
Mar 26 2015 15:58
  • Adapt or override the existing Ceylon source viewer , source viewer configuration and completion processor components, to allow editing Ceylon code snippets in the current context of a full editor,
  • Define an abstract base component for providing Ceylon code snippet editing as an embeddable UI component.
yes
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:01
So its better to complete first cmoponent by mid term evaluation and the second component at the final evaluation right
David Festal
@davidfestal
Mar 26 2015 16:02
well, let's summarize :
David Festal
@davidfestal
Mar 26 2015 16:13
  • Build a Ceylon Evaluation engine integrated with the existing Eclipse Ceylon debugging code
    • Specific parsing of the evaluated code in the context of a line of a currently edited Ceylon file
    • Gathering of the necessary variables
    • Creation, parsing, typechecking and bytecode generation of the evaluation static function
    • Push of the evaluation bytecode to the debugged application and execution
  • Use the evaluation engine to provide :
    • Ceylon conditional breakpoints
    • Ceylon watches and inspect actions
  • Build editing utilities to provide embedded Ceylon snippet / expression editors with completion
    • Adapt or override the existing Ceylon source viewer , source viewer configuration and completion processor components, to allow editing Ceylon code snippets in the current context of a full editor,
    • Define an abstract base component for providing Ceylon code snippet editing as an embeddable UI component.
    • Apply to the Breakpoint condition editor and to the watches and inspect actions, in order to provide coloration, and completion.
  • Optionally : Provide a Ceylon Snippet Editor / Runner similar to the JDT "Display" view with coloration and completion.
I reordered a bit
because completion and coloration, etc .. are not needed to validate and use the evaluation
it's a step we can postpone
to add edition facilities to the code snippets
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:14
ok
David Festal
@davidfestal
Mar 26 2015 16:15
And, after thinking about it, adding a real Snippet Editor / runner such as the JDT Display view is maybe not necessary
to add in the timeframe
There's probably already quite much work
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:16
Yeas I think there is fair amount of work for 3 months time frame.
David Festal
@davidfestal
Mar 26 2015 16:16
and it could be easily added at the end if you have time
Yes I think also
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:17
However I can list it as something to work if time permits
David Festal
@davidfestal
Mar 26 2015 16:17
Yes
why not
Honestly, do you think that we should also make the editing utilities (completion, etc ...) part optional ?
If you feel it's too much work to be doable ...
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:19
I have a little fear there.
David Festal
@davidfestal
Mar 26 2015 16:19
I understand
So let's remove the Snippet Editor
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:20
yeah. that would be good
David Festal
@davidfestal
Mar 26 2015 16:21
And add "According to the remaining time, " to the "Build editing utilities"
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:21
Sure.
David Festal
@davidfestal
Mar 26 2015 16:21
So that, for the mid-term evaluation you can showcase the evaluation engine with a simple use
basic dialog that submits evaluation
And present the conditional breakpoints and watches at the end
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:23
Great.
David Festal
@davidfestal
Mar 26 2015 16:23
and if, you have coloration and completion, it would be a "plus"
wdyt of that ? seems more reasonable ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:23
That's perfect
Several questions though.
David Festal
@davidfestal
Mar 26 2015 16:24
ask :-)
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:25
  1. Even though @FroMage listed as a mentor, I could work with you on this project right?
David Festal
@davidfestal
Mar 26 2015 16:26
I assume yes, but we should ask him. @FroMage : wdyt ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:28
  1. Can you give me a rough time estimation on each task that I should spent.
David Festal
@davidfestal
Mar 26 2015 16:28
not easy
Stéphane Épardaud
@FroMage
Mar 26 2015 16:28
sure, yes
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:30
Then I'll do the estimation.
David Festal
@davidfestal
Mar 26 2015 16:30
@rehrumesh : probably you can just split according to the number of points and the fact that showing a POC of the evaluation engine would be good at midterm
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:31
I will do that.
David Festal
@davidfestal
Mar 26 2015 16:31
knowing that the work on conditionak breakpoints is probably a bit more that the one on watches and inspect
though I'm not sure
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:33
I'll make a draft proposal. Will you be able to give me some comments after that so I could finalize it and submit?
David Festal
@davidfestal
Mar 26 2015 16:33
yes
If not connected, you can send it to my gmail address
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:34
Great. Thanks a great deal @davidfestal . I'll make sure to send it to your gmail as well.
David Festal
@davidfestal
Mar 26 2015 16:34
I don't know if @FroMage would agree to give his opinion also ?
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:37
It would be really helpful if @FroMage also could give his opinion.
Stéphane Épardaud
@FroMage
Mar 26 2015 16:41
just forward it to me too then
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 16:42
Sure. Thanks @FroMage
Rumesh Eranga Hapuarachchi
@rehrumesh
Mar 26 2015 19:05
@davidfestal you there?