These are chat archives for ceylon/ceylon-ide-eclipse

11th
Mar 2016
Gavin King
@gavinking
Mar 11 2016 12:35
ceylon/ceylon-ide-eclipse#1726
Bastien Jansen
@bjansen
Mar 11 2016 15:16
so it looks like ceylon.language is not automatically registered in Eclipse too, it's added to the classpath in CeylonLanguageModuleContainer
David Festal
@davidfestal
Mar 11 2016 15:16
wdym ?
by automatically registered ?
Bastien Jansen
@bjansen
Mar 11 2016 15:17
I mean the abstracted model loader does not call addModuleToClasspathInternal() for the language
we have to add the language to the classpath before calling parseCeylonModel()
David Festal
@davidfestal
Mar 11 2016 15:18
Ah, that might be true
Bastien Jansen
@bjansen
Mar 11 2016 15:18
which is what I was trying to figure out the other day
David Festal
@davidfestal
Mar 11 2016 15:18
but I didn't realize that it was not added in the abstraction
because very early in the process of module validation you need the language module in the classpath
Bastien Jansen
@bjansen
Mar 11 2016 15:18
           if (ideModule != languageModule 
               && (ideModule.isCeylonBinaryArchive 
                    || ideModule.isJavaBinaryArchive)) {
               addModuleToClasspathInternal(artifact);
           }
see the first condition
David Festal
@davidfestal
Mar 11 2016 15:19
yes, indeed
Bastien Jansen
@bjansen
Mar 11 2016 15:19
I suppose it's here because the language was already added in CeylonLanguageModuleContainer in the eclipse impl
David Festal
@davidfestal
Mar 11 2016 15:19
it should be added in the classpath at the creation of the project, or at least very early in the process
Bastien Jansen
@bjansen
Mar 11 2016 15:19
yes
David Festal
@davidfestal
Mar 11 2016 15:19
but that's probably IDE-dependent
Bastien Jansen
@bjansen
Mar 11 2016 15:20
maybe
David Festal
@davidfestal
Mar 11 2016 15:20
because the initialization process is really IDE dependent
Though It should be documented
Bastien Jansen
@bjansen
Mar 11 2016 15:20
but adding the language module is the same as adding any other module, right?
couldn't it be added with addModuleToClasspathInternal?
or does it need to be there before we start parsing the model?
David Festal
@davidfestal
Mar 11 2016 15:21
please open a ceylon-ide-common issue and assign it to me
so that I remember to think about it
yeah, it needs to be there before
sure
Bastien Jansen
@bjansen
Mar 11 2016 15:21
an issue to document it?
David Festal
@davidfestal
Mar 11 2016 15:21
to explain your question
Bastien Jansen
@bjansen
Mar 11 2016 15:21
ok
David Festal
@davidfestal
Mar 11 2016 15:22
and the fact that nothing in the abstraction manages this
And I'll look into it when coming back to the abstraction work
Bastien Jansen
@bjansen
Mar 11 2016 15:22
perhaps we could use the wiki to explain how to set up the model, how to extend mirror classes etc
in case people want to add support for other IDEs
David Festal
@davidfestal
Mar 11 2016 15:23
IMO we should first document the code much more
module, package and declaration doc in the code would allow producing a nice Documentation
that would be sufficient to work with IMO
but that's much work
Bastien Jansen
@bjansen
Mar 11 2016 15:25
i'm not really sure what to put in the issue
"document the code"?
David Festal
@davidfestal
Mar 11 2016 15:26
Just explain the problem you had and the reason (which is : the language module is not added in the classpath => when should be do it ? => before when when ? )
so we'll keep track that there is probably something to make better here
Thanks !
Gavin King
@gavinking
Mar 11 2016 23:38
ceylon/ceylon-ide-eclipse#1728