These are chat archives for ceylon/ceylon-ide-eclipse

15th
Apr 2016
Bastien Jansen
@bjansen
Apr 15 2016 07:13 UTC
heh, the CI build already proves useful: https://ci-ceylon.rhcloud.com/job/ceylon-ide-eclipse/8/
Stéphane Épardaud
@FroMage
Apr 15 2016 13:07 UTC
@bjansen no, it's too complicated to build
where can I find one online again?
bah, wrong channel
Bastien Jansen
@bjansen
Apr 15 2016 13:07 UTC
there's a repo url in the readme
Bastien Jansen
@bjansen
Apr 15 2016 15:56 UTC
why are refactorings so overly complicated
I rewrote an ExtractFunctionRefactoring as a class instead of an interface, and I have no clue how to use it in Eclipse, because there's 50000 classes involved in calling a single refactoring
Bastien Jansen
@bjansen
Apr 15 2016 16:05 UTC
@gavinking I pushed a ceylon/ceylon-ide-common@9eccf59 of ExtractValueRefactoring. It's now completely independent of the IDE (it abstracts the document and text edits), and has a factory method. The idea is that if the factory returns an instance of the class, the refactoring is available in the IDE. The current EclipseExtractFunctionRefactoring should be able to delegate to this new class. When you have time, could you take a look and try to change the Eclipse impl please?
Gavin King
@gavinking
Apr 15 2016 19:00 UTC
@bjansen so you mean eclipse is broke now?
Bastien Jansen
@bjansen
Apr 15 2016 19:46 UTC
no, it's still using what you abstracted
I copied the interface to a new class
Bastien Jansen
@bjansen
Apr 15 2016 20:47 UTC
the new version works pretty well in IntelliJ
I'll need to abstract the part that determines which expressions/statements are extract-able