These are chat archives for ceylon/ceylon-ide-eclipse

18th
Apr 2016
Bastien Jansen
@bjansen
Apr 18 2016 13:56
@gavinking I think I finally got it "right": ceylon/ceylon-ide-eclipse@910785f
Gavin King
@gavinking
Apr 18 2016 13:56
ok, i will check it out
Bastien Jansen
@bjansen
Apr 18 2016 13:56
EclipseExtractFunctionRefactoring is like the old Java refactoring, but it delegates to the Ceylon class
If it works as it should, I think we can delete our old attempts
and use the same patterns in other refactorings
Gavin King
@gavinking
Apr 18 2016 13:59
i will check it out
Bastien Jansen
@bjansen
Apr 18 2016 13:59
okay
Gavin King
@gavinking
Apr 18 2016 14:00
you pushed it to master, right?
Bastien Jansen
@bjansen
Apr 18 2016 14:00
yeah
Gavin King
@gavinking
Apr 18 2016 14:00
k
good
Tom Bentley
@tombentley
Apr 18 2016 14:09
How am I supposed to build the IDE from the command line these days? I just tried ant dist sdk eclipse and got an error "[exec] [ERROR] Cannot satisfy dependency: com.redhat.ceylon.eclipse.feature.feature.group 1.2.3.qualifier depends on: com.redhat.ceylon.ide.common.feature.feature.group [1.2.3,1.3.0)"
Stéphane Épardaud
@FroMage
Apr 18 2016 14:09
oh
so it's not just me
I was about to ask the same
Bastien Jansen
@bjansen
Apr 18 2016 14:09
ant clean dist sdk eclipse
Stéphane Épardaud
@FroMage
Apr 18 2016 14:09
and it works for you?
or you're just pretending
Bastien Jansen
@bjansen
Apr 18 2016 14:10
I think you always need to clean, otherwise it creates more than 1 artifact for some projects, and the build picks up the wrong one
it always works with clean
because artifact names contain a timestamp or something like that
Stéphane Épardaud
@FroMage
Apr 18 2016 14:12
oh that's why
Bastien Jansen
@bjansen
Apr 18 2016 14:12
hum actually it's clean-all, not clean
Stéphane Épardaud
@FroMage
Apr 18 2016 14:12
ok now it worked
thanks
Bastien Jansen
@bjansen
Apr 18 2016 14:12
or maybe clean is enough
@FroMage @tombentley otherwise, Jenkins provides a nightly build ;)
Tom Bentley
@tombentley
Apr 18 2016 14:20
I need one with my compiler inside
Bastien Jansen
@bjansen
Apr 18 2016 14:21
ok, then clean should fix your problem
Gavin King
@gavinking
Apr 18 2016 14:22
i think it should be clean-all
Stéphane Épardaud
@FroMage
Apr 18 2016 14:24
@tombentley why? my compiler is better
Stéphane Épardaud
@FroMage
Apr 18 2016 15:15
@bjansen @davidfestal where in eclipse/common is there any code that pulls/stores project-specific info in the Ceylon config?
Stéphane Épardaud
@FroMage
Apr 18 2016 15:17
thanks
this one is not ide-specific, but I want to make the IDE able to edit it
Bastien Jansen
@bjansen
Apr 18 2016 15:17
ok
Stéphane Épardaud
@FroMage
Apr 18 2016 15:45
defaultDefaultCharset
clap
clap
clap
;)
Bastien Jansen
@bjansen
Apr 18 2016 15:48
:D
Gavin King
@gavinking
Apr 18 2016 23:14
@bjansen it seems to me that the new approach is far, far better
in fact it’s not much removed from the original Java code, except that
  1. you abstract away from platform-specific stuff using wrappers (this is good), and
  2. you wrap the resulting refactoring
which is fine
the only bit i’m confused about is this stuff:
@Override
void refactorInFile(TextChange textChange, CompositeChange compositChange,
        CompilationUnit rootNode, List<CommonToken> tokens) {
    // not used
}

@Override
public void extractInFile(TextChange tfc) {
    // not used
}

@Override
public void setTypeRegion(IRegion region) {
    // not used
}

@Override
public void setDecRegion(IRegion region) {
    // not used
}

@Override
public void setRefRegion(IRegion region) {
    // not used
}
what’s going on with that?
Gavin King
@gavinking
Apr 18 2016 23:21
looks like I can just delete ‘em
and from the supertype too
but what were they for?
Also, we still need to do this:
ceylon/ceylon-ide-common#43
but that looks doable now, with the new approach