These are chat archives for ceylon/ceylon-ide-eclipse

8th
Sep 2016
David Festal
@davidfestal
Sep 08 2016 09:01
Hi all
@gavinking are you there ?
ceylon-ide-eclipse doesn't build anymore
because of the missing toJavaStringList interop method that you removed from ceylon-ide-common
did you forget to push the last changes you made locally ?
Gavin King
@gavinking
Sep 08 2016 09:27
lemme check
nope, looks like I pushed everything
David Festal
@davidfestal
Sep 08 2016 09:27
and it builds fr you ?
Gavin King
@gavinking
Sep 08 2016 09:28
not sure, that would take me about 10 mins to find the answer to
David Festal
@davidfestal
Sep 08 2016 09:28
FYI I'm already fixing it
so no problem
Gavin King
@gavinking
Sep 08 2016 09:28
ok, good
which class is it in?
David Festal
@davidfestal
Sep 08 2016 09:28
I just wanted to be sure that I was not fixing something already fixed ;-)
CeylonBuilder, ModuleLaunchDelegate, and someothers
it seems you didn't change teh eclipse IDE code after the second round of common interop cleanup
that removed toJavaStringList
Gavin King
@gavinking
Sep 08 2016 09:30
I can’t find toJavaStringList in the source of CeylonBuilder
I don’t think you’re uptodate
are you on a branch?
David Festal
@davidfestal
Sep 08 2016 09:30
no on master afaik
Bastien Jansen
@bjansen
Sep 08 2016 09:30
@gavinking it fails on Jenkins too
David Festal
@davidfestal
Sep 08 2016 09:30
and I pulled this morning
Gavin King
@gavinking
Sep 08 2016 09:31
oh wait, wrong one
yeah, ok, looks like I forgot
Gavin King
@gavinking
Sep 08 2016 09:37
@davidfestal what I’ve been doing is adding xxxxAsJavaList attributes to ceylon-ide-common APIs
since then you can just use Arrays.asList() to instantiate the Java list
e.g.
David Festal
@davidfestal
Sep 08 2016 09:38
I've seen that, in CeylonProjects for example
Gavin King
@gavinking
Sep 08 2016 09:38
Arrays.asList(*xxxx.map(javaString)), or whatever
David Festal
@davidfestal
Sep 08 2016 09:38
but there the errors are in Java code
Gavin King
@gavinking
Sep 08 2016 09:38
or even JavaList from ceylon.interop.java, if it’s already the right sort of Ceylon List
huh?
David Festal
@davidfestal
Sep 08 2016 09:39
I'm speaking of the remaining errors
on the to toJavaStringListmethod
Gavin King
@gavinking
Sep 08 2016 09:40
ok, well, sure, so apparently I missing something
pretty hard when it takes ten minutes to run a build
David Festal
@davidfestal
Sep 08 2016 09:40
yeah, but no problem
I'm fixing it
Gavin King
@gavinking
Sep 08 2016 09:40
ok, but please don’t fix it in a crap way is what I’m saying
David Festal
@davidfestal
Sep 08 2016 09:41
you had added CeylonHelper.list in the ceylon-ide-eclipse project
I added CeylonHelper.toJavaStringList()
    public static <Type> List<Type> list(Class<Type> klass,  ceylon.language.Iterable<? extends Type, ? extends Object> ceylonIterable) {
        ArrayList<Type> arrayList = new ArrayList<>();
        Iterator<?> iterator = ceylonIterable.iterator();
        Object elem;
        while ((elem = iterator.next())!=finished_.get_()) {
            arrayList.add((Type) elem);
        }
        return arrayList;
    }

    public static List<String> toJavaStringList(ceylon.language.Iterable<ceylon.language.String, ? extends Object> ceylonIterable) {
        ArrayList<String> arrayList = new ArrayList<>();
        Iterator<ceylon.language.Iterable> iterator = ceylonIterable.iterator();
        ceylon.language.String elem;
        while ((elem = iterator.next())!=finished_.get_()) {
            arrayList.add(elem == null ? null : elem.value);
        }
        return arrayList;
    }
seems correct no ? and not so crappy ;-) ?
Bastien Jansen
@bjansen
Sep 08 2016 09:43
@gavinking you can simply run ceylon compile in ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui, you know
much much faster
if you just want to check that everything builds fine
Gavin King
@gavinking
Sep 08 2016 16:38
 [exec] Note: Created module com.redhat.ceylon.eclipseDependencies/1.3.0
 [exec] /Users/gavin/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/core/launch/CeylonAwareLaunchConfiguration.ceylon:153: error: function or value is not defined: 'createRepositoryManagerBuilderNoOut' might be misspelled or is not imported (did you mean 'createRepositoryManagerBuilder'?)
 [exec]                         createRepositoryManagerBuilderNoOut(Boolean forInput) => repoManagerBuilder;
 [exec]                         ^
David Festal
@davidfestal
Sep 08 2016 16:39
oh, strange
There might have a problem just before committing.
strange
let me have a look
did you pull the distribution ?
Ah, or I should do it
let me see