Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 12 2021 13:11
    FroMage closed #1897
  • Jan 12 2021 13:11
    FroMage commented #1897
  • Jan 12 2021 11:26
    baberrehman commented #1897
  • Jan 12 2021 10:43
    FroMage commented #1897
  • Jan 12 2021 07:24
    baberrehman edited #1897
  • Jan 12 2021 07:23
    baberrehman edited #1897
  • Jan 12 2021 07:22
    baberrehman opened #1897
  • Feb 08 2020 19:30

    jvasileff on release-1.3.4

    (compare)

  • Feb 08 2020 19:29

    jvasileff on release-1.3.4

    (compare)

  • Feb 08 2019 12:29

    davidfestal on master

    Add the ability to tune the mvn… (compare)

  • Feb 07 2019 22:05

    davidfestal on master

    Switch to the `Eclipse Ceylon` … (compare)

  • Dec 03 2018 20:24
    kingjon3377 edited #1896
  • Dec 03 2018 20:22
    kingjon3377 opened #1896
  • Sep 29 2018 11:55

    gavinking on master

    fix a cosmetic problem in Dark … (compare)

  • Sep 29 2018 10:58

    gavinking on master

    use isConstructor() method (compare)

  • Sep 28 2018 23:15

    gavinking on master

    update for latest mvn version (compare)

  • Sep 28 2018 23:14

    gavinking on master

    adapt to API changes in Ceylon … (compare)

  • Sep 28 2018 13:31

    davidfestal on master

    Add Eclipse Photon compatibilit… Add Java 9 compatibility (#1890… Fix various bugs to have the ID… (compare)

  • Sep 26 2018 06:56
    davidfestal assigned #1894
  • Sep 26 2018 06:55
    davidfestal labeled #1894
Stéphane Épardaud
@FroMage
that's one odd beast
Bastien Jansen
@bjansen
@gavinking it's allowed because sometimes it's a range like bundle-version="[1.0,1.1)"
well not in that particular case, but quotes are valid
Stéphane Épardaud
@FroMage
but still I don't know why that would change anything wrt versions
my code really only sets the artifact/group
Bastien Jansen
@bjansen
@FroMage I think I know a workaround, but that still doesn't explain why it's now failing
we have this code that replaces a range with a single version and removes quotes at the same time:
        requireBundle = requireBundle.replaceAll(";bundle-version=\"\\[([^,]+),[^,]+(\\]|\\))\"", ";bundle-version=$1");
we could do something similar right after to remove quotes that are still present
in com.redhat.ceylon.cmr.impl.OSGiDependencyResolver#parseRequireBundle
Stéphane Épardaud
@FroMage
so the one thing I wonder is why we're even hitting this resolver
oh ok it's a jar with Activator and that's it
and indeed an OSGi decl
I was thinking I could add the same augment to that resolver to set group/artifact but it doesn't have one so it wouldn't help
but yeah, parseAttribute looks bogus to me
it should deal with optional quotes
not that horrible regex
Bastien Jansen
@bjansen
maybe we're doing it wrong and we shouldn't put those quotes in the first place
Stéphane Épardaud
@FroMage
isn't this a brilliant website? https://www.osgi.org/bundle-headers-reference/
no links to the definitions
Bastien Jansen
@bjansen
yeah I have the last one open too
so I'll try to add remove the quotes in parseRequireBundle and see if it works better
Stéphane Épardaud
@FroMage
thanks
Bastien Jansen
@bjansen
hum, even without the quotes I can't build the plugin
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'ceylon.language-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'ceylon.language/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.model-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.model/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'ceylon.bootstrap-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'ceylon.bootstrap/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.module-resolver-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.module-resolver/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.common-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.common/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.langtools.classfile-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.langtools.classfile/1.3.2.osgi-4'
     [exec] ceylon compile: There were 6 errors
Bastien Jansen
@bjansen
all right, it looks like com.redhat.ceylon.dist-1.3.2-SNAPSHOT.jar does contain any META-INF/maven/pom.xml, which means com.redhat.ceylon.cmr.impl.ModulesDependencyResolver#augment will return null instead of the ModuleInfo it received as a parameter
couldn't that method return ret instead of null @FroMage ?
that module info exists, it's just that we can't augment it with a groupId/artifactId
with that single change, I don't need to remove the quotes around the OSGi version, and the Eclipse plugin build fine again
Stéphane Épardaud
@FroMage
WAT
what an idiot
of course that method should not return null
maaaan
I'm so sorry this is really crap
just pushed the fix
Bastien Jansen
@bjansen
heh
thanks
Bastien Jansen
@bjansen
@davidfestal is there a reason why all the pom.xml stay in SNAPSHOT when you bump the IDE to release versions (like in this commit ceylon/ceylon-ide-eclipse@56a09fe )?
if I remove the snapshot suffix, the build fails, it looks like Tycho still thinks we're building a snapshot, but I can't really explain it
David Festal
@davidfestal
@bjansen well, it was like this trom the beginning when Max did the first version of all this
Bastien Jansen
@bjansen
oh, ok
Bastien Jansen
@bjansen
@davidfestal other quick question (sorry to bother you :)), do you use a JDK 7 or JDK 8 when you build the release version of ceylon-ide-eclipse?
David Festal
@davidfestal
and I'm not sure it's really interesting, since we produce OSGI artifacts, (it's not typical maven products), and don't use the Maven release process to push to some maven release repositrory
ah, don't remember exactly
I'll have to check
did you try both ?
Bastien Jansen
@bjansen
I just noticed that I built it with JDK 8 (including the embedded distro), but the distro is always built with a JDK 7 when it's released
so I don't know if it could cause problems when opening projects configured with a JDK 7 for example