ceylon/ceylon-ide-eclipse

Eclipse Plugin for Ceylon

Stéphane Épardaud

@FroMage

it should deal with optional quotes

not that horrible regex

Bastien Jansen

@bjansen

maybe we're doing it wrong and we shouldn't put those quotes in the first place

Stéphane Épardaud

@FroMage

isn't this a brilliant website? https://www.osgi.org/bundle-headers-reference/

no links to the definitions

http://www.ibm.com/support/knowledgecenter/SSEQTP_8.5.5/com.ibm.websphere.osgi.doc/ae/ra_bundle_mf.html has quotes

http://www.eclipse.org/virgo/documentation/virgo-documentation-3.7.0.M01/docs/virgo-user-guide/html/ch02s02.html too

Bastien Jansen

@bjansen

yeah I have the last one open too

so I'll try to add remove the quotes in parseRequireBundle and see if it works better

Stéphane Épardaud

@FroMage

thanks

Bastien Jansen

@bjansen

hum, even without the quotes I can't build the plugin

     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'ceylon.language-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'ceylon.language/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.model-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.model/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'ceylon.bootstrap-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'ceylon.bootstrap/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.module-resolver-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.module-resolver/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.common-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.common/1.3.2.osgi-4'
     [exec] /Users/bastien/Dev/ceylon/ceylon-ide-eclipse/plugins/com.redhat.ceylon.eclipse.ui/source/com/redhat/ceylon/eclipse/module.ceylon:20: error: cannot find module artifact 'com.redhat.ceylon.langtools.classfile-1.3.2.osgi-4(.car|.jar)'
     [exec]     shared import com.redhat.ceylon.dist "1.3.2-SNAPSHOT";
     [exec]     ^
     [exec]       - dependency tree: 'com.redhat.ceylon.eclipse/1.3.2' -> 'com.redhat.ceylon.dist/1.3.2-SNAPSHOT' -> 'com.redhat.ceylon.langtools.classfile/1.3.2.osgi-4'
     [exec] ceylon compile: There were 6 errors

Bastien Jansen

@bjansen

all right, it looks like com.redhat.ceylon.dist-1.3.2-SNAPSHOT.jar does contain any META-INF/maven/pom.xml, which means com.redhat.ceylon.cmr.impl.ModulesDependencyResolver#augment will return null instead of the ModuleInfo it received as a parameter

couldn't that method return ret instead of null @FroMage ?

that module info exists, it's just that we can't augment it with a groupId/artifactId

with that single change, I don't need to remove the quotes around the OSGi version, and the Eclipse plugin build fine again

Stéphane Épardaud

@FroMage

WAT

what an idiot

of course that method should not return null

maaaan

I'm so sorry this is really crap

just pushed the fix

Bastien Jansen

@bjansen

heh

thanks

Bastien Jansen

@bjansen

@davidfestal is there a reason why all the pom.xml stay in SNAPSHOT when you bump the IDE to release versions (like in this commit ceylon/ceylon-ide-eclipse@56a09fe )?

if I remove the snapshot suffix, the build fails, it looks like Tycho still thinks we're building a snapshot, but I can't really explain it

David Festal

@davidfestal

@bjansen well, it was like this trom the beginning when Max did the first version of all this

Bastien Jansen

@bjansen

oh, ok

Bastien Jansen

@bjansen

@davidfestal other quick question (sorry to bother you :)), do you use a JDK 7 or JDK 8 when you build the release version of ceylon-ide-eclipse?

David Festal

@davidfestal

and I'm not sure it's really interesting, since we produce OSGI artifacts, (it's not typical maven products), and don't use the Maven release process to push to some maven release repositrory

ah, don't remember exactly

I'll have to check

did you try both ?

Bastien Jansen

@bjansen

I just noticed that I built it with JDK 8 (including the embedded distro), but the distro is always built with a JDK 7 when it's released

so I don't know if it could cause problems when opening projects configured with a JDK 7 for example

David Festal

@davidfestal

possible yes

try with Java7

Stéphane Épardaud

@FroMage

@davidfestal does the Eclipse IDE support Java files that depend on Ceylon files in the same module?

David Festal

@davidfestal

well, partly only

Stéphane Épardaud

@FroMage

because I'm seeing errors

in a java file that can't see the ceylon file right next to it

so asking if this is normal

David Festal

@davidfestal

it might be normal yes

Stéphane Épardaud

@FroMage

ah, ok

Stéphane Épardaud

@FroMage

very very unfortunate

John Vasileff

@jvasileff

Are there also errors in Ceylon files? IIRC, 1) errors appear in Java files that depend on Ceylon declarations, 2) Ceylon sources are compiled, 3) Java sources are re-compiled, making the errors disappear

I don't recall if (3) happened for me when there are errors in (2)

Francois Green

@fwgreen

Eclipse Oxygen has been released. Is it safe to try the Ceylon plugin with it?

Where communities thrive

People

Repo info

Activity