Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 21 08:27
    Kopilov closed #662
  • Nov 21 08:27
    Kopilov commented #662
  • Nov 21 08:27
    Kopilov closed #506
  • Nov 21 08:27
    Kopilov commented #506
  • Oct 28 07:13
    momomo commented #7454
  • Oct 28 07:12
    ShalokShalom commented #7454
  • Oct 27 23:26
    OndraZizka commented #7454
  • Sep 21 08:49
    ShalokShalom commented #7454
  • Sep 21 08:48
    ShalokShalom commented #7454
  • Sep 21 08:47
    ShalokShalom commented #7454
  • Sep 21 08:46
    ShalokShalom commented #7454
  • Sep 21 08:45
    momomo commented #7454
  • Sep 21 08:44
    ShalokShalom commented #7454
  • Sep 21 08:43
    ShalokShalom commented #7454
  • Sep 21 08:20
    luolong commented #7454
  • Sep 20 13:49
    ShalokShalom commented #7454
  • Sep 20 13:36
    momomo commented #7454
  • Sep 20 13:30
    ShalokShalom commented #7454
  • Sep 20 13:18
    momomo commented #7454
  • Sep 20 13:17
    momomo commented #7454
John Vasileff
@jvasileff
The biggest unknown is probably the Eclipse Foundation stuff, so it would be great if someone could take on the role of coordinating with them, and finding out what must be done for us to make a release
Pedro Lamarão
@pedrolamarao
I'm intent on experimenting the build instructions for Ceylon SDK. Is there a usable alternative to the Docker steps? Is Docker mandatory?
John Vasileff
@jvasileff
You just need to run ant publish, ant test, and the like, as in the readme https://github.com/eclipse/ceylon-sdk
But if you are using Ceylon 1.3.3, you'll need to checkout 1.3.3 compatible code - the master branch is not compatible
The tag _old/1.3.3-branching should probably work
Pedro Lamarão
@pedrolamarao
OK, I'm setting things up and documenting my steps.
John Vasileff
@jvasileff
I'm sure I'm missing some of the problems you are running into, but there shouldn't really be anything to set up to compile the SDK beyond what you are doing for your own projects. The SDK is just a regular Ceylon project. Even commands like ceylon compile and ceylon test should work.
IIRC, the only SDK module with any special support from the language is ceylon.test. The rest are just standalone modules that happen to use the ceylon namespace.
Pedro Lamarão
@pedrolamarao
I tried following the initial steps on a Windows 10 system command prompt yesterday and did not succeed. I'll set up a Linux system soon to try again.
John Vasileff
@jvasileff
Are you trying to build all of Ceylon, or just the Ceylon SDK GitHub project?
Pedro Lamarão
@pedrolamarao
I'm attempting to follow https://github.com/eclipse/ceylon/blob/master/dist/RELEASE.md, yes.
The first bits.
John Vasileff
@jvasileff
Oh, I see. So that's Ceylon itself, not the SDK.
I wouldn't follow those particular directions, that's for making public releases.
Pedro Lamarão
@pedrolamarao
ant dist succeeds but ant sdk fails
John Vasileff
@jvasileff
Instead, look at the README
Pedro Lamarão
@pedrolamarao
The first failure I could spot is a .bat file not found.
John Vasileff
@jvasileff
I think ant sdk just does basically cd ../ceylon-sdk && ant publish or something
Pedro Lamarão
@pedrolamarao
I have WSL on a development machine, maybe the procedure on Linux is good.
John Vasileff
@jvasileff
https://github.com/eclipse/ceylon/blob/master/dist/BUILD.md rather than RELEASE.md
I'd be slightly surprised if everything didn't work on Windows, but yeah, a Unix-like environment would definitely work. I've only built on Mac and Linux
Pedro Lamarão
@pedrolamarao
I'll retry soon.
John Vasileff
@jvasileff
You can also use the script I put together for GitHub Actions as a reference
Pedro Lamarão
@pedrolamarao
Thanks!
John Vasileff
@jvasileff
Sure, good luck!
Wojciech Potiopa
@Voiteh
i was not able to buld dist on windows switching to linux solved issues
John Vasileff
@jvasileff
I’ll look into adding Windows to the CI build matrix next week. We certainly need it at least to run tests
Pedro Lamarão
@pedrolamarao
Master ant dist built without errors on WSL Debian (oracle jdk 7, ant 1.9) here.
Pedro Lamarão
@pedrolamarao
_old/version-1.3.3 has errors on WSL Debian (oracle jdk 7, and 1.9) here.
Wojciech Potiopa
@Voiteh
@jvasileff can You take a look on #7460 some of commits are labeled with ! can You check them I don't seem to understand everything there. I'm in 1/3 of the list...
fill0llif
@fill0llif
I'm trying to follow what's on https://github.com/eclipse/ceylon/blob/master/dist/BUILD.md but trying to clone the repository I'm having this error
error: RPC failed; curl 18 transfer closed with outstanding read data remaining fatal: the remote end hung up unexpectedly fatal: early EOF fatal: index-pack failed
What happened?
fill0llif
@fill0llif
Wojciech Potiopa
@Voiteh
If anyone could give me a hand here eclipse/ceylon#7460 we could finish before end of march
There is 115 commits left
fill0llif
@fill0llif

If anyone could give me a hand here eclipse/ceylon#7460 we could finish before end of march

I just pick a commit on the _old/master branch straight from github and review it, right? And then put the info in the list, like every other commit that has already been reviewed there, right? Does it require me some specific knowledge? I believe it would get me a certain amount of time anyway

Wojciech Potiopa
@Voiteh
Well it would be good to have some knowledge of what happening in the code but for me it is not always the case. Those commits I mark with ! as when I'm not sure what is there and is it introducing backward compatiblity break. Most of commits are readable if You know Java. Dev team also made most of them obvious through the commit message and metadata on github tickets with labels and description.
If You don't know what happening in the commit just take next one, it sometimes is understadable after reviewing few what was happening in the first one, again from commit message or reference to the ticket
Wojciech Potiopa
@Voiteh
13 commits left !
Pedro Lamarão
@pedrolamarao
Thanks your your hard work!
Wojciech Potiopa
@Voiteh
I guess I finished
there are bunch of commits marked with !
that I'm not sure what they does as no refernce to issue or detail description is present
there is also one with !!! that it needs to be changed before relase (version changes from 1.4.0 to 1.3.4 needs to be done)
@jvasileff If You could look into it, would be perfect
Wojciech Potiopa
@Voiteh

So I created release branch https://github.com/Voiteh/ceylon/tree/release/1.3.4 and successfully merged content from _old/master up to 4c45a73508 with exclusions of

 - breaking changes

and

! not sure

I used patches as change carriers, but this is not good way as after few I got lost which one has been applied and which one not. Still the code compiles. I compiled simple program with it and it runs .
It is around half the way. Begging with a130339d4athere starts problems, with merge. It may be that some changes was ignored in previous commits

Wojciech Potiopa
@Voiteh
Ok this time I merged up to d2fb43c73c this is pre last commit before eclipse-renaming ant clean dist finishes succesfully for merge. I used Intellij and cherry picking. Rest must be merged manually :/
Wojciech Potiopa
@Voiteh
Up to 44b9436cfd 11 to go
Wojciech Potiopa
@Voiteh
@jvasileff Do we need to do the same work in sdk ? I looked into some commits and there were changes in api for ceylon.interop.persistance probably we should exclude those commits from release?