These are chat archives for chandu0101/scalajs-react-components

20th
Dec 2015
Alexej Haak
@Daxten
Dec 20 2015 19:49
ah @codingismy11to7 thanks for the icon wrapper
looking at the code, I haven't done anything with scala macros yet, but it looks a bit overkill isn't it?
Alexej Haak
@Daxten
Dec 20 2015 19:59
But actually, I wouldnt know right now how to make it shorter.. but there must be some way to type this :)
Alexej Haak
@Daxten
Dec 20 2015 20:16
hmm ListItem is behaving strangely for me, I can't really use rightIconButton and stuff like that, it positions them wrong (into the top right corner, instead of layouting them nicely)
is that working for someone or is it a mistake by me?
Øyvind Raddum Berg
@oyvindberg
Dec 20 2015 21:18
i havent tested it more than the what you see in the demo project @Daxten
in these cases it's always great if we can figure out if the problem is in the wrapper or in material-ui itself, or if its an issue with some other css that conflicts
Øyvind Raddum Berg
@oyvindberg
Dec 20 2015 23:32
i managed to find another way of adding all the svg icons without completely overwhelming the compiler
hey, i felt inspired to close that hole and add the svg icons now - have a look at chandu0101/scalajs-react-components#59
@codingismy11to7 @rleibman @Daxten ^^
i had planned to experiment with exposing things as JsComponentType and the likes anyway, so this provided a nice opportunity to do it
Alexej Haak
@Daxten
Dec 20 2015 23:33
ah great ! :)
so basicly what I found is that pretty much all these examples won't work out of the box with the wrapper -> http://www.material-ui.com/#/components/lists
when debuging the resulting dom tree, it looks similar to the one in the official examples but has different styling on the dom nodes, which is strange imo
I have no experience with this lib yet, so I dont know exactly how it works
Alexej Haak
@Daxten
Dec 20 2015 23:39

but I think that

     rightIcon={<ActionInfo />} // jsx

isn't really the same as

     rightIcon = ActionInfo()())  // scala

or there is still some wrapping or whatever going on..

since I started writing, I will check the dom tree once more
Alexej Haak
@Daxten
Dec 20 2015 23:45
it's only padding: 12px missing on the svg icon
but I don't know why it isn't getting added
doesn't seem to me like a problem the wrapper would create
Øyvind Raddum Berg
@oyvindberg
Dec 20 2015 23:59
hah, that's both weird and interesting