These are chat archives for chandu0101/scalajs-react-components

21st
Dec 2015
Øyvind Raddum Berg
@oyvindberg
Dec 21 2015 00:00
if you add the react dev tools you can see the state and props of all the components - should make it easy enough to see where the difference is
Øyvind Raddum Berg
@oyvindberg
Dec 21 2015 00:48
ive looked at this 30 minutes now too @Daxten - really no idea so far
it gets rendered wrong no matter what i do so far
boom - and then i refresh and it looks ok, wtf
with the new icons i just added it looks alright anyway, as far as i can see
gotta do something about all those empty parenthesis - MuiListItem(primaryText = "Follow up", rightIcon = ActionInfo()())() is pretty ridiculous
Alexej Haak
@Daxten
Dec 21 2015 01:30
ah great, I will check out the new icons then :)
yeah the ())()()() parts are getting messy there
starts to look like scheme :worried:
Øyvind Raddum Berg
@oyvindberg
Dec 21 2015 01:36
haha yes, and thats not in the good sense either
Steven Scott
@codingismy11to7
Dec 21 2015 04:25
there's some cases where 12px of padding are added unnecessarily and it messes things up. add some menu items to a menu icon, and set their checked property to true. they disappear until you remove the padding, and are completely wrongly positioned
so, I wasted a day of trying to get icons working that you could've done immediately? thanks a lot
haha
Steven Scott
@codingismy11to7
Dec 21 2015 04:35
@elacin how's the jar size before and after? with my macro it was huge and terrible, and even worse with the auto generated code. also, are you aurogenerating the classes from upstream? might've missed something in the check-in, so just asking if there's a script
Øyvind Raddum Berg
@oyvindberg
Dec 21 2015 09:56
haha hey, you both managed to do it, and got me to have a look at it - nothing wasted there! :)
i didnt check in a script to do it, simply because i just copy/pasted the list of icon names
im generating more or less the entire material-ui wrappers, so i will include the icons there at some point
im going to open up that code at some point, just trying to clean it up and generalize it a bit
but of course there is never time to do that right
havent looked at the jar size yet - but i dont see a reason why it should have grown with more than the list of names
Alexej Haak
@Daxten
Dec 21 2015 14:14
is your version already pushed to maven @elacin? can't find your pull request on github anymore
Øyvind Raddum Berg
@oyvindberg
Dec 21 2015 14:56
i merged it, havent released yet
will update the changelog with some info and then push it tonight or so
Roberto Leibman
@rleibman
Dec 21 2015 17:56
Hey... I'm seeing a problem with MuiIconMenu, I have one all the way to the left of the page, when I click on it the menu opens "off page". Has anyone seen this or know of a fix?
Alexej Haak
@Daxten
Dec 21 2015 18:36
no, but I have the same problems with icons there.. but maybe @elacin push fixes that
icon is not colored right and has no padding for me
Steven Scott
@codingismy11to7
Dec 21 2015 18:37
i’ve found that checked just doesn’t work, but for leftIcon and rightIcon if you stick it in an IconButton all the styles come out correctly
maybe not color, not sure about that, but you can specify a color
Alexej Haak
@Daxten
Dec 21 2015 18:45
I will try it with an icon button thanks
y styling is correct (except color) :-) thanks
Steven Scott
@codingismy11to7
Dec 21 2015 18:50
:+1:
Alexej Haak
@Daxten
Dec 21 2015 18:55
 MuiPaper(style = js.Dynamic.literal("position" -> "fixed"))()
is there a helper method to convert a scalajscss style so I can use it here?
Steven Scott
@codingismy11to7
Dec 21 2015 21:29
i’m not super familiar with scalacss, but i assume @japgolly would have to add in support for creating a plain JS object with the names converted (ie from background-color to backgroundColor)
may be possible to write some code that could do it, /shrug
Roberto Leibman
@rleibman
Dec 21 2015 22:43
Hey @elacin... I figured out how to get my menus to show up.... on MuiIconMenu, I added a openDirection attribute, which allows me to open the menu bottom-right. It's not quite what I wanted (I normally expect menus where they have space to open), but in this particular instance it works.