These are chat archives for chandu0101/scalajs-react-components

28th
Jun 2016
Raul Rodriguez
@raul782
Jun 28 2016 00:34
hello guys, after trying to upgrade to diode 1.0.0, I’ve noticed that they’re using scalajs-react 0.11, which requires react 0.15, I know there is a PR in the works to support material ui 0.15 which actually would support react 0.15. Is there a way to add a list of bullet points in the PR, so we can see what’s left and how could we help
until that happens, it looks like I won’t be able to upgrade and I’ll have to stick with diode 0.5.2
Chandra Sekhar Kode
@chandu0101
Jun 28 2016 00:35
@oyvindberg are you around… ?
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:01
Yeah ive just had some busy weeks, between work and watching the euro xD
The mui 15 branch should work perfectly if you publishLocal it, for example
The only thing not done is that i think i read there were some breaking changes in some callbacks
Just havent checked up on that so far
Chandra Sekhar Kode
@chandu0101
Jun 28 2016 06:10

Yeah ive just had some busy weeks, between work and watching the euro xD

often times these things show the value of contributor! :D

Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:14
Haha yeah i suppose :)
Raul Rodriguez
@raul782
Jun 28 2016 06:15
:smile:
I was going over the PR and I noticed that we’re using react 15.0.2, now that 15.1 and pretty soon 15.2 is coming. Is there a blocker to go to the latest version on this branch?
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:18
Well, we would probably only suppory whatever japgolly has upgraded his wrapper to
Though im pretty sure you will finf newer versions to work just fine
I ran 0.13 for months while he was on 0.12
That said i have no idea what they have changed recently
Raul Rodriguez
@raul782
Jun 28 2016 06:21
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:22
Yes, seems right
Should update it then
Raul Rodriguez
@raul782
Jun 28 2016 06:23
I noticed an issue related to react-select (it’s stuck at beta9) because of a semserver issue, JedWatson/react-select#971, not sure if we should update to beta13, or wait for the rc which will solve this issue
btw, there is probably something wrong that I’m doing but tried to compile the PR, but got an error, when accessing this page:
http://localhost:8090/#materialui/info
index-bundle.js:1250 Warning: React.createElement: type should not be null, undefined, boolean, or number. It should be a string (for DOM elements) or a ReactClass (for composite components). Check the render method of `AsyncLoadC`.

index-bundle.js:834 Uncaught Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. Check the render method of `AsyncLoadC`
I’ve been trying to debug this item, but I can’t come up with a solution.
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:30
Hah, i thought i fixed that
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:31
Its a symptom thst the code tries to use mui before the javascript is actually loaded
Raul Rodriguez
@raul782
Jun 28 2016 06:31
oh Ic
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 06:32
I might have a commit for that i just havent pushed yet
Dont have the laptop here to confirm
Anyhow vacation starts on friday, so i should have a few hours to wrap this up soon :)
Raul Rodriguez
@raul782
Jun 28 2016 06:40
@oyvindberg sounds great, if by any chance you have a list of tasks to work to close this PR, I’ll be happy to help, I’m still learning scalajs and all the ecosystem, but the more I dive and possibly contribute into the different libraries the more I understand.
Øyvind Raddum Berg
@oyvindberg
Jun 28 2016 07:00
Sure thanks