These are chat archives for chandu0101/scalajs-react-components

17th
Jun 2017
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 13:44
great, i pulled the newest now
goddamn, MuiTextField has about 100 props now :D
Roberto Leibman
@rleibman
Jun 17 2017 17:39
Yeah, because it passes stuff down to it's input
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 17:41
yeah, you saw i had already sketched most of the implementation for it :)
ive been working a few hours now, fixing a bit of breakage in mui demos, and a few tweaks to the generator
can you give me a commit bit for your branch?
i cant add you to the main repo it seems
Roberto Leibman
@rleibman
Jun 17 2017 17:42
I'm not sure how to do that, let me see.
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 17:43
or we just just need to ping @chandu0101 for that bit, i suppose
you can add me as a contributor to your repo
Roberto Leibman
@rleibman
Jun 17 2017 17:44
There.
I've got to go... Wizard World!
CYL
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 17:44
great, enjoy!
might be until tomorrow that i push, i expect to be suddenly interrupted soon :)
by the way, something for you to think about for tomorrow
i propose we kill the UHelperReactNode implicit
its of help if you have two implicits, say String => VdomNode and VdomNode => js.UndefOr[VdomNode], which the scala compiler wont help you with
but i found it in the way now with refactoring at least, so ive been replacing it with explicit js.defined to help instead
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 18:17
[error] Could not write class demo/components/elementalui/EuiFormsDemo$Backend because it exceeds JVM code size limits. Method chandu0101/scalajs/react/components/elementalui/NoteType$'s code too large
grr
Øyvind Raddum Berg
@oyvindberg
Jun 17 2017 19:07
ok, push didnt work
it builds now
demo is not quite working, but thats not unexpected, we will need to convert the wrappers to use @JSImport i suppose
no time for that tonight