These are chat archives for chandu0101/scalajs-react-components

19th
Jun 2017
Roberto Leibman
@rleibman
Jun 19 2017 01:05
No worries, hey, it compiles: ship it!
Any idea what's wrong or where to start?
And do you know if it needs to run in a server, or should static file also work?
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 08:10
yeah, i have worked a bit further, and am happy to report that mui now works just as well as before
although that required some hacks, and reinstating the old bundles files
should we go through with @JSImport at once? or postpone that?
Roberto Leibman
@rleibman
Jun 19 2017 17:23
I say pull the bandaid quickly.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:22
haha, well put
it's actually pretty simple to do
Roberto Leibman
@rleibman
Jun 19 2017 20:23
Do you have a newer push with the demo in better shape?
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:24
i can push my very wip right now if you want
Roberto Leibman
@rleibman
Jun 19 2017 20:25
Please, thanks!
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:25
i have mui/sui mostly working
about to figure out eui
and then there is a lot of resource loading left
and the other small libraries
shall i push directly to your branch?
i mean its very WIP, but it has been that way all along i suppose :)
Roberto Leibman
@rleibman
Jun 19 2017 20:30
Yes. sure.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:31
there you go
Roberto Leibman
@rleibman
Jun 19 2017 20:48
Thanks. Are you using scalafmt?
The code keeps on changing on my end because of reformatting, we use default values for it here, if you use it, can you check in your .scalafmt.conf so that we stop falsely changing code on each other?
Or if you prefer I can turn it off for this project.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:50
i was going to propose we use it
Roberto Leibman
@rleibman
Jun 19 2017 20:50
Ha, well, there you go :)
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:50
if you want, you can reformat everything right away
pull my latest patch from just two min ago
reformat it, and push again
can you bump columns up to 100?
i seem to remember 80 is default, and i think this project has a lot of wide lines
Roberto Leibman
@rleibman
Jun 19 2017 20:52
I always do, I have the plugin in my ~/.sbt/0.13/plugins/
Yeah, I can bump that.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:52
so do i, it feels amazing to not have to think about formatting much anymore
Roberto Leibman
@rleibman
Jun 19 2017 20:57
I just pushed, with a conf file.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 20:58
great!
have you experimented with the webpack dev server?
Roberto Leibman
@rleibman
Jun 19 2017 20:59
No, not yet.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:00
demo/compile:fastOptJS::startWebpackDevServer
it's... well, i dont know, almost working, sometimes
Roberto Leibman
@rleibman
Jun 19 2017 21:00
On my main scala project I use akka-http for the REST interface, so I just have a special route for my project, and I was using nginx locally to test.
But that's a good hint!
Roberto Leibman
@rleibman
Jun 19 2017 21:06
Oh man! It's alive!
Super cool!
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:06
woooo
Roberto Leibman
@rleibman
Jun 19 2017 21:06
I can't believe it, after so much freakin' work!
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:07
yeah i was gonna make a point that lucky for us it wasnt much work involved getting it there, haha
Roberto Leibman
@rleibman
Jun 19 2017 21:07
haha.
Something else to do is to put in an example project as well. And of course, update the readme.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:11
yes, there is still some polishing to do
i will go over and finish the remaining @JSImports now
Roberto Leibman
@rleibman
Jun 19 2017 21:24
Turns out that eui was commented out in the router, I put it back in and it's somewhat there. There's runtime errors, but some of it shows up.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:26
i found that too :)
ive also fixed the runtime error
something must have changed in scala or in scala.js there for that to break
Roberto Leibman
@rleibman
Jun 19 2017 21:26
Which error?
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 21:27
-class ModalSize(val value: String) extends js.Any
+case class ModalSize(value: String) extends AnyVal
there, that first pattern no longer works
pull again now
Roberto Leibman
@rleibman
Jun 19 2017 21:40
Odd, the inline property in EuiCheckbox breaks at runtime.
So I'm taking that out.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 22:03
so i ran scalafmt locally, and got a huge diff
so i pushed it, lets hope that out scalafmts will converge eventually :)
Roberto Leibman
@rleibman
Jun 19 2017 22:04
Do you have your own custom config?
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 22:05
[olvind:~/pr/scalajs-react-components] rleibman+ ± cat .scalafmt.conf 
align = true    # For pretty alignment.
maxColumn = 100 # For my wide 30" display.[olvind:~/pr/scalajs-react-components] rleibman+ ± scalafmt
[olvind:~/pr/scalajs-react-components] rleibman+ 10s ± 
[olvind:~/pr/scalajs-react-components] rleibman+ ± scalafmt -v
scalafmt 1.0.0-RC4
there was a scalafmt on a missing line in the middle there
that leaves me with no diff now
Roberto Leibman
@rleibman
Jun 19 2017 22:08
ah, cool.
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 22:21
from clean to webpacked artifact is exactly 200 seconds
phew
thats pretty insane, considering none of the code really does anything
Roberto Leibman
@rleibman
Jun 19 2017 22:35
Do you find yarn faster?
Øyvind Raddum Berg
@oyvindberg
Jun 19 2017 22:37
i have only used that lately, it is much faster... if you cache yarn.lock, which we dont do
Roberto Leibman
@rleibman
Jun 19 2017 22:37
ah.
Roberto Leibman
@rleibman
Jun 19 2017 23:33
I've got elemental looking nice, I'm not happy with how I got there though, I added a link to the css in index.html, I couldn't find a css for elemental in the npm package, so I have no clue how it's supposed to be embedded in our project.