These are chat archives for chandu0101/scalajs-react-components

21st
Jun 2017
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 20:57
i feel there is a set of things i want to make better, but i will agree that we only do the most important things right away
lets at least clear up all the warnings in the demo
also we need to fix all the external css and resources
Roberto Leibman
@rleibman
Jun 21 2017 20:58
I sort of kind of did that, at least it's looking better... did you synch today?
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 20:58
i havent synched
Roberto Leibman
@rleibman
Jun 21 2017 20:58
ah, do so, you may be surprised :)
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 20:58
fantastic
ok, so another thing
i will be more or less offline until tuesday
how about you fix whatever you feel like fixing until then
and then if theres something more i can fix it, and then cut a release?
Roberto Leibman
@rleibman
Jun 21 2017 20:59
Mostly I'm trying to see how far my real work project needs to be fixed, things look much uglier now.
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:00
sure, do whatever you need to get your project going
thats more or less what we should aspire to for now
Roberto Leibman
@rleibman
Jun 21 2017 21:02
all the needed js.defines are ugly, as are a bunch of conversions to get the vdomelement out of a component to pass it to a method for example:
If I want to pass a component to the actions of a MuiDialog I need to use component.vdomElement, but if I want to pass a tag, I apparently need to pass <.div().render
But as I'm working on my project I'm finding a couple of things that I've had to go back and fix in the library.
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:03
we can re-add the implicit conversion to get rid of the js.defineds
Roberto Leibman
@rleibman
Jun 21 2017 21:03
I also hate all the toTagMod junk
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:03
i took it out because it was confusing while migrating
Roberto Leibman
@rleibman
Jun 21 2017 21:03
Ah.
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:05
also you dont need to say .vdomElement if you have the right implicits in scope
import japgolly.scalajs.react.vdom.html_<^._ should take care of that
Roberto Leibman
@rleibman
Jun 21 2017 21:05
Yeah, it doesn't.
That's what I have in scope.
I agree that it should.
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:06
perhaps the return type of component (referring to what you said above) is wrong
but that should have worked, and that is a convention we should work out
Roberto Leibman
@rleibman
Jun 21 2017 21:07
I'm less sure about the type of MuiDialog.actions,
Øyvind Raddum Berg
@oyvindberg
Jun 21 2017 21:09
i havent needed that functionality, so i havent looked into it
just pulled, changes looks good :)
Roberto Leibman
@rleibman
Jun 21 2017 21:25
I think we're close to be able to release... I'd like it if you could figure out:
  • Putting the implicits back
  • The vdomelement issue
  • If there's any way to avoid having to convert a seq of vdomnodes into a TagMod
    Mostly because these have been a pain in the neck to change in my "real" code, if it wasn't for these isuses the transition would have been much less painful. I'm thinking of the person who may be trying to migrate the old version to the new version, with as few changes as possible.
But if you like the way it already is or don't have time to look at these, I'd prefer to see a release and see if there's any bug reports.