These are chat archives for chandu0101/scalajs-react-components

25th
Jan 2018
Roberto Leibman
@rleibman
Jan 25 2018 00:11
No kidding.
Anyway, here's what I came up with:
          /* Similar to the above, but we have a ternary node*/
          case ternary: TernaryNode =>
            ternary.getTest match {
              case testNode: BinaryNode =>
                testNode.rhs match {
                  case test: LiteralNode[String] =>
                    if ((test.getValue == "production" && testNode.tokenType() == TokenType.NE_STRICT) ||
                      (test.getValue == "development" && testNode.tokenType() == TokenType.EQ_STRICT)) {
                      //Use the true Expression
                      ternary.getTrueExpression.getExpression match {
                        case o: ObjectNode ⇒
                          ret(CompName(a.getBase.asInstanceOf[IdentNode].getName)) = o
                      }
                    }
                    else {
                      //Use the false Expression
                      ternary.getFalseExpression.getExpression match {
                        case o: ObjectNode ⇒
                          ret(CompName(a.getBase.asInstanceOf[IdentNode].getName)) = o
                      }
                    }
                }
            }
That maybe fixes Sui... the next problem is in Mui
But I can deal with that one, since I left a message to myself as to what ta do.
Roberto Leibman
@rleibman
Jan 25 2018 00:47
OK, I pushed my changes, actually, I accidentally pushed to your repo instead of mine (I didn't realize I had rights, thanks!). Anyway... the generation now compiles, I need to fix the demo, as things were changed a bit upstream in MaterialUi
Øyvind Raddum Berg
@oyvindberg
Jan 25 2018 00:50
great, that looks good
and yeah, i gave you rights at some point so you could merge this when you wanted, hehe
me being slow and all that
Roberto Leibman
@rleibman
Jan 25 2018 00:51
Are we going to release from your repo, or from chandu0101?
Øyvind Raddum Berg
@oyvindberg
Jan 25 2018 00:52
chandu i guess
feel free to remove the commit i added that broke the branch btw
we should still use that, but it doesnt have to be now
Roberto Leibman
@rleibman
Jan 25 2018 00:57
What was the commit? I've got everything nearly building
Øyvind Raddum Berg
@oyvindberg
Jan 25 2018 01:00
the make it fast commit
it broke jenkins iirc
Roberto Leibman
@rleibman
Jan 25 2018 01:03
If it's still broke after I'm done I'll take a look... I've moved it over to sbt 1.0.x btw.
ok, it all compiles on my machine now, I've checked everything in too.
I have to call it a day.
Øyvind Raddum Berg
@oyvindberg
Jan 25 2018 01:23
cool, well done :)