These are chat archives for chandu0101/scalajs-react-components

27th
Mar 2018
Bijan Chokoufe Nejad
@bijancn
Mar 27 2018 07:35
I see. Thanks @oyvindberg. I think it's fine to have these breaking changes in 1.0 but a changelog is kind of needed then
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 17:57
Yeah, frankly that 1.0 label is premature for this project, we just wanted to slap it on it because we simplified maintenance a lot.
going forwards we'll probably break up all the wrappers into separate projects
Roberto Leibman
@rleibman
Mar 27 2018 17:59
...and because we started using scalajs-react which also went to (and then past)1.0. Though if you define 1.0 as proudction ready, I'd say it is (since I'm using it in production)
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:03
well yes, your code will work in production, but I don't feel we can give very firm guarantees that you don't have to change said production code when upgrading this library
Roberto Leibman
@rleibman
Mar 27 2018 18:03
True
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:04
i would still love to completely replace the encoding we use for components
but i dont have the time to even start
Roberto Leibman
@rleibman
Mar 27 2018 18:04
What do you mean?
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:04
i want to use @ScalaJSDefined traits for props
kill the macro, and provide a small library to replace it
Roberto Leibman
@rleibman
Mar 27 2018 18:05
I hate the macro (for the record) :)
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:05
me too
Roberto Leibman
@rleibman
Mar 27 2018 18:06
You don't have time to do much, and frankly, I don't have that much more either... but why don't you start a doc with your forward ideas in the repo, that way next time someone has time they can go there and work on it.
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:07
well yeah, it would be a good meta issue to open
but on the positive side what we have now works
Roberto Leibman
@rleibman
Mar 27 2018 18:09
If you don't mind, open the issue, and if possible, write a sample component that looks the way you'd like it to. I'd really like to understand all of the code, and the macro is constantly in my way.
Also... people are clamoring (ok, that's a strong word) for the 1.1.0 release. I'm pretty happy with it as it's working for me. Do you have an idea for what the release "goals" are so that we can measure them and say when we're done?
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:10
im happy to move forward with that whenever you are
we need to setup a sonatype org
Roberto Leibman
@rleibman
Mar 27 2018 18:10
True.
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:10
i mean, i can certainly do it as well
but i guess the point of the new org is to enable other people to do it as well
Roberto Leibman
@rleibman
Mar 27 2018 18:11
Right, I'll create it.
Is there such a thing as a sonatype org? or do you mean a new project?
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:14
well, i don't have much experience
let me check
Roberto Leibman
@rleibman
Mar 27 2018 18:15
Is your username there the same as here? (oyvindberg)
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:18
it is to log in at oss.sonatype.org at least
Roberto Leibman
@rleibman
Mar 27 2018 18:18
ok, I'll add you to the ticket.
Øyvind Raddum Berg
@oyvindberg
Mar 27 2018 18:19
cool