These are chat archives for chandu0101/scalajs-react-components

4th
Apr 2018
Bijan Chokoufe Nejad
@bijancn
Apr 04 2018 12:27
Have the import chandu0101.scalajs.react.components.Implicits._ been removed or moved?
Bijan Chokoufe Nejad
@bijancn
Apr 04 2018 12:32
ah no they are private now :disappointed: .. I think we were using them to write e.g. MuiTab(label = "General Data", value = 0) instead of MuiTab(label = VdomNode("General Data"), value = 0) . Or did the interface of MuiTab etc change?
Bijan Chokoufe Nejad
@bijancn
Apr 04 2018 12:41
What I also found weird is that Mui.SvgIcons.ActionPanTool.apply used to take a MuiColor but now takes a String ?
√ėyvind Raddum Berg
@oyvindberg
Apr 04 2018 21:48
@bijancn yes, those implicits are gone. IMO this library was/is too invasive in what it does, and removing those were part of cleaning up a bit. I suggest you either specify js.defined(...) yourself, or copy the old implicits if you liked them
also yes, that label prop is changed. Typing things up in this way is an iterative process, and we try to make it better
about CssColor i see @rleibman rewrote those to String at some point, I'm not sure if there was good reasons for that?
personally i would change it back, though it has been Strings all along