These are chat archives for chandu0101/scalajs-react-components

9th
Apr 2018
Bijan Chokoufe Nejad
@bijancn
Apr 09 2018 11:44
@rleibman In case you are using react 16, you can use fragments for this https://github.com/japgolly/scalajs-react/blob/master/core/src/main/scala/japgolly/scalajs/react/vdom/ReactFragment.scala . I bumped into a similar issue (wanting to give multiple elements and not wrap them in a div because it's a table) but finally gave up and did it another way with a big TODO to change it with React 16
Roberto Leibman
@rleibman
Apr 09 2018 14:25
Unfortunately, using ReactFragment didn't work, but using toVdomArray did! I think this is also one of the things that comes with ReactJS 1.2 (I'm using the 1.1.0 branch of the components, which I don't quite want to release yet because there's a lot in the Semantic-UI portion that has issues). I just pushed up some of my changes, so if you want to play with the 1.1.0 branch, go right ahead!
Roberto Leibman
@rleibman
Apr 09 2018 14:39
@bijancn @oyvindberg I'm switiching the color properties of SvgIcon back to MuiColor, I had originally changed it to a string because having a MuiColor object without any properties was not very useful. So I'm changing MuiColor as well and adding the enum values as given by https://material-ui-next.com/api/svg-icon/
Roberto Leibman
@rleibman
Apr 09 2018 14:47
Does that make sense? the MuiColor class is used by a lot of components (e.g. MuiTab, MuiListItem) is the MuiColor that we're talking about here used by SvgIcon the same type?