These are chat archives for chandu0101/scalajs-react-components

16th
Apr 2018
Andreas Gies
@atooni
Apr 16 2018 06:09
Hello again,
Andreas Gies
@atooni
Apr 16 2018 06:20

I have now a frech checkout of the project at https://github.com/scalajs-react-components/scalajs-react-components and I have not applied any of my changes. I have trie to run

fastoptJS::webpack

to compile the project. The project compiles with errors for me. I am really interested to gat my changes into the React Table, but right now we are considering to create the table outside of the project ourselves as well.

This is the output of sbt fastOptJS::webpack: https://gist.github.com/atooni/6e201502ed5d8ae30a234676799ca846

Any hints would be greatly appreciated.

Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 19:04
@rleibman that MuiColor trait you pasted up there doesn't make sense i think, i added it just as a typesafe version of a String
and for SvgIcon it's an enum, not an object, based on that documentation link
Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 19:10
@atooni that's confusing. i checked out newest master from that repo now, and did ;clean;demo/fastOptJS::webpack and it compiled find
sure you have cleaned up everything?
also, that said - I totally wouldn't mind if we started breaking this project up into smaller pieces
Roberto Leibman
@rleibman
Apr 16 2018 19:10
After 1.1.0?
Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 19:12
ok, that was master branch
let's try 1.1.0
Andreas Gies
@atooni
Apr 16 2018 19:13
Yes, I did a clean checkout completely independent from my changes
tried with 1.1.0 and master
Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 19:15
ok, I got the same compile error for 1.1.0 branch
Andreas Gies
@atooni
Apr 16 2018 19:15
ok
Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 19:15
seems we should enable travis build for the new repo ;)
im busy for 2-3 hours, can have a look afterwards
Andreas Gies
@atooni
Apr 16 2018 19:16
was just trying to get my head around the changes before I look into the table again
Øyvind Raddum Berg
@oyvindberg
Apr 16 2018 22:33
pff, references have changed again i see
this took longer than i have now
Roberto Leibman
@rleibman
Apr 16 2018 23:11
References?