Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Roberto Leibman
    @rleibman
    @dborisenko @here.... I've been really bad. A while ago, we forked the project to create a community project at https://github.com/scalajs-react-components/scalajs-react-components. I have not been able to work on it, though I have made a few changes to some of the semantic-ui things. Anyway, I am about to get back into it. And here are my plans:
    • Full Tech refresh, latest react, latest scala, latest scala.js, latest scalajs-react.
    • Split the project into a number of projects
      • Core and macro
      • Semantic UI
      • Elemental UI
      • Material UI
      • Other wrapper projects
      • Other custom components written in scala (besides the ones already in the repo, I'll add a few of my own)
        I'm going to start with what I have and then try to merge Denis' changes.
        Once it's all done, I'll try to deploy this to the mvn repo, that's already been set up a while ago.
    Roberto Leibman
    @rleibman
    ok, my first step is done, things are compiling under branch 1.1.0, now I continue with the tech refresh.
    Hey... @dborisenko I'd love to work with you to try to figure out what it is you did... I see that you moved things around a lot, but you also removed huge sections of code, including all of MaterialUI and ElementalUI... what time/timezone works for you to talk about it?
    Denis Borisenko
    @dborisenko
    Hi @rleibman, well, yes, I moved around a lot of code. The main reason was to split one monolith project with all possible components to multiple smaller ones. It helps to keep track on dependencies and update only what’s needed. I also changed package names - the original thought was to be able to use monolith scalajs-react-components together with my refactored libraries, but I ended up completely moving away a lot of stuff and refactoring. I also added unit tests to simplify upgrade process. And I dropped some libraries. First of all, I needed only semantic-ui. In second, there are some libraries without any support. I think, elemental-ui doesn’t have react 16 support and I found somewhere that support of that library is discontinued. So, this was, in short, my motivation.
    But we can have a chat. My time zone is CEST (GMT+1)
    Roberto Leibman
    @rleibman
    @dborisenko @trepidacious ... I think I like the idea of multiple sbt projects for different parts, I'm not sure if mono-repo or multi-repo. Either way.... yes, I understand the need to remove those things that cannot work with the latest react. But I know a few people are using material-ui, so I think I'd keep at least that. I myself only use semantic-ui out of this repo, and have a few other components for which I've built manual wrappers. I desperately need a couple of features out of the newer semantic-ui.
    I'm looking to see if there are other options besides this project (ahem... ) and some of 'em look promising and easier to manage and maintain, so I'm holding off from touching all this stuff for a bit.
    trepidacious
    @trepidacious
    @rleibman Before I ran into that I was wondering about using the same technique I used for my material-ui facade to semantic-ui. It seemed to be working out pretty well, I got a working facade to the latest mui going, I didn't get much of a chance to try it before running into the performance issues that have put me off mui ;)
    It's based on using react-docgen output to generate scala code, if the proptypes are ok in semantic-ui it might work ok. I'm a little worried that all the as='random' stuff might be hard though
    Roberto Leibman
    @rleibman
    ha ha... that's what I've been looking at... but @oyvindberg didn't want to make it public quite yet.
    trepidacious
    @trepidacious
    ah poop :(
    I deleted, no one will know!
    I think I'll try the react-docgen approach, the advantage there is it works straight from proptypes, so you don't even need a typescript file
    Roberto Leibman
    @rleibman
    I think he's close to announcing anyway... if it comes out right I could see it basically replacing the current project. It needs to be a little bit more palatable and easier to convert from the current code.
    Øyvind Raddum Berg
    @oyvindberg
    I'll setup a gitter channel and a roadmap for it :)
    But I really want to make usage a bit better first, it's hard to make up for a bad first impression
    trepidacious
    @trepidacious
    That makes sense, it's definitely needed so it would be great if it's successful :)
    Sorry about my terrible opsec :)
    Øyvind Raddum Berg
    @oyvindberg
    Don't worry
    trepidacious
    @trepidacious
    I also need to set aside some time to have a better play with it, I read through the semantic-ui examples, I was thinking I might try to do something non-trivial to get a better impression
    Øyvind Raddum Berg
    @oyvindberg
    That would be awesome
    For now we have identified one big improvement I think
    To generate companion objects with apply to create instances of traits, so you get more normal syntax
    Roberto Leibman
    @rleibman
    I did take out the components that were written in scala out of the library, and put them together with a few others I've written myself and put them here: https://github.com/scalajs-react-components/scalajs-react-components-scala. I figure that if we do jump @oyvindberg's project, we'd still want to keep these around.
    Roberto Leibman
    @rleibman
    If anyone has any components lying around that they want to share, please let me know, I can add them here.
    Øyvind Raddum Berg
    @oyvindberg
    thats awesome @rleibman - it's great to have a collection of those
    still working on those apply methods by the way, it became an interesting detour through jvm classfile limitations
    Roberto Leibman
    @rleibman
    Cool, thanks.... looking forward to it.
    Øyvind Raddum Berg
    @oyvindberg
    It's live by the way @rleibman - you can check diffs for usage here https://github.com/oyvindberg/ScalablyTypedDemos/pull/1/files