Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
    Charlie Dowler
    @charliedowler
    I do notice a slight performance increase from running status over check
    Jose Garcia
    @josebalius
    yeah? I mean its very noticeable on my end
    Charlie Dowler
    @charliedowler
    It's whether the initial server load causes it to slow down by much or not
    I guess I could compare stopping the server to garbage collection, is it best to leave a service running after our stuff is done?
    Jose Garcia
    @josebalius
    For me, not much at all, and the second time it was very fast. So i'm thinking that maybe status doesn't launch a new server every time but checks if one is already up?
    I would leave it running, but maybe do a GC check just in case to be sure?
    Charlie Dowler
    @charliedowler
    Yes, it uses the existing server. So the initial load is only once
    it would only shut down flow after the task has finished, not after every file
    Jose Garcia
    @josebalius
    hmm, my only thought about that, is that I use this task inside my watch task, so if im watching i would like it to be really fast and not have to spin up/power down a server on every save you know?
    Charlie Dowler
    @charliedowler
    ah I see
    would adding a killFlow option be a solution? defaults to true
    Jose Garcia
    @josebalius
    Yeah that could work
    basically i have been adding gutil.beep() in line 57, and use this task inside my watcher and it has worked great
    everytime there is a failure my terminal beeps and jumps
    Really nice experience
    Charlie Dowler
    @charliedowler
    awesome!
    Do you want to work on the PR for switching to status? also adding a killFlow option.
    optional of course
    see if we can speed up the plugin by a considerable amount
    Jose Garcia
    @josebalius
    Sure, i'll do the pr to switch to status, remove --lib option, add killFlow option, and can I sneak in the beep for errors? :)
    Charlie Dowler
    @charliedowler
    I was going to mention it, it could be a neat feature. Perhaps a different PR along with adding a beep option to disable (if necessary).
    Jose Garcia
    @josebalius
    cool
    will do
    i'll have something tonight/tomorrow
    Charlie Dowler
    @charliedowler
    cheers
    Jose Garcia
    @josebalius
    Okay, so when using the killFlow option, it takes about 5s to run the task for me, every time. When not using that option, it takes 5s to run the first time and then around 500-800ms every time after that
    charliedowler/gulp-flowtype#10
    Let me modify the readme
    Jose Garcia
    @josebalius
    Can you help me with the tests?
    Charlie Dowler
    @charliedowler
    @josebalius squashed :thumbsup:
    Jose Garcia
    @josebalius
    @charliedowler awesome, thanks! I'll submit a PR for the beep shortly with a beep flag.
    Charlie Dowler
    @charliedowler
    Thanks for your contributions
    Jose Garcia
    @josebalius
    np
    Charlie Dowler
    @charliedowler
    does npm run lint work ok for you?
    Jose Garcia
    @josebalius
    Yep
    ▶ npm run lint
    
    > gulp-flowtype@0.4.0 lint /Users/jgarcia/Sites/gulp-flowtype
    > jshint **.js && flow check --lib ./declarations/
    
    
    Found 0 errors
    Charlie Dowler
    @charliedowler
    I think the squash broke .flowconfig
    it reads [libs] instead of [lib] for me
    I'll ammend it
    Jose Garcia
    @josebalius
    Hmm it should be [libs]
    Charlie Dowler
    @charliedowler
    I'm getting Fatal error: exception Failure(".flowconfig:5 Unsupported config section: libs")
    when I run lint
    Jose Garcia
    @josebalius
    You probably don't have the latest flow
    Reinstall flowBin
    Charlie Dowler
    @charliedowler
    just did a brew install flow
    I think I need to restart terminal
    Charlie Dowler
    @charliedowler
    My squash screwed it up, looking into it
    if you pull down master and run it, does it work?
    Dw, it was flowBin @josebalius the squash is safe
    Jose Garcia
    @josebalius
    Cool, yeah it seems every time we need the latest flow we gotta reinstall flowBin