checkstyle/checkstyle

Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.

Roman Ivanov

@romani

====

Roman Ivanov

@romani

code freeze for 8.17 release

Roman Ivanov

@romani

release 8.17 is done - https://checkstyle.org/releasenotes.html#Release_8.17

Sheng Chen

@jdneo

Hi team, I have a question about the Eclipse Checkstyle plugin. The plugin use ASTVisitor to modify the AST, thus correct the Checkstyle violations. Is it possible to extract these visitors into a separate jar files for distribution? I'm trying to implement a Checkstyle extension in VS Code and I wish I can use these components as part of the dependencies instead of copying the code.

Sheng Chen

@jdneo

Above is the gif of the POC I have implemented for now

rnveach

@rnveach

@jdneo ASTVisitor is not a creation of checkstyle or eclipse-cs. It is made by eclipse and in their jars. You would have to find those and extract them to use them.

Sheng Chen

@jdneo

Thank you @rnveach. Are those quickfixers also made by Eclipse? I mean, for example, https://github.com/checkstyle/eclipse-cs/blob/master/net.sf.eclipsecs.ui/src/net/sf/eclipsecs/ui/quickfixes/modifier/ModifierOrderQuickfix.java.

rnveach

@rnveach

@jdneo Just look at imports and class hierarchy. AbstractASTResolution is eclipse-cs, but it extends WorkbenchMarkerResolution which is eclipse's

Sheng Chen

@jdneo

Okay, maybe I haven't explained my problem clearly. I found that the ASTVisitor return by the method handleGetCorrectingASTVisitor() is very useful. Currently, if I want to implement the same logic, I need to copy the code from handleGetCorrectingASTVisitor(). It would be great if these components could be shared.

rnveach

@rnveach

I'm not seeing what your saying. If you want to use the code, you can include eclipse-cs' JARs and eclipse's JARs and instantiate ASTVisitor and use it as you wish.

vermasoft.com

@ashish2583

i am understanding that what i am doing because i am a new user so i do any thing whos i seen

rnveach

@rnveach

@ashish2583 If you are new to checkstyle and want to contribute, please look at.
http://checkstyle.sourceforge.net/beginning_development.html
http://checkstyle.sourceforge.net/contributing.html

Akshit Ostwal

@AkshitOstwal

Hi all I am Akshit Ostwal !!!!

I am new to open source community , i would love to start my journey from this community .

I am also willing to take part in GSoC 2019 as well .

I know JAVA ,C ,C++ , MySQL and right now learning python as well .

How can i contribute to this community ?? Please Guide me!!!!!

THANKS IN ADVANCE !!!!!

rnveach

@rnveach

@AkshitOstwal I recommend looking over http://checkstyle.sourceforge.net/beginning_development.html, setting up your IDE, and do a test build of the project and ensure you have no problems.

When you are ready, we can point you to an issue you can work on.

Roman Ivanov

@romani

======

code freeze till I finish 8.18 release

====

Roman Ivanov

@romani

https://checkstyle.org/releasenotes.html#Release_8.18 - done

thanks a lot to all contributors!!

====

Roman Ivanov

@romani

code freeze ..... till end of release process for 8.19

Roman Ivanov

@romani

Release is technically done

But there are CI problems

cannot initialize module TreeWalker - Property 'cacheFile' does not exist, please check the documentation -

We need to resolve this before public announcement of release

Roman Ivanov

@romani

all CI issues are resolved.

release is done, public notification were sent.

Roman Ivanov

@romani

====

code freeze for 8.20 release

Roman Ivanov

@romani

release is done, thanks to all for contributions

Roman Ivanov

@romani

====

I requested werker to review issue with badge https://werckerpublic.slack.com/archives/C0B8P1XJ5/p1558531595017000

Roman Ivanov

@romani

request to Teamcity to resolve build issues - https://teamcity-support.jetbrains.com/hc/en-us/requests/2112906

Roman Ivanov

@romani

=======

code freeze till release is done

Roman Ivanov

@romani

release 8.22 is done, all CIs are green

===

Eugenio Romano

@eromano

Hi guys I have a problem in using checkstyle with a project wit multiple modules

When I run the command with checkstyle:check everything is OK and it scan the module I asked but when it runs during the phase mvn install it says a message: If you use inline configuration for rules, don't specify a configLocation

<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <executions>
          <execution>
            <id>validate</id>
            <phase>validate</phase>
            <goals>
              <goal>check</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <sourceDirectories>
            <sourceDirectory>activiti-api-impl</sourceDirectory>
          </sourceDirectories>
          <configLocation>./checkstyle.xml</configLocation>
          <encoding>UTF-8</encoding>
          <consoleOutput>true</consoleOutput>
          <failsOnError>true</failsOnError>
          <linkXRef>false</linkXRef>
        </configuration>
      </plugin>

    </plugins>
  </build>

  <reporting>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <configuration>
          <configLocation>./checkstyle.xml</configLocation>
        </configuration>
      </plugin>
    </plugins>
  </reporting>

this is the conf I use and for what I got executions configured as I did should not even run checkstyle during install

Roman Ivanov

@romani

we need more details, and all versions, please create mail thread in our mail group

Eugenio Romano

@eromano

ok thanks I will do it

Roman Ivanov

@romani

https://groups.google.com/forum/#!forum/checkstyle

and please share all possible details

Eugenio Romano

@eromano

I will link the PR with the cahnge in the project so it's clear is an open source project

Roman Ivanov

@romani

and output of mvn -X ...

Eugenio Romano

@eromano

sure no problem

Where communities thrive

People

Repo info

Activity

Hi all I am Akshit Ostwal !!!!

THANKS IN ADVANCE !!!!!