Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 19 09:23

    pbludov on master

    dependency: bump equalsverifier… Issue #7509: resolve 'Duplicate… Issue #7512: mark DetailAST::ge… and 27 more (compare)

  • Jan 28 20:43

    pbludov on issue-7512-get-number-of-children

    (compare)

  • Jan 28 19:05

    pbludov on issue-7512-get-number-of-children

    dependency: bump equalsverifier… Issue #7512: mark DetailAST::ge… (compare)

  • Jan 28 12:55

    pbludov on issue-7512-get-number-of-children

    Issue #7512: mark DetailAST::ge… (compare)

  • Jan 28 08:19

    pbludov on master

    dependency: bump junit-pioneer … Issue #3238: Java 8 Grammar: an… Issue #7487: add method hasChil… and 8 more (compare)

  • Jan 26 14:28

    pbludov on issue-7487-has-children

    (compare)

  • Jan 25 13:52

    pbludov on issue-7487-has-children

    Issue #7487: refactor code to u… (compare)

  • Jan 25 13:52

    pbludov on issue-7487-has-children

    Issue #7487: refactor code to u… (compare)

  • Jan 25 09:30

    pbludov on issue-7487-has-children

    Issue #7487: refactor code to u… (compare)

  • Jan 25 08:20

    pbludov on issue-7487-has-children

    dependency: bump junit-pioneer … Issue #3238: Java 8 Grammar: an… Issue #7487: add method hasChil… and 1 more (compare)

  • Jan 21 18:58

    pbludov on master

    (compare)

  • Jan 21 18:16

    pbludov on master

    Issue #7468: disable 'external-… minor: add space before xml com… dependency: bump junit.version … and 1 more (compare)

  • Jan 20 21:45

    pbludov on issue-7487-has-children

    Issue #7475: resolve Cognitive … doc: extend Indentation Check e… dependency: bump antlr4.version… and 3 more (compare)

  • Jan 18 12:40

    pbludov on master

    Issue #7492: enforce jdk 1.8 by… Issue #7472: disable instatiati… minor: add missing test case to… (compare)

  • Jan 18 11:00

    pbludov on master

    minor: add missing test case to… (compare)

  • Jan 18 10:37

    pbludov on master

    misc: add missing test case to … (compare)

  • Jan 18 10:29

    pbludov on master

    minor: fix headers in various f… minor: remove unnecessary optio… config: add .ci/bump-license-ye… and 11 more (compare)

  • Jan 17 19:41

    pbludov on issue-7487-has-children

    dependency: bump junit-pioneer … Issue #5604: activation of sona… Issue #6972: NoEnumTrailingComm… and 25 more (compare)

  • Jan 17 19:26

    pbludov on issue-7487-has-children

    Issue #7487: add method hasChil… Issue #7487: refactor code to u… (compare)

  • Jan 17 19:18

    pbludov on issue-7487-has-children

    Issue #7487: refactor code to u… (compare)

Roman Ivanov
@romani
We need to resolve this before public announcement of release
Roman Ivanov
@romani
all CI issues are resolved.
release is done, public notification were sent.
Roman Ivanov
@romani
====
code freeze for 8.20 release
Roman Ivanov
@romani
release is done, thanks to all for contributions
Roman Ivanov
@romani
====
I requested werker to review issue with badge https://werckerpublic.slack.com/archives/C0B8P1XJ5/p1558531595017000
Roman Ivanov
@romani
request to Teamcity to resolve build issues - https://teamcity-support.jetbrains.com/hc/en-us/requests/2112906
Roman Ivanov
@romani
=======
code freeze till release is done
Roman Ivanov
@romani
release 8.22 is done, all CIs are green
===
Eugenio Romano
@eromano
Hi guys I have a problem in using checkstyle with a project wit multiple modules
When I run the command with checkstyle:check everything is OK and it scan the module I asked but when it runs during the phase mvn install it says a message: If you use inline configuration for rules, don't specify a configLocation
<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <executions>
          <execution>
            <id>validate</id>
            <phase>validate</phase>
            <goals>
              <goal>check</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <sourceDirectories>
            <sourceDirectory>activiti-api-impl</sourceDirectory>
          </sourceDirectories>
          <configLocation>./checkstyle.xml</configLocation>
          <encoding>UTF-8</encoding>
          <consoleOutput>true</consoleOutput>
          <failsOnError>true</failsOnError>
          <linkXRef>false</linkXRef>
        </configuration>
      </plugin>

    </plugins>
  </build>

  <reporting>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <configuration>
          <configLocation>./checkstyle.xml</configLocation>
        </configuration>
      </plugin>
    </plugins>
  </reporting>
this is the conf I use and for what I got executions configured as I did should not even run checkstyle during install
Roman Ivanov
@romani
we need more details, and all versions, please create mail thread in our mail group
Eugenio Romano
@eromano
ok thanks I will do it
and please share all possible details
Eugenio Romano
@eromano
I will link the PR with the cahnge in the project so it's clear is an open source project
Roman Ivanov
@romani
and output of mvn -X ...
Eugenio Romano
@eromano
sure no problem
thanks
Eugenio Romano
@eromano
matrixbot
@matrixbot
BuZZ-dEE hi is possible to convert an old checkstyle configuration / xml file to a new version if for example there breaking changes from the old one to the new one?
Roman Ivanov
@romani
I do know such tool
I do not know such tool
Roman Ivanov
@romani
We try to be accurate and clearly define bracking changes and provide migration notes in issues
From what version you are upgrading ?
Roman Ivanov
@romani
======
code freeze till I finish release 8.24
Roman Ivanov
@romani
Done
Mincong Huang
@mincong-h
Thank you @romani :raised_hands:
Mincong Huang
@mincong-h

Hi everyone, I would like to know if there is a check in Checkstyle which verifies the correctness of placeholders in String.formator any similar formatting method?

Here are 3 examples:

jshell> String.format("Hello, %s", "Checkstyle");
$1 ==> "Hello, Checkstyle"

jshell> String.format("Hello, %s", "check", "style");
$1 ==> "Hello, check"

jshell> String.format("Hello, %s");
|  Exception java.util.MissingFormatArgumentException: Format specifier 'Exception in thread "main" java.util.MissingFormatArgumentException: Format specifier '%s'
    at java.base/java.util.Formatter.format(Formatter.java:2672)
    at java.base/java.io.PrintStream.format(PrintStream.java:1053)
    at java.base/java.io.PrintStream.printf(PrintStream.java:949)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.error(JShellTool.java:728)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.errormsg(JShellTool.java:867)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayEvalException(JShellTool.java:3451)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayException(JShellTool.java:3425)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayException(JShellTool.java:3418)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.handleEvent(JShellTool.java:3582)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSource(JShellTool.java:3550)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSourceCatchingReset(JShellTool.java:1301)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processInput(JShellTool.java:1203)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.run(JShellTool.java:1176)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.start(JShellTool.java:975)
    at jdk.jshell/jdk.internal.jshell.tool.JShellToolBuilder.start(JShellToolBuilder.java:254)
    at jdk.jshell/jdk.internal.jshell.tool.JShellToolProvider.main(JShellToolProvider.java:120)
Roman Ivanov
@romani
there is no such Check
Mincong Huang
@mincong-h
Thank you, Roman.
sreejith-sjrs
@sreejith-sjrs
Hello All,
Newbie here, so please go easy on me. I have some binary source files which I do not want to fingerprint. Obviously UTF-8 encoding is not correct. I was wondering if there was a way to avoid such error messages.
[CheckStyle] [-ERROR-] Can't create fingerprints for some files:
[CheckStyle] [-ERROR-] - 'C:/Jenkins/workspace/example_master/Add.vi', provided encoding 'UTF-8' seems to be wrong
My analysis step in my pipeline looks like this:
recordIssues(
enabledForFailure: true, forensicsDisabled: true, unstableTotalAll: 1, healthy: 1, unhealthy: 10,
tools: [checkStyle(pattern: 'build_temp\VIA_results.xml', reportEncoding: 'UTF-8')]
Please help.
Thanks in advance.
rnveach
@rnveach
Unfortunately that error is not coming from main Checkstyle jar, so I don't know how to help you. You would have to look more into jenkins
sreejith-sjrs
@sreejith-sjrs
OK. Thanks very much for getting back to me. I will try to reach out Jenkins folks
Roman Ivanov
@romani
Roman Ivanov
@romani
code freeze till release 8.26 completed
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.26 - done, thanks a lot to all contributors
Chethan Prakash
@chethan
Hi, Is there any easy way to add custom checkstyle rules, to fail build for using specific classes
Roman Ivanov
@romani
While checkstyle/checkstyle#6481 is not done, no very easy way, but you are welcome to contribute such implementation