by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jun 21 08:37

    pbludov on issue-8325-wercker-jdk11

    (compare)

  • Jun 19 08:52

    pbludov on issue-8325-wercker-jdk11

    minor: fix TC violations dependency: bump ant from 1.10.… Issue #7671: Update doc for NoF… and 61 more (compare)

  • Jun 02 08:39

    pbludov on issue-8283-fix-import-tests

    (compare)

  • May 31 14:54

    pbludov on issue-8283-fix-import-tests

    Issue #8283: Make test inputs c… (compare)

  • May 31 13:30

    pbludov on issue-8283-fix-import-tests

    Issue #8283: set java.version t… (compare)

  • May 31 13:21

    pbludov on issue-8283-fix-import-tests

    Issue #8283: Make import test i… Issue #8283: ignore methods dep… Issue #8283: set java.version t… (compare)

  • May 31 12:59

    pbludov on issue-8283-fix-import-tests

    minor: fix TC violations dependency: bump ant from 1.10.… Issue #7671: Update doc for NoF… and 37 more (compare)

  • May 30 13:36

    pbludov on issue-8275-spotbugs-tests

    (compare)

  • May 30 11:19

    pbludov on issue-8275-spotbugs-tests

    Issue #8262: ignore jacoco inte… Issue #8275: verify tests with … (compare)

  • May 30 10:39

    pbludov on issue-8262-spotbugs-jacoco

    (compare)

  • May 30 10:25

    pbludov on issue-8275-spotbugs-tests

    Issue #7892: Add validation for… minor: fix bad line break Issue #7690: ClassDataAbstracti… and 9 more (compare)

  • May 29 16:49

    pbludov on issue-4937-drop-cdata

    (compare)

  • May 28 08:00

    pbludov on issue-8262-spotbugs-jacoco

    Issue #8262: ignore jacoco inte… (compare)

  • May 28 07:58

    pbludov on issue-8262-spotbugs-jacoco

    Issue #7980: Resolve Pitest Iss… Issue #8228: Update CIs to vali… Issue #8228: Clean up after Tra… and 8 more (compare)

  • May 19 07:08

    pbludov on issue-4937-drop-cdata

    Issue #7921: Resolve Pitest Iss… Issue #3786: enable JOSM in Tra… Issue #4937: Drop CDATA support… (compare)

  • May 17 09:54

    pbludov on issue-4937-drop-cdata

    Issue #7728: Update AbstractChe… Issue #7873: Resolve Pitest Iss… Issue #7804: Resolve Pitest Iss… and 1 more (compare)

  • May 16 08:20

    pbludov on issue-4937-drop-cdata

    Issue #4937: Drop CDATA support… (compare)

  • May 16 08:19

    pbludov on issue-4937-drop-cdata

    minor: fix TC violations dependency: bump ant from 1.10.… Issue #7671: Update doc for NoF… and 3 more (compare)

  • May 11 05:15

    pbludov on master

    doc: update link to moved javad… Issue #6332: Java9 try with res… Issue #8036: Update test inputs… and 2 more (compare)

  • May 03 08:19

    pbludov on master

    Issue #7833: Create code of con… Issue #3201: Allow to configure… dependency: bump forbiddenapis … and 22 more (compare)

Roman Ivanov
@romani
release is done, thanks to all for contributions
Roman Ivanov
@romani
====
I requested werker to review issue with badge https://werckerpublic.slack.com/archives/C0B8P1XJ5/p1558531595017000
Roman Ivanov
@romani
request to Teamcity to resolve build issues - https://teamcity-support.jetbrains.com/hc/en-us/requests/2112906
Roman Ivanov
@romani
=======
code freeze till release is done
Roman Ivanov
@romani
release 8.22 is done, all CIs are green
===
Eugenio Romano
@eromano
Hi guys I have a problem in using checkstyle with a project wit multiple modules
When I run the command with checkstyle:check everything is OK and it scan the module I asked but when it runs during the phase mvn install it says a message: If you use inline configuration for rules, don't specify a configLocation
<plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <executions>
          <execution>
            <id>validate</id>
            <phase>validate</phase>
            <goals>
              <goal>check</goal>
            </goals>
          </execution>
        </executions>
        <configuration>
          <sourceDirectories>
            <sourceDirectory>activiti-api-impl</sourceDirectory>
          </sourceDirectories>
          <configLocation>./checkstyle.xml</configLocation>
          <encoding>UTF-8</encoding>
          <consoleOutput>true</consoleOutput>
          <failsOnError>true</failsOnError>
          <linkXRef>false</linkXRef>
        </configuration>
      </plugin>

    </plugins>
  </build>

  <reporting>
    <plugins>
      <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-checkstyle-plugin</artifactId>
        <version>${checkstyle-maven-plugin.version}</version>
        <configuration>
          <configLocation>./checkstyle.xml</configLocation>
        </configuration>
      </plugin>
    </plugins>
  </reporting>
this is the conf I use and for what I got executions configured as I did should not even run checkstyle during install
Roman Ivanov
@romani
we need more details, and all versions, please create mail thread in our mail group
Eugenio Romano
@eromano
ok thanks I will do it
and please share all possible details
Eugenio Romano
@eromano
I will link the PR with the cahnge in the project so it's clear is an open source project
Roman Ivanov
@romani
and output of mvn -X ...
Eugenio Romano
@eromano
sure no problem
thanks
Eugenio Romano
@eromano
matrixbot
@matrixbot
BuZZ-dEE hi is possible to convert an old checkstyle configuration / xml file to a new version if for example there breaking changes from the old one to the new one?
Roman Ivanov
@romani
I do know such tool
I do not know such tool
Roman Ivanov
@romani
We try to be accurate and clearly define bracking changes and provide migration notes in issues
From what version you are upgrading ?
Roman Ivanov
@romani
======
code freeze till I finish release 8.24
Roman Ivanov
@romani
Done
Mincong Huang
@mincong-h
Thank you @romani :raised_hands:
Mincong Huang
@mincong-h

Hi everyone, I would like to know if there is a check in Checkstyle which verifies the correctness of placeholders in String.formator any similar formatting method?

Here are 3 examples:

jshell> String.format("Hello, %s", "Checkstyle");
$1 ==> "Hello, Checkstyle"

jshell> String.format("Hello, %s", "check", "style");
$1 ==> "Hello, check"

jshell> String.format("Hello, %s");
|  Exception java.util.MissingFormatArgumentException: Format specifier 'Exception in thread "main" java.util.MissingFormatArgumentException: Format specifier '%s'
    at java.base/java.util.Formatter.format(Formatter.java:2672)
    at java.base/java.io.PrintStream.format(PrintStream.java:1053)
    at java.base/java.io.PrintStream.printf(PrintStream.java:949)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.error(JShellTool.java:728)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.errormsg(JShellTool.java:867)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayEvalException(JShellTool.java:3451)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayException(JShellTool.java:3425)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.displayException(JShellTool.java:3418)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.handleEvent(JShellTool.java:3582)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSource(JShellTool.java:3550)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processSourceCatchingReset(JShellTool.java:1301)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.processInput(JShellTool.java:1203)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.run(JShellTool.java:1176)
    at jdk.jshell/jdk.internal.jshell.tool.JShellTool.start(JShellTool.java:975)
    at jdk.jshell/jdk.internal.jshell.tool.JShellToolBuilder.start(JShellToolBuilder.java:254)
    at jdk.jshell/jdk.internal.jshell.tool.JShellToolProvider.main(JShellToolProvider.java:120)
Roman Ivanov
@romani
there is no such Check
Mincong Huang
@mincong-h
Thank you, Roman.
sreejith-sjrs
@sreejith-sjrs
Hello All,
Newbie here, so please go easy on me. I have some binary source files which I do not want to fingerprint. Obviously UTF-8 encoding is not correct. I was wondering if there was a way to avoid such error messages.
[CheckStyle] [-ERROR-] Can't create fingerprints for some files:
[CheckStyle] [-ERROR-] - 'C:/Jenkins/workspace/example_master/Add.vi', provided encoding 'UTF-8' seems to be wrong
My analysis step in my pipeline looks like this:
recordIssues(
enabledForFailure: true, forensicsDisabled: true, unstableTotalAll: 1, healthy: 1, unhealthy: 10,
tools: [checkStyle(pattern: 'build_temp\VIA_results.xml', reportEncoding: 'UTF-8')]
Please help.
Thanks in advance.
rnveach
@rnveach
Unfortunately that error is not coming from main Checkstyle jar, so I don't know how to help you. You would have to look more into jenkins
sreejith-sjrs
@sreejith-sjrs
OK. Thanks very much for getting back to me. I will try to reach out Jenkins folks
Roman Ivanov
@romani
Roman Ivanov
@romani
code freeze till release 8.26 completed
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.26 - done, thanks a lot to all contributors
Chethan Prakash
@chethan
Hi, Is there any easy way to add custom checkstyle rules, to fail build for using specific classes
Roman Ivanov
@romani
While checkstyle/checkstyle#6481 is not done, no very easy way, but you are welcome to contribute such implementation
Pavel Bludov
@pbludov
Pitest is broken because I messed up the System.err and System.out when migrating to Junit5. Soon there will be a PR with a fix.
rnveach
@rnveach
happy holidays
Roman Ivanov
@romani
Merry Christmas !
Suchet-Agg
@Suchet-Agg
Hi, I am Suchet Aggarwal and am new to this organization and would like to contribute to this organization, can someone help me get started...
rnveach
@rnveach
@Suchet-Agg Read over https://checkstyle.org/beginning_development.html . You can pick any issue from our repository of things needing fixing. If you want us to assign you an issue we think will be good for beginners, let us know. You just need to say "I am on it" in the issue you are working on to let others know.