Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Feb 23 21:43

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • Feb 23 21:34

    pbludov on maven

    (compare)

  • Feb 23 21:31

    pbludov on issue-9146-java11

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 9 more (compare)

  • Feb 23 21:24

    pbludov on issue-9310-java11-inputs

    (compare)

  • Feb 23 08:28

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 07:03

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 06:52

    pbludov on issue-9310-java11-inputs

    Issue #9152: Record implementin… infra: add checkout_from suppor… dependency: bump archunit-junit… and 3 more (compare)

  • Feb 21 19:48

    pbludov on issue-9310-java11-inputs

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 1 more (compare)

  • Feb 21 19:40

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 15:01

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 14:47

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 09:54

    pbludov on issue-9310-java11-inputs

    #Issue #9310: test inputs shoul… (compare)

  • Feb 20 07:41

    pbludov on master

    doc: fix checkstyle jar version… Issue #9297: solve spotbugs vio… (compare)

  • Feb 19 16:00

    pbludov on issue-9297-spotbugs-11

    (compare)

  • Feb 18 08:23

    pbludov on issue-9146-java11

    Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… Issue #9146: switch to jdk 11 i… and 1 more (compare)

  • Feb 18 07:29

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… (compare)

  • Feb 18 07:20

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… (compare)

  • Feb 18 07:13

    pbludov on issue-9146-java11

    Issue #9146: upgrade minimal re… Issue #9146: switch to jdk 11 i… (compare)

  • Feb 18 06:49

    pbludov on issue-9297-spotbugs-11

    Pull #9298: change job to check… Issue #9297: solve spotbugs vio… (compare)

  • Feb 17 20:42

    pbludov on issue-9297-spotbugs-11

    minor: remove pitest suppressio… Issue #9292: disable markdownli… minor: Fix github issue templat… and 1 more (compare)

Roman Ivanov
@romani
@developerhb , you need to investigate why command mvn -e --batch-mode site -Dcheckstyle.config.location=google_checks.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false (you can find it in your logs) are failing with OOM. Please google about it, there are few maven evn variables to extend memory used by maven, you probably have very low default
developerhb
@developerhb
@romani The query of OOM was by @shashwat70 and not by me
Shashwat Jaiswal
@shashwatj07
@romani yes I'll check. Thank You sir.
Shrey Kumar Singh
@sulkykookie
Hi, my PR was approved but it didn't get any updates. Can someone please look into it? checkstyle/checkstyle#8044
Roman Ivanov
@romani
Whoever is blocked by missed review, please take another issue and fix it and send new PR
developerhb
@developerhb
@romani @rnveach Please have a look at my questions in the comments section of issue #7728
developerhb
@developerhb
@romani @rnveach @timurt I have a new question in the comments section of issue #7728. Please help.
Demezhan Marikov
@ImmortalRabbit
Gaurab Dasgupta
@gaurabdg
@ImmortalRabbit What exactly are you referring to ?#7925 is taken by me.
Demezhan Marikov
@ImmortalRabbit
@gaurabdg sorry, I think that was typo. Thanks for correcting me.
@romani @rnveach Please review: checkstyle/checkstyle#8054
Gaurab Dasgupta
@gaurabdg
@ImmortalRabbit No problem
Roman Ivanov
@romani
I apologise that we are slow, this year is unfortunate
Demezhan Marikov
@ImmortalRabbit
Shashwat Jaiswal
@shashwatj07
please review checkstyle/checkstyle#8069 checkstyle/checkstyle#8070 @romani @rnveach @strkkk
Shrey Kumar Singh
@sulkykookie
Is there any reason because of which PRs are not getting merged lately?
Roman Ivanov
@romani
Simple reason: mentors are over busy. But we will do review
We understand that it is our fault. Please keep sending PRs.
Shrey Kumar Singh
@sulkykookie
It's totally understandable :) Thanks
Shashwat Jaiswal
@shashwatj07
please reply to my concern here checkstyle/checkstyle#8019
Shashwat Jaiswal
@shashwatj07
Wilfried L. Bounsi
@wilcoln
Hi everyone
I need to run pitest on utility classes (package com.puppycrawl.tools.checkstyle.utils), which profile should I use? Thanks.
Wilfried L. Bounsi
@wilcoln
I'm not even sure that's what I need to do to solve my problem, let me just expose it here.
So, I've created a new utility class which I've placed in com.puppycrawl.tools.checkstyle.utils
This utility class is used in some check in com.puppycrawl.tools.checkstyle.checks.coding
Now, when I run pitest locally with coding profile, i.e .ci/pitest.sh pitest-coding no issue is reported, mvn verify is ok too.
But, checkstyle/checkstyle#8049 is failing pitest3 CI checking and I have no idea of what needs to be done.
Any suggestion is welcome
Shrey Kumar Singh
@sulkykookie
try running .ci/pitest.sh pitest-utils, that's where it throws error in the CI checking
Wilfried L. Bounsi
@wilcoln
oh, you're right, I didn't notice that pitest-utils profile inside the pitest.sh file.
Thanks man!
rnveach
@rnveach
Every production package/class in checkstyle should be running against pitest. We specifically added a test to ensure we have all the classes covered.
Kaustubh Dixit
@DXTkastb
I want to run TeamCity build locally, I have downloaded the plugin but I couldn't understand the procedure. @romani could you please help me in figuring out how to run this.
Roman Ivanov
@romani
@DXTkastb , teamcity do only this -https://checkstyle.org/idea.html#Inspections
you do not need any plugin to be installed, free version of IDEA support inspections execution.
Kaustubh Dixit
@DXTkastb
@romani thanks.
Demezhan Marikov
@ImmortalRabbit

Hi everyone, I have done an issue, and I had to resolve suggestion, then I did it but travis-ci is not passing all tests because my branch is 19 commits old and it requires to be at most 10 commits old. If I will rebase my branch my pull request will have additional 19 commits. What should I do? Before, I just closed pull requests and opened a new one with a new branch. Is there any other better solution?

@romani @rnveach

Tan Wei Liang
@wltan
@ImmortalRabbit If you rebase (not pull/merge) the PR branch on the latest master correctly and force push, the PR should have only the 1 extra commit that you are making. Maybe you can elaborate a bit on what exactly you are running to rebase the branch?
I usually run something long the lines of
git checkout master
git pull upstream master
git checkout <the-PR-branch>
git rebase master
git push --force
Shrey Kumar Singh
@sulkykookie
@ImmortalRabbit Hi, once you rebase to upstream, your branch wont consist of those additional commits. It will simply put your commit on top of the additional commits.
Demezhan Marikov
@ImmortalRabbit
git checkout master
git pull upstream master
git checkout <the-PR-branch>
git rebase master
git push --force
So this commands should help me? Am I right?
Shrey Kumar Singh
@sulkykookie
Use git fetch upstream, git rebase upstream/master, git push origin <patch branch> -f. Here upstream is the checkstyle's original repo
that's how ive been doing it ^
Demezhan Marikov
@ImmortalRabbit
okay, thanks @sulkykookie @wltan
Roman Ivanov
@romani
------- all above got answers -----
Roman Ivanov
@romani
All students, please rebase your branch on latest code, and please recheck that there is no conflicts in your PRs
Abhishek Kumar
@Abhishek-kumar09
@romani @rnveach @strkkk Please review PR checkstyle/checkstyle#8038, as all the other Indentation PR are dependent on it for their regression test.
Kaustubh Dixit
@DXTkastb
@romani some of the PRs are failing Travis CI, and all of them having the same problem: https://travis-ci.org/github/checkstyle/checkstyle/jobs/675875326
rnveach
@rnveach
@DXTkastb We are aware. A PR reported a false green light and was merged before being caught.
If the next PR I send doesn't fix it, I will revert the bad commit. checkstyle/checkstyle#8116
rnveach
@rnveach
I pushed the revert. The fix still needs 1 more thing.
developerhb
@developerhb
@romani @rnveach I rebased the PR checkstyle/checkstyle#7953 and the Travis CI failed. Before it passed and I have not made any changes. Please help.
rnveach
@rnveach
@developerhb I just pushed a fix a few minutes ago, you need to rebase on top of that.