checkstyle/checkstyle

Checkstyle is a development tool to help programmers write Java code that adheres to a coding standard. By default it supports the Google Java Style Guide and Sun Code Conventions, but is highly configurable. It can be invoked with an ANT task and a command line program.

Wilfried L. Bounsi

@wilcoln

I need to run pitest on utility classes (package com.puppycrawl.tools.checkstyle.utils), which profile should I use? Thanks.

Wilfried L. Bounsi

@wilcoln

I'm not even sure that's what I need to do to solve my problem, let me just expose it here.
So, I've created a new utility class which I've placed in com.puppycrawl.tools.checkstyle.utils
This utility class is used in some check in com.puppycrawl.tools.checkstyle.checks.coding
Now, when I run pitest locally with coding profile, i.e .ci/pitest.sh pitest-coding no issue is reported, mvn verify is ok too.
But, checkstyle/checkstyle#8049 is failing pitest3 CI checking and I have no idea of what needs to be done.

Any suggestion is welcome

Shrey Kumar Singh

@sulkykookie

try running .ci/pitest.sh pitest-utils, that's where it throws error in the CI checking

Wilfried L. Bounsi

@wilcoln

oh, you're right, I didn't notice that pitest-utils profile inside the pitest.sh file.
Thanks man!

rnveach

@rnveach

Every production package/class in checkstyle should be running against pitest. We specifically added a test to ensure we have all the classes covered.

Kaustubh Dixit

@DXTkastb

I want to run TeamCity build locally, I have downloaded the plugin but I couldn't understand the procedure. @romani could you please help me in figuring out how to run this.

Roman Ivanov

@romani

@DXTkastb , teamcity do only this -https://checkstyle.org/idea.html#Inspections

you do not need any plugin to be installed, free version of IDEA support inspections execution.

Kaustubh Dixit

@DXTkastb

@romani thanks.

Demezhan Marikov

@ImmortalRabbit

Hi everyone, I have done an issue, and I had to resolve suggestion, then I did it but travis-ci is not passing all tests because my branch is 19 commits old and it requires to be at most 10 commits old. If I will rebase my branch my pull request will have additional 19 commits. What should I do? Before, I just closed pull requests and opened a new one with a new branch. Is there any other better solution?

@romani @rnveach

Tan Wei Liang

@wltan

@ImmortalRabbit If you rebase (not pull/merge) the PR branch on the latest master correctly and force push, the PR should have only the 1 extra commit that you are making. Maybe you can elaborate a bit on what exactly you are running to rebase the branch?

I usually run something long the lines of

git checkout master
git pull upstream master
git checkout <the-PR-branch>
git rebase master
git push --force

Shrey Kumar Singh

@sulkykookie

@ImmortalRabbit Hi, once you rebase to upstream, your branch wont consist of those additional commits. It will simply put your commit on top of the additional commits.

Demezhan Marikov

@ImmortalRabbit

git checkout master
git pull upstream master
git checkout <the-PR-branch>
git rebase master
git push --force

So this commands should help me? Am I right?

Shrey Kumar Singh

@sulkykookie

Use git fetch upstream, git rebase upstream/master, git push origin <patch branch> -f. Here upstream is the checkstyle's original repo

that's how ive been doing it ^

Demezhan Marikov

@ImmortalRabbit

okay, thanks @sulkykookie @wltan

Roman Ivanov

@romani

------- all above got answers -----

Roman Ivanov

@romani

All students, please rebase your branch on latest code, and please recheck that there is no conflicts in your PRs

Abhishek Kumar

@Abhishek-kumar09

@romani @rnveach @strkkk Please review PR checkstyle/checkstyle#8038, as all the other Indentation PR are dependent on it for their regression test.

Kaustubh Dixit

@DXTkastb

@romani some of the PRs are failing Travis CI, and all of them having the same problem: https://travis-ci.org/github/checkstyle/checkstyle/jobs/675875326

rnveach

@rnveach

@DXTkastb We are aware. A PR reported a false green light and was merged before being caught.

If the next PR I send doesn't fix it, I will revert the bad commit. checkstyle/checkstyle#8116

rnveach

@rnveach

I pushed the revert. The fix still needs 1 more thing.

developerhb

@developerhb

@romani @rnveach I rebased the PR checkstyle/checkstyle#7953 and the Travis CI failed. Before it passed and I have not made any changes. Please help.

rnveach

@rnveach

@developerhb I just pushed a fix a few minutes ago, you need to rebase on top of that.

developerhb

@developerhb

@rnveach okay I will do that. Thank you.

Gaurav Punjabi

@Gaurav-Punjabi

@romani Please reply to my queries here
checkstyle/checkstyle#8110
checkstyle/checkstyle#5890

Demezhan Marikov

@ImmortalRabbit

If my branch has 2 commits before first review, is there any way how I can reduce it to 1 commit without creating new branch with a new pull request?

rnveach

@rnveach

@ImmortalRabbit squash the commits into 1. PR guidelines provides an example command.

Demezhan Marikov

@ImmortalRabbit

@rnveach thanks

Demezhan Marikov

@ImmortalRabbit

@rnveach @romani What kind of example can be provided for this

<module name="LeftCurly">
  <property name="ignoreEnums" value="false"/>
</module>

Issue: checkstyle/checkstyle#7582
Link to documentation: https://checkstyle.org/config_blocks.html#LeftCurly

Shashwat Jaiswal

@shashwatj07

checkstyle/checkstyle#8058 checkstyle/checkstyle#8071 checkstyle/checkstyle#8100

please review

developerhb

@developerhb

@romani @rnveach I have rebased the PR checkstyle/checkstyle#7953 and all checks have passed. Please review.

Demezhan Marikov

@ImmortalRabbit

@rnveach @romani What could cause this errors? Is someone else having same issue? All my pull request is taking to much time to complete travis-ci tests and failing for 403, 501 reasons. Branches are up to date. I have just checked.

Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not transfer artifact org.junit.platform:junit-platform-commons:jar:1.6.2 from/to central (https://repo.maven.apache.org/maven2): Authorization failed for https://repo.maven.apache.org/maven2/org/junit/platform/junit-platform-commons/1.6.2/junit-platform-commons-1.6.2.jar 403 Forbidden

Gaurav Punjabi

@Gaurav-Punjabi

As the mentors are busy in this period, should I wait for my PR to get merged or should I keep solving issues?

Kaustubh Dixit

@DXTkastb

solving issues is better I guess :)

Demezhan Marikov

@ImmortalRabbit

@Gaurav-Punjabi

Gaurav Punjabi

@Gaurav-Punjabi

Got it, thanks 👍🏻

Gaurab Dasgupta

@gaurabdg

@rnveach Can you please look into PR #8008?

Roman Ivanov

@romani

@ImmortalRabbit , please ask question in PR, looks like no reason of such example config, you can skip it for now

developerhb

@developerhb

@romani @rnveach can you please guide me for writing XpathQuery in the Test after updating the check to log DetailAST. I am working on issue #7728.

Roman Ivanov

@romani

@developerhb , please take a look at other PRs like this, there bunch of examples

Demezhan Marikov

@ImmortalRabbit

@romani @rnveach Could you check my questions for this issue? checkstyle/checkstyle#952

Tan Wei Liang

@wltan

just for everyone's info, CI is taking a while to pass due to a backlog of jobs on appveyor: https://ci.appveyor.com/project/Checkstyle/checkstyle/history

Abhishek Kumar

@Abhishek-kumar09

Please review: https://github.com/checkstyle/checkstyle/issues?q=author%3Aabhishek-kumar09+is%3Aopen

rnveach

@rnveach

@wltan I tried turning on killing duplicate builds for appveyor. Hopefully that will help keep the queue down.

Demezhan Marikov

@ImmortalRabbit

@rnveach @romani Could you look to my pull request? There is merge conflict. Could you suggest me how to fix it? checkstyle/checkstyle#8052

Where communities thrive

People

Repo info

Activity