Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 18 20:16

    pbludov on issue-4219-shadowed-imports

    (compare)

  • Jan 07 11:07

    pbludov on issue-9149-stack-overflow2

    Issue #9149: removed input caus… (compare)

  • Jan 07 10:57

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Jan 07 07:33

    pbludov on issue-9149-stack-overflow2

    (compare)

  • Jan 06 17:28

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:35

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:06

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Dec 27 2020 14:23

    pbludov on master

    Issue #5951: Incorrect warning … minor: update wercker.sh to use… dependency: bump org.eclipse.jg… and 18 more (compare)

  • Dec 27 2020 12:12

    pbludov on issue-8864-cmd-set

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    Issue #9021: fix josm validation (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-8951-remove-buddy

    (compare)

  • Dec 27 2020 12:10

    pbludov on issue-6722-missing-asterisk

    (compare)

  • Dec 27 2020 12:08

    pbludov on issue-9124-stack-overflow-parenpad

    (compare)

  • Dec 27 2020 11:23

    pbludov on issue-8018-operator-wrap

    (compare)

  • Dec 27 2020 09:47

    pbludov on issue-9101-fix-stack-overflow

    (compare)

  • Dec 27 2020 09:43

    pbludov on issue-4219-shadowed-imports

    Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:59

    github-actions[bot] on issue-4219-shadowed-imports

    Issue #8651: Checkstyle fails o… Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:34

    pbludov on issue-8018-operator-wrap

    Issue #8018: AST based operator… (compare)

Shrey Kumar Singh
@sulkykookie
@ImmortalRabbit Hi, once you rebase to upstream, your branch wont consist of those additional commits. It will simply put your commit on top of the additional commits.
Demezhan Marikov
@ImmortalRabbit
git checkout master
git pull upstream master
git checkout <the-PR-branch>
git rebase master
git push --force
So this commands should help me? Am I right?
Shrey Kumar Singh
@sulkykookie
Use git fetch upstream, git rebase upstream/master, git push origin <patch branch> -f. Here upstream is the checkstyle's original repo
that's how ive been doing it ^
Demezhan Marikov
@ImmortalRabbit
okay, thanks @sulkykookie @wltan
Roman Ivanov
@romani
------- all above got answers -----
Roman Ivanov
@romani
All students, please rebase your branch on latest code, and please recheck that there is no conflicts in your PRs
Abhishek Kumar
@Abhishek-kumar09
@romani @rnveach @strkkk Please review PR checkstyle/checkstyle#8038, as all the other Indentation PR are dependent on it for their regression test.
Kaustubh Dixit
@DXTkastb
@romani some of the PRs are failing Travis CI, and all of them having the same problem: https://travis-ci.org/github/checkstyle/checkstyle/jobs/675875326
rnveach
@rnveach
@DXTkastb We are aware. A PR reported a false green light and was merged before being caught.
If the next PR I send doesn't fix it, I will revert the bad commit. checkstyle/checkstyle#8116
rnveach
@rnveach
I pushed the revert. The fix still needs 1 more thing.
developerhb
@developerhb
@romani @rnveach I rebased the PR checkstyle/checkstyle#7953 and the Travis CI failed. Before it passed and I have not made any changes. Please help.
rnveach
@rnveach
@developerhb I just pushed a fix a few minutes ago, you need to rebase on top of that.
developerhb
@developerhb
@rnveach okay I will do that. Thank you.
Gaurav Punjabi
@Gaurav-Punjabi
@romani Please reply to my queries here
checkstyle/checkstyle#8110
checkstyle/checkstyle#5890
Demezhan Marikov
@ImmortalRabbit
If my branch has 2 commits before first review, is there any way how I can reduce it to 1 commit without creating new branch with a new pull request?
rnveach
@rnveach
@ImmortalRabbit squash the commits into 1. PR guidelines provides an example command.
Demezhan Marikov
@ImmortalRabbit
@rnveach thanks
Demezhan Marikov
@ImmortalRabbit

@rnveach @romani What kind of example can be provided for this

<module name="LeftCurly">
  <property name="ignoreEnums" value="false"/>
</module>

Issue: checkstyle/checkstyle#7582
Link to documentation: https://checkstyle.org/config_blocks.html#LeftCurly

please review
developerhb
@developerhb
@romani @rnveach I have rebased the PR checkstyle/checkstyle#7953 and all checks have passed. Please review.
Demezhan Marikov
@ImmortalRabbit
@rnveach @romani What could cause this errors? Is someone else having same issue? All my pull request is taking to much time to complete travis-ci tests and failing for 403, 501 reasons. Branches are up to date. I have just checked.
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: Could not transfer artifact org.junit.platform:junit-platform-commons:jar:1.6.2 from/to central (https://repo.maven.apache.org/maven2): Authorization failed for https://repo.maven.apache.org/maven2/org/junit/platform/junit-platform-commons/1.6.2/junit-platform-commons-1.6.2.jar 403 Forbidden
Gaurav Punjabi
@Gaurav-Punjabi
As the mentors are busy in this period, should I wait for my PR to get merged or should I keep solving issues?
Kaustubh Dixit
@DXTkastb
solving issues is better I guess :)
Demezhan Marikov
@ImmortalRabbit

Screen Shot 2020-04-18 at 16.38.46.png

@Gaurav-Punjabi

Gaurav Punjabi
@Gaurav-Punjabi
Got it, thanks 👍🏻
Gaurab Dasgupta
@gaurabdg
@rnveach Can you please look into PR #8008?
Roman Ivanov
@romani
@ImmortalRabbit , please ask question in PR, looks like no reason of such example config, you can skip it for now
developerhb
@developerhb
@romani @rnveach can you please guide me for writing XpathQuery in the Test after updating the check to log DetailAST. I am working on issue #7728.
Roman Ivanov
@romani
@developerhb , please take a look at other PRs like this, there bunch of examples
Demezhan Marikov
@ImmortalRabbit
@romani @rnveach Could you check my questions for this issue? checkstyle/checkstyle#952
Tan Wei Liang
@wltan
just for everyone's info, CI is taking a while to pass due to a backlog of jobs on appveyor: https://ci.appveyor.com/project/Checkstyle/checkstyle/history
rnveach
@rnveach
@wltan I tried turning on killing duplicate builds for appveyor. Hopefully that will help keep the queue down.
Demezhan Marikov
@ImmortalRabbit
@rnveach @romani Could you look to my pull request? There is merge conflict. Could you suggest me how to fix it? checkstyle/checkstyle#8052
Praveen Kumar
@pkpale
@rnveach can you please review it checkstyle/checkstyle#7942
Shrey Kumar Singh
@sulkykookie

Is there any issue with the VisibilityModifer? I tried running it with allowPublicImmutableFields as true on the given example in the doc

public class ImmutableClass
{
  public final ImmutableSet<String> includes; // No warning
  public final ImmutableSet<String> excludes; // No warning
  public final java.lang.String notes; // No warning
  public final BigDecimal value; // No warning

  public ImmutableClass(Collection<String> includes, Collection<String> excludes,
               BigDecimal value, String notes)
  {
    this.includes = ImmutableSet.copyOf(includes);
    this.excludes = ImmutableSet.copyOf(excludes);
    this.value = value;
    this.notes = notes;
  }
}

and according to the doc it should throw no warning but it does...

$ java -jar ../checkstyle-8.30-all.jar -c config1.xml Test1.java
Starting audit...
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:3:37: Variable 'includes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:4:37: Variable 'excludes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:5:33: Variable 'notes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:7:20: Variable 'someValue' must be private and have accessor methods. [VisibilityModifier]
Audit done.
Checkstyle ends with 4 errors.
Demezhan Marikov
@ImmortalRabbit

@sulkykookie I am not sure, what is wrong here but you can check in VisibilityModifierCheckTest.java where you can find this test:

    public void testAllowPublicFinalFieldsInImmutableClass() throws Exception {
        final DefaultConfiguration checkConfig =
                createModuleConfig(VisibilityModifierCheck.class);
        checkConfig.addAttribute("allowPublicImmutableFields", "true");
        final String[] expected = {
            "12:39: " + getCheckMessage(MSG_KEY, "includes"),
            "13:39: " + getCheckMessage(MSG_KEY, "excludes"),
            "16:23: " + getCheckMessage(MSG_KEY, "list"),
            "34:20: " + getCheckMessage(MSG_KEY, "value"),
            "36:24: " + getCheckMessage(MSG_KEY, "bValue"),
            "37:31: " + getCheckMessage(MSG_KEY, "longValue"),
            "41:19: " + getCheckMessage(MSG_KEY, "C_D_E"),
        };
        verify(checkConfig, getPath("InputVisibilityModifierImmutable.java"), expected);
    }

I think running test case will help you to understand why your example doesn't work. InputVisibilityModifierImmutable.java is a file with examples for this Check.

Shrey Kumar Singh
@sulkykookie
I was just asking if the currently available example in the doc is incorrect
Demezhan Marikov
@ImmortalRabbit
Firnas Aleem
@AMFIRNAS
Hi
can I get an approval to this ?
I am on PR creation step :)
developerhb
@developerhb

@romani @rnveach I am generating diff report.

I am running following command
groovy diff.groovy --localGitRepo ../../checkstyle --baseBranch master --patchBranch 7728-updateabtractchecks-customimportorder --config my_check.xml --listOfProjects projects-to-test-on.properties

I am getting following error.

Caught: java.io.IOException: Cannot run program cmd in directory (directory of checkstyle-tester): Create Process error=5, Access is denied

Please help.

rnveach
@rnveach
@developerhb I recommend to start a google group and provide a log of entire run, push your directory as it is to your own branch and give us the branch URL. I don't recognize that type of error.
developerhb
@developerhb
You mean I should push all the changes to my branch and give the url of that branch.