Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Mar 13 14:30

    pbludov on master

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 36 more (compare)

  • Feb 23 21:43

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • Feb 23 21:34

    pbludov on maven

    (compare)

  • Feb 23 21:31

    pbludov on issue-9146-java11

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 9 more (compare)

  • Feb 23 21:24

    pbludov on issue-9310-java11-inputs

    (compare)

  • Feb 23 08:28

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 07:03

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 06:52

    pbludov on issue-9310-java11-inputs

    Issue #9152: Record implementin… infra: add checkout_from suppor… dependency: bump archunit-junit… and 3 more (compare)

  • Feb 21 19:48

    pbludov on issue-9310-java11-inputs

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 1 more (compare)

  • Feb 21 19:40

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 15:01

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 14:47

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 09:54

    pbludov on issue-9310-java11-inputs

    #Issue #9310: test inputs shoul… (compare)

  • Feb 20 07:41

    pbludov on master

    doc: fix checkstyle jar version… Issue #9297: solve spotbugs vio… (compare)

  • Feb 19 16:00

    pbludov on issue-9297-spotbugs-11

    (compare)

  • Feb 18 08:23

    pbludov on issue-9146-java11

    Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… Issue #9146: switch to jdk 11 i… and 1 more (compare)

  • Feb 18 07:29

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… (compare)

  • Feb 18 07:20

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… (compare)

  • Feb 18 07:13

    pbludov on issue-9146-java11

    Issue #9146: upgrade minimal re… Issue #9146: switch to jdk 11 i… (compare)

  • Feb 18 06:49

    pbludov on issue-9297-spotbugs-11

    Pull #9298: change job to check… Issue #9297: solve spotbugs vio… (compare)

Gaurav Punjabi
@Gaurav-Punjabi
As the mentors are busy in this period, should I wait for my PR to get merged or should I keep solving issues?
Kaustubh Dixit
@DXTkastb
solving issues is better I guess :)
Demezhan Marikov
@ImmortalRabbit

Screen Shot 2020-04-18 at 16.38.46.png

@Gaurav-Punjabi

Gaurav Punjabi
@Gaurav-Punjabi
Got it, thanks 👍🏻
Gaurab Dasgupta
@gaurabdg
@rnveach Can you please look into PR #8008?
Roman Ivanov
@romani
@ImmortalRabbit , please ask question in PR, looks like no reason of such example config, you can skip it for now
developerhb
@developerhb
@romani @rnveach can you please guide me for writing XpathQuery in the Test after updating the check to log DetailAST. I am working on issue #7728.
Roman Ivanov
@romani
@developerhb , please take a look at other PRs like this, there bunch of examples
Demezhan Marikov
@ImmortalRabbit
@romani @rnveach Could you check my questions for this issue? checkstyle/checkstyle#952
Tan Wei Liang
@wltan
just for everyone's info, CI is taking a while to pass due to a backlog of jobs on appveyor: https://ci.appveyor.com/project/Checkstyle/checkstyle/history
rnveach
@rnveach
@wltan I tried turning on killing duplicate builds for appveyor. Hopefully that will help keep the queue down.
Demezhan Marikov
@ImmortalRabbit
@rnveach @romani Could you look to my pull request? There is merge conflict. Could you suggest me how to fix it? checkstyle/checkstyle#8052
Praveen Kumar
@pkpale
@rnveach can you please review it checkstyle/checkstyle#7942
Shrey Kumar Singh
@sulkykookie

Is there any issue with the VisibilityModifer? I tried running it with allowPublicImmutableFields as true on the given example in the doc

public class ImmutableClass
{
  public final ImmutableSet<String> includes; // No warning
  public final ImmutableSet<String> excludes; // No warning
  public final java.lang.String notes; // No warning
  public final BigDecimal value; // No warning

  public ImmutableClass(Collection<String> includes, Collection<String> excludes,
               BigDecimal value, String notes)
  {
    this.includes = ImmutableSet.copyOf(includes);
    this.excludes = ImmutableSet.copyOf(excludes);
    this.value = value;
    this.notes = notes;
  }
}

and according to the doc it should throw no warning but it does...

$ java -jar ../checkstyle-8.30-all.jar -c config1.xml Test1.java
Starting audit...
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:3:37: Variable 'includes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:4:37: Variable 'excludes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:5:33: Variable 'notes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:7:20: Variable 'someValue' must be private and have accessor methods. [VisibilityModifier]
Audit done.
Checkstyle ends with 4 errors.
Demezhan Marikov
@ImmortalRabbit

@sulkykookie I am not sure, what is wrong here but you can check in VisibilityModifierCheckTest.java where you can find this test:

    public void testAllowPublicFinalFieldsInImmutableClass() throws Exception {
        final DefaultConfiguration checkConfig =
                createModuleConfig(VisibilityModifierCheck.class);
        checkConfig.addAttribute("allowPublicImmutableFields", "true");
        final String[] expected = {
            "12:39: " + getCheckMessage(MSG_KEY, "includes"),
            "13:39: " + getCheckMessage(MSG_KEY, "excludes"),
            "16:23: " + getCheckMessage(MSG_KEY, "list"),
            "34:20: " + getCheckMessage(MSG_KEY, "value"),
            "36:24: " + getCheckMessage(MSG_KEY, "bValue"),
            "37:31: " + getCheckMessage(MSG_KEY, "longValue"),
            "41:19: " + getCheckMessage(MSG_KEY, "C_D_E"),
        };
        verify(checkConfig, getPath("InputVisibilityModifierImmutable.java"), expected);
    }

I think running test case will help you to understand why your example doesn't work. InputVisibilityModifierImmutable.java is a file with examples for this Check.

Shrey Kumar Singh
@sulkykookie
I was just asking if the currently available example in the doc is incorrect
Demezhan Marikov
@ImmortalRabbit
Firnas Aleem
@AMFIRNAS
Hi
can I get an approval to this ?
I am on PR creation step :)
developerhb
@developerhb

@romani @rnveach I am generating diff report.

I am running following command
groovy diff.groovy --localGitRepo ../../checkstyle --baseBranch master --patchBranch 7728-updateabtractchecks-customimportorder --config my_check.xml --listOfProjects projects-to-test-on.properties

I am getting following error.

Caught: java.io.IOException: Cannot run program cmd in directory (directory of checkstyle-tester): Create Process error=5, Access is denied

Please help.

rnveach
@rnveach
@developerhb I recommend to start a google group and provide a log of entire run, push your directory as it is to your own branch and give us the branch URL. I don't recognize that type of error.
developerhb
@developerhb
You mean I should push all the changes to my branch and give the url of that branch.
Roman Ivanov
@romani
yes
Access is denied
please try to delete your contribution repo and clone it one more time
if still a problem , please debug a script in IDE or by println to get to know what command isfailing
Gaurab Dasgupta
@gaurabdg
@romani @rnveach Please review and merge #8180 as the parent PR depends on this and I cant push changes till then.
Roman Ivanov
@romani
CI is failing ...
Gaurab Dasgupta
@gaurabdg
@romani My bad, please review now.
Shashwat Jaiswal
@shashwatj07
please help me know why this build is failing checkstyle/checkstyle#7956
Abhishek Kumar
@Abhishek-kumar09
How can I suppress checks for online ci, because in PR checkstyle/checkstyle#8038 I had to write suppression file in MainTest.java which is extremely large, so I am getting methodLength and FileLength issues. I had wrote suppressions in suppressions.xml file du to which antrun-phase-verify is passing but online checkstyle tests are failed, Let me know the possible approach to solve this problem. All the other PRs of Indentation is dependent on this PR for their regression tests.
Gaurab Dasgupta
@gaurabdg
@romani @rnveach Can you please approve #8181 as CI is failing because of it.
developerhb
@developerhb
@rnveach As per your recommendation I have created a google group and provided the complete log for error in diff.groovy. Here is the link https://groups.google.com/forum/#!topic/checkstyle-tester-error/m176xggjywo
developerhb
@developerhb
@romani As per your advice, I cloned the contribution repo one more time, but it didn't help.
@romani The command failing is mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false
Kaustubh Dixit
@DXTkastb
@romani @rnveach please review : #8072
Roman Ivanov
@romani
@developerhb , please share full logs of execution by mean of gist.github.com
developerhb
@developerhb
Roman Ivanov
@romani
8.32 is released, thank a lot to all contributors - https://checkstyle.org/releasenotes.html#Release_8.32
Roman Ivanov
@romani
@developerhb , please run mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false in checkstyle-tester repo to see real problem, if still not that much details, please do same but "mvn -X ..... "
Gaurav Punjabi
@Gaurav-Punjabi
@romani Can you please help me with this error https://github.com/checkstyle/checkstyle/pull/8176#issuecomment-619533498
developerhb
@developerhb
@romani If I run the command mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false in checkstyle-tester, I get *Build Success
Roman Ivanov
@romani
you need to debug our groovy script to recheck why you have such error
developerhb
@developerhb
@romani The problem is solved. It was my anti-virus which was creating problem.