Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 09:24

    pbludov on issue-8909-markdownlint

    dependency: bump Saxon-HE from … Issue #6346: add var to list of… minor: Format markdown sources … and 1 more (compare)

  • Oct 30 19:34

    pbludov on issue-8909-markdownlint

    infra: update spring-cloud-gcp … doc: Add Mega-Linter to active … minor: Format markdown sources … and 1 more (compare)

  • Oct 30 13:30

    pbludov on issue-8909-markdownlint

    Issue #8909: add markdownlint t… (compare)

  • Oct 30 12:14

    pbludov on issue-8909-markdownlint

    Issue #8909: add markdownlint t… (compare)

  • Oct 30 09:07

    pbludov on issue-8909-markdownlint

    Issue #8909: add markdownlint t… (compare)

  • Oct 30 07:45

    pbludov on issue-8909-markdownlint

    Issue #8925: fix anchor links f… Issue #8916: use empty string f… minor: fix wording in assert fo… and 3 more (compare)

  • Oct 26 16:35

    pbludov on issue-0001-cirrus

    (compare)

  • Oct 26 16:35
    pbludov closed #2
  • Oct 26 16:35

    pbludov on pbludov-actions

    (compare)

  • Oct 26 16:34
    pbludov closed #1
  • Oct 26 08:01

    pbludov on master

    dependency: bump picocli from 4… Issue #3135: Indentation: non l… minor: refactor lambdas to be m… and 6 more (compare)

  • Oct 26 07:57

    pbludov on setup-semaphore

    (compare)

  • Oct 15 06:55

    pbludov on issue-6916-parallel

    Issue #6209: activate no-error-… Issue #8790: All Regexp Checks … Issue #7637: Update doc for Equ… and 5 more (compare)

  • Oct 11 07:57

    pbludov on issue-6916-parallel

    Issue #6916: enable parallel ex… (compare)

  • Oct 11 07:54

    pbludov on issue-6916-parallel

    Issue #6916: enable parallel ex… (compare)

  • Oct 11 07:19

    pbludov on issue-6916-parallel

    Issue #6916: enable parallel ex… (compare)

  • Oct 11 07:15

    pbludov on issue-6916-parallel

    Issue #6916: enable parallel ex… (compare)

  • Oct 11 07:13

    pbludov on issue-6916-parallel

    Issue #6916: enable parallel ex… (compare)

  • Oct 11 05:16

    pbludov on issue-6916-parallel

    minor: remove redundant spotbug… Issue #6658: pitest increase mu… minor: apply TokenUtil#forEachC… and 15 more (compare)

  • Oct 02 10:05

    pbludov on master

    Issue #8864: use .ci/validation… dependency: bump spotbugs-maven… minor: remove redundant spotbug… (compare)

Roman Ivanov
@romani
@developerhb , please take a look at other PRs like this, there bunch of examples
Demezhan Marikov
@ImmortalRabbit
@romani @rnveach Could you check my questions for this issue? checkstyle/checkstyle#952
Tan Wei Liang
@wltan
just for everyone's info, CI is taking a while to pass due to a backlog of jobs on appveyor: https://ci.appveyor.com/project/Checkstyle/checkstyle/history
rnveach
@rnveach
@wltan I tried turning on killing duplicate builds for appveyor. Hopefully that will help keep the queue down.
Demezhan Marikov
@ImmortalRabbit
@rnveach @romani Could you look to my pull request? There is merge conflict. Could you suggest me how to fix it? checkstyle/checkstyle#8052
Praveen Kumar
@pkpale
@rnveach can you please review it checkstyle/checkstyle#7942
Shrey Kumar Singh
@sulkykookie

Is there any issue with the VisibilityModifer? I tried running it with allowPublicImmutableFields as true on the given example in the doc

public class ImmutableClass
{
  public final ImmutableSet<String> includes; // No warning
  public final ImmutableSet<String> excludes; // No warning
  public final java.lang.String notes; // No warning
  public final BigDecimal value; // No warning

  public ImmutableClass(Collection<String> includes, Collection<String> excludes,
               BigDecimal value, String notes)
  {
    this.includes = ImmutableSet.copyOf(includes);
    this.excludes = ImmutableSet.copyOf(excludes);
    this.value = value;
    this.notes = notes;
  }
}

and according to the doc it should throw no warning but it does...

$ java -jar ../checkstyle-8.30-all.jar -c config1.xml Test1.java
Starting audit...
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:3:37: Variable 'includes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:4:37: Variable 'excludes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:5:33: Variable 'notes' must be private and have accessor methods. [VisibilityModifier]
[ERROR] C:\Users\Shrey\Desktop\Checkstyle jar\visibilityModifier\Test1.java:7:20: Variable 'someValue' must be private and have accessor methods. [VisibilityModifier]
Audit done.
Checkstyle ends with 4 errors.
Demezhan Marikov
@ImmortalRabbit

@sulkykookie I am not sure, what is wrong here but you can check in VisibilityModifierCheckTest.java where you can find this test:

    public void testAllowPublicFinalFieldsInImmutableClass() throws Exception {
        final DefaultConfiguration checkConfig =
                createModuleConfig(VisibilityModifierCheck.class);
        checkConfig.addAttribute("allowPublicImmutableFields", "true");
        final String[] expected = {
            "12:39: " + getCheckMessage(MSG_KEY, "includes"),
            "13:39: " + getCheckMessage(MSG_KEY, "excludes"),
            "16:23: " + getCheckMessage(MSG_KEY, "list"),
            "34:20: " + getCheckMessage(MSG_KEY, "value"),
            "36:24: " + getCheckMessage(MSG_KEY, "bValue"),
            "37:31: " + getCheckMessage(MSG_KEY, "longValue"),
            "41:19: " + getCheckMessage(MSG_KEY, "C_D_E"),
        };
        verify(checkConfig, getPath("InputVisibilityModifierImmutable.java"), expected);
    }

I think running test case will help you to understand why your example doesn't work. InputVisibilityModifierImmutable.java is a file with examples for this Check.

Shrey Kumar Singh
@sulkykookie
I was just asking if the currently available example in the doc is incorrect
Demezhan Marikov
@ImmortalRabbit
Firnas Aleem
@AMFIRNAS
Hi
can I get an approval to this ?
I am on PR creation step :)
developerhb
@developerhb

@romani @rnveach I am generating diff report.

I am running following command
groovy diff.groovy --localGitRepo ../../checkstyle --baseBranch master --patchBranch 7728-updateabtractchecks-customimportorder --config my_check.xml --listOfProjects projects-to-test-on.properties

I am getting following error.

Caught: java.io.IOException: Cannot run program cmd in directory (directory of checkstyle-tester): Create Process error=5, Access is denied

Please help.

rnveach
@rnveach
@developerhb I recommend to start a google group and provide a log of entire run, push your directory as it is to your own branch and give us the branch URL. I don't recognize that type of error.
developerhb
@developerhb
You mean I should push all the changes to my branch and give the url of that branch.
Roman Ivanov
@romani
yes
Access is denied
please try to delete your contribution repo and clone it one more time
if still a problem , please debug a script in IDE or by println to get to know what command isfailing
Gaurab Dasgupta
@gaurabdg
@romani @rnveach Please review and merge #8180 as the parent PR depends on this and I cant push changes till then.
Roman Ivanov
@romani
CI is failing ...
Gaurab Dasgupta
@gaurabdg
@romani My bad, please review now.
Shashwat Jaiswal
@shashwatj07
please help me know why this build is failing checkstyle/checkstyle#7956
Abhishek Kumar
@Abhishek-kumar09
How can I suppress checks for online ci, because in PR checkstyle/checkstyle#8038 I had to write suppression file in MainTest.java which is extremely large, so I am getting methodLength and FileLength issues. I had wrote suppressions in suppressions.xml file du to which antrun-phase-verify is passing but online checkstyle tests are failed, Let me know the possible approach to solve this problem. All the other PRs of Indentation is dependent on this PR for their regression tests.
Gaurab Dasgupta
@gaurabdg
@romani @rnveach Can you please approve #8181 as CI is failing because of it.
developerhb
@developerhb
@rnveach As per your recommendation I have created a google group and provided the complete log for error in diff.groovy. Here is the link https://groups.google.com/forum/#!topic/checkstyle-tester-error/m176xggjywo
developerhb
@developerhb
@romani As per your advice, I cloned the contribution repo one more time, but it didn't help.
@romani The command failing is mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false
Kaustubh Dixit
@DXTkastb
@romani @rnveach please review : #8072
Roman Ivanov
@romani
@developerhb , please share full logs of execution by mean of gist.github.com
developerhb
@developerhb
Roman Ivanov
@romani
8.32 is released, thank a lot to all contributors - https://checkstyle.org/releasenotes.html#Release_8.32
Roman Ivanov
@romani
@developerhb , please run mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false in checkstyle-tester repo to see real problem, if still not that much details, please do same but "mvn -X ..... "
Gaurav Punjabi
@Gaurav-Punjabi
@romani Can you please help me with this error https://github.com/checkstyle/checkstyle/pull/8176#issuecomment-619533498
developerhb
@developerhb
@romani If I run the command mvn -e --batch-mode site -Dcheckstyle.config.location=my_check.xml -Dcheckstyle.excludes= -Dcheckstyle.version=8.32-SNAPSHOT -Dcheckstyle.failsOnError=false in checkstyle-tester, I get *Build Success
Roman Ivanov
@romani
you need to debug our groovy script to recheck why you have such error
developerhb
@developerhb
@romani The problem is solved. It was my anti-virus which was creating problem.
Abhishek Kumar
@Abhishek-kumar09
https://github.com/checkstyle/checkstyle/pull/8059#issuecomment-619549158 @romani @rnveach @strkkk Please have look on the comment.
developerhb
@developerhb
@romani @rnveach I have created PR checkstyle/checkstyle#8195 for issue #7728
developerhb
@developerhb
@romani @rnveach I am importing org.checkstyle.suppressionxpathfilter.AbstractXpathTestSupportin test classes for issue #7728. In Travis CI exec-maven-plugin fails due to this import. But, it passes in mvn clean verify on my local. What could be the reason? PR reference checkstyle/checkstyle#8195
developerhb
@developerhb
@romani I have imported another class and CI has passed.
developerhb
@developerhb
@romani I have created issue #8200.
Roman Ivanov
@romani
All students, please rebase your PRs over latest code, we did a release so all PRs that have new Checks or new Check properties - MUST rebase and upgrade version in code.
Roman Ivanov
@romani