by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jul 29 06:54

    pbludov on issue-8544-format-xml-sources-other-configs

    (compare)

  • Jul 27 08:51

    pbludov on issue-8544-format-xml-sources-other-configs

    dependency: bump junit-pioneer … Issue #8533: add to top button Issue #8539: change diff trigger and 14 more (compare)

  • Jul 27 08:34

    pbludov on issue-8544-format-xml-sources-checks-two

    (compare)

  • Jul 27 08:34

    pbludov on issue-8544-format-xml-sources-google-sun-styles

    (compare)

  • Jul 26 22:59

    pbludov on issue-8544-format-xml-sources-checks-two

    Issue #8544: all xdocs for chec… (compare)

  • Jul 26 22:58

    pbludov on issue-8544-format-xml-sources-checks-two

    Issue #8544 All xdocs for chec… (compare)

  • Jul 26 22:44

    pbludov on issue-8544-format-xml-sources-google-sun-styles

    dependency: bump junit-pioneer … Issue #8533: add to top button Issue #8539: change diff trigger and 12 more (compare)

  • Jul 26 22:35

    pbludov on issue-8544-format-xml-sources-checks-one

    (compare)

  • Jul 26 22:34

    pbludov on issue-8544-format-xml-sources-idea

    (compare)

  • Jul 26 06:36

    pbludov on issue-8544-format-xml-sources-checks-one

    Issue #8544: format xml sources… (compare)

  • Jul 26 06:32

    pbludov on issue-8544-format-xml-sources-checks-one

    Issue #8544: format xml sources… Issue #8544: format xml source… Issue #8544: format xml sources… (compare)

  • Jul 26 06:22

    pbludov on issue-8544-format-xml-sources-idea

    Issue #8544: format xml sources… Issue #8544: format xml sources… (compare)

  • Jul 26 06:20

    pbludov on issue-8544-format-xml-sources-xdocs-general

    (compare)

  • Jul 25 19:07

    pbludov on issue-8543-format-xml-sources

    (compare)

  • Jul 25 19:06

    pbludov on issue-8544-format-xml-sources-checkstyle-cfg

    (compare)

  • Jul 25 19:03

    pbludov on issue-8544-format-xml-sources-idea

    Issue #8544: format xml source… (compare)

  • Jul 25 19:00

    pbludov on issue-8544-format-xml-sources-idea

    Issue #8544: format xml sources… Issue #8544: format xml source… (compare)

  • Jul 25 18:51

    pbludov on issue-8544-format-xml-sources-xdocs-general

    Issue #8544: format xml sources… Issue #8544: format xml sources… (compare)

  • Jul 25 18:41

    pbludov on issue-8544-format-xml-sources-xdocs-general

    Issue #8544: format xml sources… (compare)

  • Jul 25 18:01

    pbludov on issue-8544-format-xml-sources-xdocs-general

    Issue #8544: format xml sources… (compare)

developerhb
@developerhb
Thank you @romani
developerhb
@developerhb
@romani I have two new queries in comments section of issue #4944. Please have a look.
Kevin S. Clarke
@ksclarke
I'm trying to figure out how to control the indentation of System.err.println below. Checkstyle tells me it should be indented four more spaces to the right than the System.out.println. But, I want it indented like below (with the same number of indentations). Is there a setting for this? I'm not seeing anything on https://checkstyle.sourceforge.io/apidocs/com/puppycrawl/tools/checkstyle/checks/indentation/IndentationCheck.html that looks like what I want.
        s3Client.head(myBucket, myKey, head -> {
            System.out.println(head);
        }, error -> {
            System.err.println("error");
        });
The only custom config I have in my Indentation module currently is <property name="throwsIndent" value="8" />
Kevin S. Clarke
@ksclarke
I found an existing ticket in the issues queue for this (I believe), so I've just added my information there: checkstyle/checkstyle#7926 | The person who opened that ticket didn't follow through with the all the requirements for submitting a ticket.
Roman Ivanov
@romani
@ksclarke , Indentation Check is very problemtic, there are a lot of problems in it, please review our issue tracker and make sure your are on latest version of checkstyle
you are welcome to provide patch with fix to make it work
Roman Ivanov
@romani
@ksclarke , thanks a lot for detailed issue report, I made cleanup in issue and now it become approved
Kevin S. Clarke
@ksclarke
Okay, thank you, @romani
developerhb
@developerhb
@romani I have two queries in comments section of issue #4944. Please have a look.
Roman Ivanov
@romani
@developerhb , I replied to you
developerhb
@developerhb
@romani I have created PR checkstyle/checkstyle#8317. Please have a look.
Abhishek Kumar
@Abhishek-kumar09

@romani @rnveach

Should AnnotationArrayInit follow the same rulesets as arrayInit does. Or it should have different rulesets.

checkstyle/checkstyle#5951

developerhb
@developerhb
@romani I am getting CI failure in PR checkstyle/checkstyle#8317. Please help me in solving this.
Abhishek Kumar
@Abhishek-kumar09
How much you like the new look of github...
Roman Ivanov
@romani
I replied you in PR
UI is better from perspective of vertical space usage .... we just need to over come habit to use it in old way
developerhb
@developerhb
@romani when will checkstyle get the discussions feature on github?
Roman Ivanov
@romani
we never find a reason why we need this
discussion in issue tracker is the same
developerhb
@developerhb
@romani I have a question in PR checkstyle/checkstyle#8317. Please have a look.
developerhb
@developerhb
@romani The CI is now green in PR checkstyle/checkstyle#8317
developerhb
@developerhb
@romani I have applied changes requested by you in PR checkstyle/checkstyle#8317
Abhishek Kumar
@Abhishek-kumar09
Abhishek Kumar
@Abhishek-kumar09

Just wondering... Is checktyle is made to be used only inside IDEs, I was just exploring github and found a repo where checkstyle is used as github-actions to give code analysis within the PR as by the bot. It was: https://github.com/nikitasavinov/checkstyle-action/pull/6/files

I found it really good, so shared.

rnveach
@rnveach
@Abhishek-kumar09 checkstyle is used inside maven and CLI, so its not just interactive environments. It is really for anything.
Abhishek Kumar
@Abhishek-kumar09
great @rnveach . Thanks for clarifying things.
sushant-kun
@sushant-kun
Hello everyone,Sushant here. I really want to start contributing to checkstyle. What are the things I could do at the moment?
Roman Ivanov
@romani

@sushant-kun , please help us with checkstyle/checkstyle#7562 , it is very very simple issue, but it is just introduction issue to let you pass through whole contribution process.

Pages that are helpful for new contributors:
http://checkstyle.sourceforge.net/beginning_development.html
http://checkstyle.sourceforge.net/writingchecks.html
http://checkstyle.sourceforge.net/contributing.html

Abhishek Kumar
@Abhishek-kumar09
Please reply an query here so that I could start working on it:
https://github.com/checkstyle/checkstyle/issues/5951#issuecomment-647024512
Shashwat Jaiswal
@shashwatj07
please look at my PRs @romani
They've been waiting for almost a month now.
Roman Ivanov
@romani
I apologise for delay... I will reply during weekends
Abhishek Kumar
@Abhishek-kumar09
No Problem @romani , :)
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.35 - thanks to all participants. Sorry to all if I did not let your PR merge, all PRs will reviewed.
Dawid Kubicki
@dkubicki
Hi all, gradle 6.5.1 and checkstyle 8.26 is any way to tackle with new feature in Java 14 ? (I use plugin)
Caused by: java.lang.IllegalStateException: /src/main/java/pl/LoaderInfo.java:7:8: unexpected token: record
        at com.puppycrawl.tools.checkstyle.JavaParser$1.reportError(JavaParser.java:93)
Andrei Paikin
@strkkk
@dkubicki records support will be part of next 8.36 release, but for now you can only exclude files with records with https://checkstyle.org/config_filefilters.html#BeforeExecutionExclusionFileFilter
Dawid Kubicki
@dkubicki
@strkkk many thx.
Roman Ivanov
@romani
next release will be at last weekend of August
Sarthak Handa
@sarthakhanda
greetings @romani

[ERROR] Failures:
[ERROR] CommitValidationTest.testCommitMessageHasProperStructure:148 Commit 628a550c80a9b1b449efd3cb3f53c6dbc9f40146 message: "Fixed bug\n" is invalid
Proper commit message should adhere to the following rules:
1) Must match one of the following patterns:
^Issue #\d+: .$
^Pull #\d+: .
$
^(minor|config|infra|doc|spelling|dependency): .*$
2) It contains only one line of text
3) Must not end with a period, space, or tab
4) Commit message should be less than or equal to 200 characters

The rule broken was: 1
[INFO]
[ERROR] Tests run: 3256, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51.425 s
[INFO] Finished at: 2020-08-02T22:03:36+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project checkstyle: There are test failures.
[ERROR]
[ERROR] Please refer to /home/sarthakhanda/Desktop/checkstyle/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

i'm getting these errors while running mvn verify
Andrei Paikin
@strkkk
@sarthakhanda error message says what is wrong
Sarthak Handa
@sarthakhanda
I see that but i followed the exact pattern for the commit message
rnveach
@rnveach
@sarthakhanda you didn't as error message shows the commit message that is failing the rules