by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 08:13

    pbludov on issue-8839-jdt-r17

    (compare)

  • 07:26
    pbludov synchronize #2
  • 07:26

    pbludov on issue-0001-cirrus

    Issue #0001: cirrus-ci (compare)

  • 07:21
    pbludov synchronize #2
  • 07:21

    pbludov on issue-0001-cirrus

    Issue #0001: cirrus-ci (compare)

  • 07:09
    pbludov synchronize #2
  • 07:09

    pbludov on issue-0001-cirrus

    Issue #0001: cirrus-ci (compare)

  • 07:08
    pbludov synchronize #2
  • 07:08

    pbludov on issue-0001-cirrus

    Issue #0001: cirrus-ci (compare)

  • 07:06
    pbludov synchronize #2
  • 07:06

    pbludov on issue-0001-cirrus

    Issue #0001: cirrus-ci (compare)

  • 07:05
    pbludov opened #2
  • 07:04

    pbludov on issue-0001-cirrus

    Issue #8839: update eclipse com… Issue #8842: Add rebase github … minor: fix control does not ret… and 4 more (compare)

  • 06:59

    pbludov on issue-0001-cirrus

    (compare)

  • 06:58

    pbludov on issue-0001-cirrus

    Issue #8839: update eclipse com… Issue #8842: Add rebase github … Issue #8805: move miscellaneous… and 1 more (compare)

  • 06:57

    pbludov on master

    doc: Add stickler-ci to the act… Issue #8122: Google style shoul… Issue #7872: fixes Resolve Pite… and 35 more (compare)

  • Sep 22 17:56

    pbludov on issue-8805-semaphore-ci

    (compare)

  • Sep 22 12:24

    pbludov on issue-8805-semaphore-ci

    Issue #8839: update eclipse com… Issue #8842: Add rebase github … Issue #8805: move miscellaneous… (compare)

  • Sep 22 06:55

    pbludov on issue-8839-jdt-r17

    Issue #8839: update eclipse com… (compare)

  • Sep 21 14:21

    pbludov on issue-8839-jdt-r17

    Issue #8839: update eclipse com… (compare)

Roman Ivanov
@romani
@ksclarke , Indentation Check is very problemtic, there are a lot of problems in it, please review our issue tracker and make sure your are on latest version of checkstyle
you are welcome to provide patch with fix to make it work
Roman Ivanov
@romani
@ksclarke , thanks a lot for detailed issue report, I made cleanup in issue and now it become approved
Kevin S. Clarke
@ksclarke
Okay, thank you, @romani
developerhb
@developerhb
@romani I have two queries in comments section of issue #4944. Please have a look.
Roman Ivanov
@romani
@developerhb , I replied to you
developerhb
@developerhb
@romani I have created PR checkstyle/checkstyle#8317. Please have a look.
Abhishek Kumar
@Abhishek-kumar09

@romani @rnveach

Should AnnotationArrayInit follow the same rulesets as arrayInit does. Or it should have different rulesets.

checkstyle/checkstyle#5951

developerhb
@developerhb
@romani I am getting CI failure in PR checkstyle/checkstyle#8317. Please help me in solving this.
Abhishek Kumar
@Abhishek-kumar09
How much you like the new look of github...
Roman Ivanov
@romani
I replied you in PR
UI is better from perspective of vertical space usage .... we just need to over come habit to use it in old way
developerhb
@developerhb
@romani when will checkstyle get the discussions feature on github?
Roman Ivanov
@romani
we never find a reason why we need this
discussion in issue tracker is the same
developerhb
@developerhb
@romani I have a question in PR checkstyle/checkstyle#8317. Please have a look.
developerhb
@developerhb
@romani The CI is now green in PR checkstyle/checkstyle#8317
developerhb
@developerhb
@romani I have applied changes requested by you in PR checkstyle/checkstyle#8317
Abhishek Kumar
@Abhishek-kumar09
Abhishek Kumar
@Abhishek-kumar09

Just wondering... Is checktyle is made to be used only inside IDEs, I was just exploring github and found a repo where checkstyle is used as github-actions to give code analysis within the PR as by the bot. It was: https://github.com/nikitasavinov/checkstyle-action/pull/6/files

I found it really good, so shared.

rnveach
@rnveach
@Abhishek-kumar09 checkstyle is used inside maven and CLI, so its not just interactive environments. It is really for anything.
Abhishek Kumar
@Abhishek-kumar09
great @rnveach . Thanks for clarifying things.
sushant-kun
@sushant-kun
Hello everyone,Sushant here. I really want to start contributing to checkstyle. What are the things I could do at the moment?
Roman Ivanov
@romani

@sushant-kun , please help us with checkstyle/checkstyle#7562 , it is very very simple issue, but it is just introduction issue to let you pass through whole contribution process.

Pages that are helpful for new contributors:
http://checkstyle.sourceforge.net/beginning_development.html
http://checkstyle.sourceforge.net/writingchecks.html
http://checkstyle.sourceforge.net/contributing.html

Abhishek Kumar
@Abhishek-kumar09
Please reply an query here so that I could start working on it:
https://github.com/checkstyle/checkstyle/issues/5951#issuecomment-647024512
Shashwat Jaiswal
@shashwatj07
please look at my PRs @romani
They've been waiting for almost a month now.
Roman Ivanov
@romani
I apologise for delay... I will reply during weekends
Abhishek Kumar
@Abhishek-kumar09
No Problem @romani , :)
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.35 - thanks to all participants. Sorry to all if I did not let your PR merge, all PRs will reviewed.
Dawid Kubicki
@dkubicki
Hi all, gradle 6.5.1 and checkstyle 8.26 is any way to tackle with new feature in Java 14 ? (I use plugin)
Caused by: java.lang.IllegalStateException: /src/main/java/pl/LoaderInfo.java:7:8: unexpected token: record
        at com.puppycrawl.tools.checkstyle.JavaParser$1.reportError(JavaParser.java:93)
Andrei Paikin
@strkkk
@dkubicki records support will be part of next 8.36 release, but for now you can only exclude files with records with https://checkstyle.org/config_filefilters.html#BeforeExecutionExclusionFileFilter
Dawid Kubicki
@dkubicki
@strkkk many thx.
Roman Ivanov
@romani
next release will be at last weekend of August
Sarthak Handa
@sarthakhanda
greetings @romani

[ERROR] Failures:
[ERROR] CommitValidationTest.testCommitMessageHasProperStructure:148 Commit 628a550c80a9b1b449efd3cb3f53c6dbc9f40146 message: "Fixed bug\n" is invalid
Proper commit message should adhere to the following rules:
1) Must match one of the following patterns:
^Issue #\d+: .$
^Pull #\d+: .
$
^(minor|config|infra|doc|spelling|dependency): .*$
2) It contains only one line of text
3) Must not end with a period, space, or tab
4) Commit message should be less than or equal to 200 characters

The rule broken was: 1
[INFO]
[ERROR] Tests run: 3256, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51.425 s
[INFO] Finished at: 2020-08-02T22:03:36+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project checkstyle: There are test failures.
[ERROR]
[ERROR] Please refer to /home/sarthakhanda/Desktop/checkstyle/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

i'm getting these errors while running mvn verify
Andrei Paikin
@strkkk
@sarthakhanda error message says what is wrong
Sarthak Handa
@sarthakhanda
I see that but i followed the exact pattern for the commit message
rnveach
@rnveach
@sarthakhanda you didn't as error message shows the commit message that is failing the rules
Rituparno Biswas
@roopbiswas
Hi everyone, I'm Rituparno! I really wish to start contributing to checkstyle. I've gone through the issues and found #8269 and #7562 quite intriguing. Please let me know if I can work on any of them.
Roman Ivanov
@romani
you just got a reply
just make a comment "I am no it" in issues, and you are welcome with PR
Rituparno Biswas
@roopbiswas
Cool! Thanks!
Roman Ivanov
@romani
@developerhb , please do not forget to claim bounty
developerhb
@developerhb
@romani can you please guide how can I claim bounty? What procedure should I follow?
developerhb
@developerhb
@romani I have submitted a bounty claim for issue #4944.
Roman Ivanov
@romani
accepted. Please do more fixes.
developerhb
@developerhb
Sure @romani I will do more fixes. Would you suggest me any issues to work on?
Roman Ivanov
@romani
@developerhb , please try checkstyle/checkstyle#6658