Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • May 04 15:59

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • May 04 15:56

    pbludov on issue-9146-java11

    infra: move PR description to a… infra: disable verify-no-except… Issue #9930: Resolved issues wi… and 3 more (compare)

  • May 03 13:29

    pbludov on issue-9146-java11

    Issue #9475: add code example o… config: upgrade sevntu-checksty… Issue #9474: add code example o… and 30 more (compare)

  • Apr 27 10:05

    pbludov on issue-9907-jdk16

    Issue #9907: set up Java16 build (compare)

  • Apr 27 09:09

    pbludov on issue-9907-jdk16

    infra: move xwiki validation to… infra: move pmd build-tools rep… Issue #9796: update MagicNumber… and 20 more (compare)

  • Apr 20 20:02

    pbludov on issue-9907-jdk16

    Issue #9907: set up Java16 build (compare)

  • Apr 20 19:35

    pbludov on issue-9907-jdk16

    Issue #8010: CommentsIndentatio… minor: fix formatting Issue #8989: Checkstyle parser … and 33 more (compare)

  • Mar 13 14:30

    pbludov on master

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 36 more (compare)

  • Feb 23 21:43

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • Feb 23 21:34

    pbludov on maven

    (compare)

  • Feb 23 21:31

    pbludov on issue-9146-java11

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 9 more (compare)

  • Feb 23 21:24

    pbludov on issue-9310-java11-inputs

    (compare)

  • Feb 23 08:28

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 07:03

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 06:52

    pbludov on issue-9310-java11-inputs

    Issue #9152: Record implementin… infra: add checkout_from suppor… dependency: bump archunit-junit… and 3 more (compare)

  • Feb 21 19:48

    pbludov on issue-9310-java11-inputs

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 1 more (compare)

  • Feb 21 19:40

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 15:01

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 14:47

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 09:54

    pbludov on issue-9310-java11-inputs

    #Issue #9310: test inputs shoul… (compare)

Abhishek Kumar
@Abhishek-kumar09

Just wondering... Is checktyle is made to be used only inside IDEs, I was just exploring github and found a repo where checkstyle is used as github-actions to give code analysis within the PR as by the bot. It was: https://github.com/nikitasavinov/checkstyle-action/pull/6/files

I found it really good, so shared.

rnveach
@rnveach
@Abhishek-kumar09 checkstyle is used inside maven and CLI, so its not just interactive environments. It is really for anything.
Abhishek Kumar
@Abhishek-kumar09
great @rnveach . Thanks for clarifying things.
sushant-kun
@sushant-kun
Hello everyone,Sushant here. I really want to start contributing to checkstyle. What are the things I could do at the moment?
Roman Ivanov
@romani

@sushant-kun , please help us with checkstyle/checkstyle#7562 , it is very very simple issue, but it is just introduction issue to let you pass through whole contribution process.

Pages that are helpful for new contributors:
http://checkstyle.sourceforge.net/beginning_development.html
http://checkstyle.sourceforge.net/writingchecks.html
http://checkstyle.sourceforge.net/contributing.html

Abhishek Kumar
@Abhishek-kumar09
Please reply an query here so that I could start working on it:
https://github.com/checkstyle/checkstyle/issues/5951#issuecomment-647024512
Shashwat Jaiswal
@shashwatj07
please look at my PRs @romani
They've been waiting for almost a month now.
Roman Ivanov
@romani
I apologise for delay... I will reply during weekends
Abhishek Kumar
@Abhishek-kumar09
No Problem @romani , :)
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.35 - thanks to all participants. Sorry to all if I did not let your PR merge, all PRs will reviewed.
Dawid Kubicki
@dkubicki
Hi all, gradle 6.5.1 and checkstyle 8.26 is any way to tackle with new feature in Java 14 ? (I use plugin)
Caused by: java.lang.IllegalStateException: /src/main/java/pl/LoaderInfo.java:7:8: unexpected token: record
        at com.puppycrawl.tools.checkstyle.JavaParser$1.reportError(JavaParser.java:93)
Andrei Paikin
@strkkk
@dkubicki records support will be part of next 8.36 release, but for now you can only exclude files with records with https://checkstyle.org/config_filefilters.html#BeforeExecutionExclusionFileFilter
Dawid Kubicki
@dkubicki
@strkkk many thx.
Roman Ivanov
@romani
next release will be at last weekend of August
Sarthak Handa
@sarthakhanda
greetings @romani

[ERROR] Failures:
[ERROR] CommitValidationTest.testCommitMessageHasProperStructure:148 Commit 628a550c80a9b1b449efd3cb3f53c6dbc9f40146 message: "Fixed bug\n" is invalid
Proper commit message should adhere to the following rules:
1) Must match one of the following patterns:
^Issue #\d+: .$
^Pull #\d+: .
$
^(minor|config|infra|doc|spelling|dependency): .*$
2) It contains only one line of text
3) Must not end with a period, space, or tab
4) Commit message should be less than or equal to 200 characters

The rule broken was: 1
[INFO]
[ERROR] Tests run: 3256, Failures: 1, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 51.425 s
[INFO] Finished at: 2020-08-02T22:03:36+05:30
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.2:test (default-test) on project checkstyle: There are test failures.
[ERROR]
[ERROR] Please refer to /home/sarthakhanda/Desktop/checkstyle/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

i'm getting these errors while running mvn verify
Andrei Paikin
@strkkk
@sarthakhanda error message says what is wrong
Sarthak Handa
@sarthakhanda
I see that but i followed the exact pattern for the commit message
rnveach
@rnveach
@sarthakhanda you didn't as error message shows the commit message that is failing the rules
Rituparno Biswas
@roopbiswas
Hi everyone, I'm Rituparno! I really wish to start contributing to checkstyle. I've gone through the issues and found #8269 and #7562 quite intriguing. Please let me know if I can work on any of them.
Roman Ivanov
@romani
you just got a reply
just make a comment "I am no it" in issues, and you are welcome with PR
Rituparno Biswas
@roopbiswas
Cool! Thanks!
Roman Ivanov
@romani
@developerhb , please do not forget to claim bounty
developerhb
@developerhb
@romani can you please guide how can I claim bounty? What procedure should I follow?
developerhb
@developerhb
@romani I have submitted a bounty claim for issue #4944.
Roman Ivanov
@romani
accepted. Please do more fixes.
developerhb
@developerhb
Sure @romani I will do more fixes. Would you suggest me any issues to work on?
Roman Ivanov
@romani
@developerhb , please try checkstyle/checkstyle#6658
developerhb
@developerhb
okay @romani I will look into this issue.
Abhishek Kumar
@Abhishek-kumar09
please also review: checkstyle/checkstyle#8719
Shashwat Jaiswal
@shashwatj07
Hey everyone! How is it going?
@romani I was really busy since the past few days. Now I want to restart contributing. Can you suggest some issues?
developerhb
@developerhb
@romani I have questions in comments section of issue checkstyle/checkstyle#6658 . Please have a look.
Andrei Paikin
@strkkk
@shashwatj07 I have merged PR for checkstyle/checkstyle#8122 but there are other items, I think you can continue to work on them
Shashwat Jaiswal
@shashwatj07
okay thanks
Abhishek Kumar
@Abhishek-kumar09
Shashwat Jaiswal
@shashwatj07
Abhishek Kumar
@Abhishek-kumar09
developerhb
@developerhb
@romani need help with issue checkstyle/checkstyle#6658 . I have some questions there.
Roman Ivanov
@romani
@Abhishek-kumar09 , please send PR to add this tool to https://checkstyle.org/#Related_Tools
Abhishek Kumar
@Abhishek-kumar09

please send PR to add this tool to https://checkstyle.org/#Related_Tools

Sorry, which tool. Sorry I didn't get it.

Abhishek Kumar
@Abhishek-kumar09
Need a small help!
According to new rules, in input files we have to write a //ok or //violation at the end of every file. I just want to know what it (ok or violation) depicts? <br>
Sorry I could not found the pull request regarding this change to learn more about it.
Roman Ivanov
@romani
Sorry I didn't get it.
Strange .. I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Sorry I could not found the pull request regarding this change to learn more about it.

checkstyle/checkstyle#8825 I do pre-step to ease update for you

Abhishek Kumar
@Abhishek-kumar09

I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Oh! that one... Ok..., I will send a PR regarding it. :)
Here is that comment https://github.com/checkstyle/checkstyle/pull/8719#issuecomment-691179809

Abhishek Kumar
@Abhishek-kumar09
@strkkk I have tried to take main checkstyle repo as a reference for creating diff report in github-actions. Please have a look on commit Abhishek-kumar09/checkstyle@a990e21