Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 20 20:02

    pbludov on issue-9907-jdk16

    Issue #9907: set up Java16 build (compare)

  • Apr 20 19:35

    pbludov on issue-9907-jdk16

    Issue #8010: CommentsIndentatio… minor: fix formatting Issue #8989: Checkstyle parser … and 33 more (compare)

  • Mar 13 14:30

    pbludov on master

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 36 more (compare)

  • Feb 23 21:43

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • Feb 23 21:34

    pbludov on maven

    (compare)

  • Feb 23 21:31

    pbludov on issue-9146-java11

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 9 more (compare)

  • Feb 23 21:24

    pbludov on issue-9310-java11-inputs

    (compare)

  • Feb 23 08:28

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 07:03

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 06:52

    pbludov on issue-9310-java11-inputs

    Issue #9152: Record implementin… infra: add checkout_from suppor… dependency: bump archunit-junit… and 3 more (compare)

  • Feb 21 19:48

    pbludov on issue-9310-java11-inputs

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 1 more (compare)

  • Feb 21 19:40

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 15:01

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 14:47

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 09:54

    pbludov on issue-9310-java11-inputs

    #Issue #9310: test inputs shoul… (compare)

  • Feb 20 07:41

    pbludov on master

    doc: fix checkstyle jar version… Issue #9297: solve spotbugs vio… (compare)

  • Feb 19 16:00

    pbludov on issue-9297-spotbugs-11

    (compare)

  • Feb 18 08:23

    pbludov on issue-9146-java11

    Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… Issue #9146: switch to jdk 11 i… and 1 more (compare)

  • Feb 18 07:29

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… (compare)

  • Feb 18 07:20

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… (compare)

Sarthak Handa
@sarthakhanda
I see that but i followed the exact pattern for the commit message
rnveach
@rnveach
@sarthakhanda you didn't as error message shows the commit message that is failing the rules
Rituparno Biswas
@roopbiswas
Hi everyone, I'm Rituparno! I really wish to start contributing to checkstyle. I've gone through the issues and found #8269 and #7562 quite intriguing. Please let me know if I can work on any of them.
Roman Ivanov
@romani
you just got a reply
just make a comment "I am no it" in issues, and you are welcome with PR
Rituparno Biswas
@roopbiswas
Cool! Thanks!
Roman Ivanov
@romani
@developerhb , please do not forget to claim bounty
developerhb
@developerhb
@romani can you please guide how can I claim bounty? What procedure should I follow?
developerhb
@developerhb
@romani I have submitted a bounty claim for issue #4944.
Roman Ivanov
@romani
accepted. Please do more fixes.
developerhb
@developerhb
Sure @romani I will do more fixes. Would you suggest me any issues to work on?
Roman Ivanov
@romani
@developerhb , please try checkstyle/checkstyle#6658
developerhb
@developerhb
okay @romani I will look into this issue.
Abhishek Kumar
@Abhishek-kumar09
please also review: checkstyle/checkstyle#8719
Shashwat Jaiswal
@shashwatj07
Hey everyone! How is it going?
@romani I was really busy since the past few days. Now I want to restart contributing. Can you suggest some issues?
developerhb
@developerhb
@romani I have questions in comments section of issue checkstyle/checkstyle#6658 . Please have a look.
Andrei Paikin
@strkkk
@shashwatj07 I have merged PR for checkstyle/checkstyle#8122 but there are other items, I think you can continue to work on them
Shashwat Jaiswal
@shashwatj07
okay thanks
Abhishek Kumar
@Abhishek-kumar09
Shashwat Jaiswal
@shashwatj07
Abhishek Kumar
@Abhishek-kumar09
developerhb
@developerhb
@romani need help with issue checkstyle/checkstyle#6658 . I have some questions there.
Roman Ivanov
@romani
@Abhishek-kumar09 , please send PR to add this tool to https://checkstyle.org/#Related_Tools
Abhishek Kumar
@Abhishek-kumar09

please send PR to add this tool to https://checkstyle.org/#Related_Tools

Sorry, which tool. Sorry I didn't get it.

Abhishek Kumar
@Abhishek-kumar09
Need a small help!
According to new rules, in input files we have to write a //ok or //violation at the end of every file. I just want to know what it (ok or violation) depicts? <br>
Sorry I could not found the pull request regarding this change to learn more about it.
Roman Ivanov
@romani
Sorry I didn't get it.
Strange .. I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Sorry I could not found the pull request regarding this change to learn more about it.

checkstyle/checkstyle#8825 I do pre-step to ease update for you

Abhishek Kumar
@Abhishek-kumar09

I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Oh! that one... Ok..., I will send a PR regarding it. :)
Here is that comment https://github.com/checkstyle/checkstyle/pull/8719#issuecomment-691179809

Abhishek Kumar
@Abhishek-kumar09
@strkkk I have tried to take main checkstyle repo as a reference for creating diff report in github-actions. Please have a look on commit Abhishek-kumar09/checkstyle@a990e21
Andrei Paikin
@strkkk
@Abhishek-kumar09 I responded. We had missed this item when we were implementing this feature this summer. Testing changes for this pipeline is a bit complicated
Abhishek Kumar
@Abhishek-kumar09

Strange .. I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Here is that repo... https://github.com/nikitasavinov/checkstyle-action
I will make PR regarding adding it to related tools

anhminhtran235
@anhminhtran235

Hi guys, I'm trying to set up development environment in Eclipse using this guide: https://checkstyle.org/eclipse.html.

I have forked checkstyle, opened eclipse and Select File > Import > Maven > Existing Maven Projects > myForkedFolder.

It said 'importing' for a while, then finished but give me the below errors:

img.PNG

I'm using Windows. When I import, the "Setup maven plugin connectors" window didn't appear.

I tried "Suppress Eclipse Warnings", the errors are still there.

Could somebody help me?

Thank you.

developerhb
@developerhb
@romani travis and cricle ci are failing in PR #8829. Please help.
Roman Ivanov
@romani
@anhminhtran235 , try to reimport project again, and try to build it in terminal first mvn install before importing.
anhminhtran235
@anhminhtran235
@romani I just did. The problem persists
image.png
Here's the screenshot of the error in pom.xml
Do people usually have problems importing when they use Windows?
Roman Ivanov
@romani
usually not, you have some problem with cache file creation from maven ant plugin. Please find in log of your Eclipse workspace full exception stacktrace and share it, we need to see cause exception.
@rnveach , have you ever experience such problem in windows+eclipse ?
Abhishek Kumar
@Abhishek-kumar09
https://github.com/Abhishek-kumar09/checkstyle/pull/16/files
I experienced some unusual behaviour could you help.
Andrei Paikin
@strkkk
@Abhishek-kumar09 I responded
anhminhtran235
@anhminhtran235
@romani Here's the errors
img.PNG
rnveach
@rnveach
@romani @anhminhtran235 Sometimes I get the ant build exception or an error in the pom, but I don't believe the one listed is the same. The main error looks to be eclipse can't modify C:\Windows\system32\target and I have no idea why it would be trying to write to the windows directory.
To me it saying the Windows directory is really wrong and needs to be identified. That may be the heart of the issues.