Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 18 20:16

    pbludov on issue-4219-shadowed-imports

    (compare)

  • Jan 07 11:07

    pbludov on issue-9149-stack-overflow2

    Issue #9149: removed input caus… (compare)

  • Jan 07 10:57

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Jan 07 07:33

    pbludov on issue-9149-stack-overflow2

    (compare)

  • Jan 06 17:28

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:35

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:06

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Dec 27 2020 14:23

    pbludov on master

    Issue #5951: Incorrect warning … minor: update wercker.sh to use… dependency: bump org.eclipse.jg… and 18 more (compare)

  • Dec 27 2020 12:12

    pbludov on issue-8864-cmd-set

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    Issue #9021: fix josm validation (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-8951-remove-buddy

    (compare)

  • Dec 27 2020 12:10

    pbludov on issue-6722-missing-asterisk

    (compare)

  • Dec 27 2020 12:08

    pbludov on issue-9124-stack-overflow-parenpad

    (compare)

  • Dec 27 2020 11:23

    pbludov on issue-8018-operator-wrap

    (compare)

  • Dec 27 2020 09:47

    pbludov on issue-9101-fix-stack-overflow

    (compare)

  • Dec 27 2020 09:43

    pbludov on issue-4219-shadowed-imports

    Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:59

    github-actions[bot] on issue-4219-shadowed-imports

    Issue #8651: Checkstyle fails o… Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:34

    pbludov on issue-8018-operator-wrap

    Issue #8018: AST based operator… (compare)

Abhishek Kumar
@Abhishek-kumar09
please review checkstyle/checkstyle#8719
developerhb
@developerhb
@romani need help with issue checkstyle/checkstyle#6658 . I have some questions there.
Roman Ivanov
@romani
@Abhishek-kumar09 , please send PR to add this tool to https://checkstyle.org/#Related_Tools
Abhishek Kumar
@Abhishek-kumar09

please send PR to add this tool to https://checkstyle.org/#Related_Tools

Sorry, which tool. Sorry I didn't get it.

Abhishek Kumar
@Abhishek-kumar09
Need a small help!
According to new rules, in input files we have to write a //ok or //violation at the end of every file. I just want to know what it (ok or violation) depicts? <br>
Sorry I could not found the pull request regarding this change to learn more about it.
Roman Ivanov
@romani
Sorry I didn't get it.
Strange .. I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Sorry I could not found the pull request regarding this change to learn more about it.

checkstyle/checkstyle#8825 I do pre-step to ease update for you

Abhishek Kumar
@Abhishek-kumar09

I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Oh! that one... Ok..., I will send a PR regarding it. :)
Here is that comment https://github.com/checkstyle/checkstyle/pull/8719#issuecomment-691179809

Abhishek Kumar
@Abhishek-kumar09
@strkkk I have tried to take main checkstyle repo as a reference for creating diff report in github-actions. Please have a look on commit Abhishek-kumar09/checkstyle@a990e21
Andrei Paikin
@strkkk
@Abhishek-kumar09 I responded. We had missed this item when we were implementing this feature this summer. Testing changes for this pipeline is a bit complicated
Abhishek Kumar
@Abhishek-kumar09

Strange .. I remember I saw message from you about gihub action repo for checkstyle , but I do not see it now

Here is that repo... https://github.com/nikitasavinov/checkstyle-action
I will make PR regarding adding it to related tools

anhminhtran235
@anhminhtran235

Hi guys, I'm trying to set up development environment in Eclipse using this guide: https://checkstyle.org/eclipse.html.

I have forked checkstyle, opened eclipse and Select File > Import > Maven > Existing Maven Projects > myForkedFolder.

It said 'importing' for a while, then finished but give me the below errors:

img.PNG

I'm using Windows. When I import, the "Setup maven plugin connectors" window didn't appear.

I tried "Suppress Eclipse Warnings", the errors are still there.

Could somebody help me?

Thank you.

developerhb
@developerhb
@romani travis and cricle ci are failing in PR #8829. Please help.
Roman Ivanov
@romani
@anhminhtran235 , try to reimport project again, and try to build it in terminal first mvn install before importing.
anhminhtran235
@anhminhtran235
@romani I just did. The problem persists
image.png
Here's the screenshot of the error in pom.xml
Do people usually have problems importing when they use Windows?
Roman Ivanov
@romani
usually not, you have some problem with cache file creation from maven ant plugin. Please find in log of your Eclipse workspace full exception stacktrace and share it, we need to see cause exception.
@rnveach , have you ever experience such problem in windows+eclipse ?
Abhishek Kumar
@Abhishek-kumar09
https://github.com/Abhishek-kumar09/checkstyle/pull/16/files
I experienced some unusual behaviour could you help.
Andrei Paikin
@strkkk
@Abhishek-kumar09 I responded
anhminhtran235
@anhminhtran235
@romani Here's the errors
img.PNG
Error 1: https://pastebin.com/VBCZdQuV
Error 2: https://pastebin.com/FX7B2H80
Error 3+4: https://pastebin.com/sD8VjAzg
rnveach
@rnveach
@romani @anhminhtran235 Sometimes I get the ant build exception or an error in the pom, but I don't believe the one listed is the same. The main error looks to be eclipse can't modify C:\Windows\system32\target and I have no idea why it would be trying to write to the windows directory.
To me it saying the Windows directory is really wrong and needs to be identified. That may be the heart of the issues.
The 2 package errors can be ignored.
Roman Ivanov
@romani
@anhminhtran235 , please try to reinstall Eclipse, or install it differently
anhminhtran235
@anhminhtran235
@romani I have reinstalled Eclipse. The problem still persists.
The first 2 exception only appears if I import the project after running mvn install
I'm using apache-maven-3.6.3, Java jdk 11.0.7
anhminhtran235
@anhminhtran235
I'm trying IntelliJ to see if it is an Eclipse problem
anhminhtran235
@anhminhtran235
image.png
@romani @rnveach I'm able to run the DescendantTokenCheckTest. I think it is working now?
anhminhtran235
@anhminhtran235
image.png
The pom.xml file still has lots of error
anhminhtran235
@anhminhtran235
The pom.xml file still has lots of error
Seems like this is a common problem in IntelliJ? https://youtrack.jetbrains.com/issue/IDEA-221441?_ga=2.243179202.1354574129.1600282369-1386209117.1600282369
Should I be concerned?
Weird. pom.xml is fine now. I think it's working :)
Roman Ivanov
@romani
@anhminhtran235 , please be welcome to do contributions
Abhishek Kumar
@Abhishek-kumar09
welcome to checkstyle @anhminhtran235, now you can hack on it:)
I have sent a PR to correct diff report's main page at checkstyle/contribution#506 Have tried to remove lot of confusions.
developerhb
@developerhb
@romani When I run Regression using GitHub Action I get some diffs but when I run it on local I don't get any diffs. I have explained it here https://github.com/checkstyle/checkstyle/pull/8829#issuecomment-694300363. Please help
anhminhtran235
@anhminhtran235
@romani Absolutely!

@Abhishek-kumar09

welcome to checkstyle @anhminhtran235, now you can hack on it:)

Thank you @Abhishek-kumar09

anhminhtran235
@anhminhtran235

Hi guys, I need help choosing my first issue. I'm new to the codebase, and to open source projects in general. I see some simple gsoc first issue and want to start with those, but most of them have people already on it.

Do you guys have any recommendations?

Andrei Paikin
@strkkk
@anhminhtran235 please ignore such comments on gsoc issues, most of this comments is outdated.