Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Apr 20 20:02

    pbludov on issue-9907-jdk16

    Issue #9907: set up Java16 build (compare)

  • Apr 20 19:35

    pbludov on issue-9907-jdk16

    Issue #8010: CommentsIndentatio… minor: fix formatting Issue #8989: Checkstyle parser … and 33 more (compare)

  • Mar 13 14:30

    pbludov on master

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 36 more (compare)

  • Feb 23 21:43

    pbludov on issue-9146-java11

    Issue #9146: specify java versi… (compare)

  • Feb 23 21:34

    pbludov on maven

    (compare)

  • Feb 23 21:31

    pbludov on issue-9146-java11

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 9 more (compare)

  • Feb 23 21:24

    pbludov on issue-9310-java11-inputs

    (compare)

  • Feb 23 08:28

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 07:03

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 23 06:52

    pbludov on issue-9310-java11-inputs

    Issue #9152: Record implementin… infra: add checkout_from suppor… dependency: bump archunit-junit… and 3 more (compare)

  • Feb 21 19:48

    pbludov on issue-9310-java11-inputs

    minor: cleanup whitelist words Issue #7877: Removed redundant … Issue #5711: JavadocTagContinua… and 1 more (compare)

  • Feb 21 19:40

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 15:01

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 14:47

    pbludov on issue-9310-java11-inputs

    Issue #9310: test inputs should… (compare)

  • Feb 20 09:54

    pbludov on issue-9310-java11-inputs

    #Issue #9310: test inputs shoul… (compare)

  • Feb 20 07:41

    pbludov on master

    doc: fix checkstyle jar version… Issue #9297: solve spotbugs vio… (compare)

  • Feb 19 16:00

    pbludov on issue-9297-spotbugs-11

    (compare)

  • Feb 18 08:23

    pbludov on issue-9146-java11

    Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… Issue #9146: switch to jdk 11 i… and 1 more (compare)

  • Feb 18 07:29

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… Issue #9146: update javassist t… Issue #9297: solve spotbugs vio… (compare)

  • Feb 18 07:20

    pbludov on issue-9146-java11

    Issue #9146: switch to jdk 11 i… (compare)

Roman Ivanov
@romani
@anhminhtran235 , please try to reinstall Eclipse, or install it differently
anhminhtran235
@anhminhtran235
@romani I have reinstalled Eclipse. The problem still persists.
The first 2 exception only appears if I import the project after running mvn install
I'm using apache-maven-3.6.3, Java jdk 11.0.7
anhminhtran235
@anhminhtran235
I'm trying IntelliJ to see if it is an Eclipse problem
anhminhtran235
@anhminhtran235
image.png
@romani @rnveach I'm able to run the DescendantTokenCheckTest. I think it is working now?
anhminhtran235
@anhminhtran235
image.png
The pom.xml file still has lots of error
anhminhtran235
@anhminhtran235
The pom.xml file still has lots of error
Seems like this is a common problem in IntelliJ? https://youtrack.jetbrains.com/issue/IDEA-221441?_ga=2.243179202.1354574129.1600282369-1386209117.1600282369
Should I be concerned?
Weird. pom.xml is fine now. I think it's working :)
Roman Ivanov
@romani
@anhminhtran235 , please be welcome to do contributions
Abhishek Kumar
@Abhishek-kumar09
welcome to checkstyle @anhminhtran235, now you can hack on it:)
I have sent a PR to correct diff report's main page at checkstyle/contribution#506 Have tried to remove lot of confusions.
developerhb
@developerhb
@romani When I run Regression using GitHub Action I get some diffs but when I run it on local I don't get any diffs. I have explained it here https://github.com/checkstyle/checkstyle/pull/8829#issuecomment-694300363. Please help
anhminhtran235
@anhminhtran235
@romani Absolutely!

@Abhishek-kumar09

welcome to checkstyle @anhminhtran235, now you can hack on it:)

Thank you @Abhishek-kumar09

anhminhtran235
@anhminhtran235

Hi guys, I need help choosing my first issue. I'm new to the codebase, and to open source projects in general. I see some simple gsoc first issue and want to start with those, but most of them have people already on it.

Do you guys have any recommendations?

Andrei Paikin
@strkkk
@anhminhtran235 please ignore such comments on gsoc issues, most of this comments is outdated.
I mean "I m on it" comments
anhminhtran235
@anhminhtran235
@strkkk I see. I'm gonna try some gsoc first issues
developerhb
@developerhb
@romani need help in checkstyle/checkstyle#6658
Roman Ivanov
@romani
replied
Abhishek Kumar
@Abhishek-kumar09
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.36.2 - thanks a lot to all participants
Abhishek Kumar
@Abhishek-kumar09
Roman Ivanov
@romani
@Abhishek-kumar09 , I am on it now ... thanks a lot for fix.
developerhb
@developerhb
@romani created PR checkstyle/checkstyle#8869
anhminhtran235
@anhminhtran235
@romani Please review checkstyle/checkstyle#8847
Abhishek Kumar
@Abhishek-kumar09
image.png
Hello, I am new to codecov and recently got issue in my PR checkstyle/checkstyle#8217
Although it has 100% line covergae it is showing codecov fault.
Andrei Paikin
@strkkk
@Abhishek-kumar09 it looks like some weird error in codecov itself, it shows 100% coverage on your changes but complains about some generated files
Abhishek Kumar
@Abhishek-kumar09
Yes, I think so. I will force push the changes so that it runs again.
Rudraksh Jhalani
@beingrudraksh
Hello everyone, I'm new to Checkstyle.org and I'm looking forward to contribute to the project as this would be my first time experience working on such type of a project. Really excited to start with!
Roman Ivanov
@romani
@beingrudraksh , please read https://checkstyle.org/beginning_development.html, as make your IDE be able to debug let us know we can find easy issues to make your introduction smooth
neeti
@neetisaharan
" Hi , I'm new and I would like to contribute, can someone get me started? "
Abhishek Kumar
@Abhishek-kumar09
@neetisaharan You have to first Setup your IDE before starting develpment, You could choose any, but personally I find IntelliJ much easy to get started. You can just clone your own fork of the repo, and intelliJ will do all the maven setup and imports for you. You could follow the step by step development guide for more insights.
please read https://checkstyle.org/beginning_development.html
Abhishek Kumar
@Abhishek-kumar09

Checkout some easy to get started with issues: https://github.com/checkstyle/checkstyle/issues?q=is%3Aissue+is%3Aopen+label%3Aapproved+label%3Aeasy

Documentation related issues to know better about the project in less time(Recommended): https://github.com/checkstyle/checkstyle/labels/gsoc%20first%20issue

Just tell everyone that you are on it, some issues have already those comments, please ignore those if they are posted 30+ days ago. They are open and you could chose it work.

Happy Hacking!

Abhishek Kumar
@Abhishek-kumar09
public class InputIndentationNew { //indent:0 exp:0
    void test() throws IOException  { //indent:4 exp:4
        BufferedReader bf =  //indent:8 exp:8
                new BufferedReader(  //indent:16 exp:16
                new InputStreamReader(System.in) {  //indent:16 <----- line 5
                    int a = 0; //indent:20
                }); //indent:16 exp:16
    } //indent:4 exp:4
}  //indent:0 exp:0
Is line 5 correctly indented or it should follow a basic offset or line wrapping indentation being on the next line.
Here, basicOffset: 4, LineWrapping: 8
Roman Ivanov
@romani
it is line wrap case, should be indented +8
Rudraksh Jhalani
@beingrudraksh
I'm facing a problem while setting up in Eclipse. No such window 'Maven Setup Plugin Connectors' appears after importing project and as a result, I'm not able to get the target/generated-sources/antlr folder.
Roman Ivanov
@romani
@rnveach , can you advice something on this Eclipse problem ? @beingrudraksh , please share version of Eclipse
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.37 , thanks a lot to all contributors
anhminhtran235
@anhminhtran235
@beingrudraksh I faced some problem with Eclipse too. Changing to IntelliJ works for me
Akash Mondal
@AkMo3
Hello everyone, I looking forward to contribute to this project. I am facing a bit trouble to understand how the entire codebase works. It would be extremely help if anyone could explain that.
Roman Ivanov
@romani
@AkMo3 , please read https://checkstyle.org/beginning_development.html , as you become able to debug, read https://checkstyle.org/writingchecks.html . All Checks are very independent and completely covered by Junit, so just put a break point and discover. Ask more specific question if still a problem.
Akash Mondal
@AkMo3
Thanks @romani , Would definitely ask if further questions.
Saksham Gupta
@saksham9656
hi @romani since you have gave me an issue but being a beginner i could not understand that issue would you please help me in it?
Roman Ivanov
@romani