Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Jan 18 20:16

    pbludov on issue-4219-shadowed-imports

    (compare)

  • Jan 07 11:07

    pbludov on issue-9149-stack-overflow2

    Issue #9149: removed input caus… (compare)

  • Jan 07 10:57

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Jan 07 07:33

    pbludov on issue-9149-stack-overflow2

    (compare)

  • Jan 06 17:28

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:35

    pbludov on issue-9149-stack-overflow2

    Issue #9149: workaround for sta… (compare)

  • Jan 06 16:06

    pbludov on issue-9149-stack-overflow2

    minor: fix sonar violation 'Ref… doc: releasenotes 8.39 [maven-release-plugin] prepare … and 4 more (compare)

  • Dec 27 2020 14:23

    pbludov on master

    Issue #5951: Incorrect warning … minor: update wercker.sh to use… dependency: bump org.eclipse.jg… and 18 more (compare)

  • Dec 27 2020 12:12

    pbludov on issue-8864-cmd-set

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    Issue #9021: fix josm validation (compare)

  • Dec 27 2020 12:11

    pbludov on issue-9021-fix-josm

    (compare)

  • Dec 27 2020 12:11

    pbludov on issue-8951-remove-buddy

    (compare)

  • Dec 27 2020 12:10

    pbludov on issue-6722-missing-asterisk

    (compare)

  • Dec 27 2020 12:08

    pbludov on issue-9124-stack-overflow-parenpad

    (compare)

  • Dec 27 2020 11:23

    pbludov on issue-8018-operator-wrap

    (compare)

  • Dec 27 2020 09:47

    pbludov on issue-9101-fix-stack-overflow

    (compare)

  • Dec 27 2020 09:43

    pbludov on issue-4219-shadowed-imports

    Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:59

    github-actions[bot] on issue-4219-shadowed-imports

    Issue #8651: Checkstyle fails o… Issue #4219: UnusedImports does… (compare)

  • Dec 27 2020 08:34

    pbludov on issue-8018-operator-wrap

    Issue #8018: AST based operator… (compare)

Aryan Bindal
@aryaniiit002
Merry Christmas to you too!
Roman Ivanov
@romani
Happy holidays !!!
Vyom-Yadav
@Vyom-Yadav
Merry Christmas.
Aryan Bindal
@aryaniiit002
Screenshot from 2020-12-26 17-55-45.png

Cannot resolve plugin edu.illinois:nondex-maven-plugin:1.1.1
what should i do?

@romani Please check this

Abhishek Kumar
@Abhishek-kumar09
try to reclone the project, and select jdk 11. Once everything is running properly, make your changes and create a PR
3 replies
Aryan Bindal
@aryaniiit002
Screenshot from 2020-12-27 07-45-58.png
@romani i rechecked development guide and everything is right
Abhishek Kumar
@Abhishek-kumar09
@aryaniiit002 what are your changes? seems like it is giving end of line error. and checkstyle is building and running properly that's why you are seeing checkstyle:ant-phase verify errors now.
7 replies
Have you made any PR, or any commit with these changes
Abhishek Kumar
@Abhishek-kumar09
don't do anything extra.
  1. Just clone the project
  2. right click on pom.xml and click maven and then select generate sources and update folders
  3. Wait for every running process on intelliJ to be completed/closed.
  4. Then start your development or do mvn clean verify, etc.
4 replies
Aryan Bindal
@aryaniiit002
Issue.png

[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.814 s <<< FAILURE! - in com.puppycrawl.tools.checkstyle.internal.XdocsJavaDocsTest
[ERROR] testAllCheckSectionJavaDocs Time elapsed: 3.813 s <<< ERROR!
java.lang.Error: Error was thrown while processing src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java
at com.puppycrawl.tools.checkstyle.internal.XdocsJavaDocsTest.examineCheckSection(XdocsJavaDocsTest.java:209)
at com.puppycrawl.tools.checkstyle.internal.XdocsJavaDocsTest.testAllCheckSectionJavaDocs(XdocsJavaDocsTest.java:182)
Caused by: org.opentest4j.AssertionFailedError:

any thoughts other than my xdoc and javadoc code changes are not alike? bcoz i have a way to solve it, if that's the ONLY issue here
And about the image- i tried to follow the instruction shown in terminal

Vyom-Yadav
@Vyom-Yadav
Yes that's the only probelm
1 reply
Roman Ivanov
@romani
https://checkstyle.org/releasenotes.html#Release_8.39 is released, thanks a lot to all contributors
and sorry that I did not have enough time this month to accept a lot of your PRs, I will try to catch up in january
happy new year !!!
Aryan Bindal
@aryaniiit002
Happy new year !! to you too
Aryan Bindal
@aryaniiit002
https://github.com/checkstyle/checkstyle/issues/8805#issuecomment-696892989
if may i, i wanted to know if any changes were made after that?
and what is "checkstyle.checkstyle" CI ?
Vyom-Yadav
@Vyom-Yadav
CI is continuous integration system, checkstyle uses Travis CI, it is used for building and testing. https://checkstyle.sourceforge.io/ci-management.html
Siddharth Singh
@stryder2000
I have worked out on the examples for some configurations for checkstyle/checkstyle#7695. Since i am new to open source, it would be great if someone can briefly guide me on how to proceed next?
Vyom-Yadav
@Vyom-Yadav
Update Xdoc and Javadoc file
Siddharth Singh
@stryder2000
@Vyom-Yadav in the Javadoc file, we have to update the class documentation only, Right?
Vyom-Yadav
@Vyom-Yadav
Changes in javadoc and xdoc should be similar and in javadoc change the mutiliine comment present at top, you can locate the module to be changed over there.
that comment shall be changed
Siddharth Singh
@stryder2000
Yes okay thanks!
Aryan Bindal
@aryaniiit002
i would like to know if @rnveach is active these days?
Aryan Bindal
@aryaniiit002
can i work on Pitest child issues?
Akash Mondal
@AkMo3
Hello everyone. I had a doubt regarding how to get javadoc tags. I wanted to get @summary tag . I had written the following code but it does not work. Can anyone help me out what is the error and how to correct it. I think my regex might be wrong due to which tagMatcher.find() doesn`t work. The code I had written is
/**
     * This regexp is used to extract the javadoc tags.
     */
    private static final Pattern JAVADOC_BLOCK_TAG_PATTERN = Pattern.compile("\\s@(\\w+)");

    private void containsSummaryTag(DetailNode ast) {
        final Matcher tagMatcher = JAVADOC_BLOCK_TAG_PATTERN.matcher(ast.getText());
        while (tagMatcher.find()) {
            final String tagName = tagMatcher.group(1);
            if (tagName.equals("summary")) {
                log(ast.getLineNumber(), "TAG NAME: ", tagName);
            }
        }
    }
3 replies
Devesh Tulshyan
@Devesh225
Hey, I'm a newbie to open source but I've a good understanding of Java, and I'm learning about new algorithms and data structures. How can I start contributing?
1 reply
AniketDGiri
@AniketDGiri
Dear Community Members,
I am Aniket Giri from India. Currently, I am pursuing Masters in Geoinformatics from CSRE, Indian Institute of Technology Bombay (IITB). I have my bachelor's in Computer Science.
I am fond of the open-source community as it provides me an opportunity to keep my skills updated, build connections, and improve communications skills. Thus, I would love to contribute. I would be very grateful to get any directions to pursue and participate.
1 reply
Ayushman Sachan
@bossever
Hi all, I had a doubt regarding the "update doc" issues on github. The checkstyle.org website already contains few examples showing what code is ok and what is not, do we need to copy the same ones to Javadoc? Or create new examples?
2 replies
Ayushman Sachan
@bossever

I'm getting this error while trying to run Checkstyle 8.40 jar using the java com.puppycrawl.tools.checkstyle.Main -c google_checks.xml MyClass.java command.

Error: Unable to initialize main class com.puppycrawl.tools.checkstyle.Main
Caused by: java.lang.NoClassDefFoundError: picocli/CommandLine$ParameterException

Should I be using 8.39 release instead?

6 replies
Aryan Bindal
@aryaniiit002
can somebody pls upload PIT Runner 'Run/Debug Configurations' screenshot with details filled for 'importOrder' tests?
4 replies
Ayushman Sachan
@bossever
Hey everyone,
should I create custom config.xml files to run a single check on a file?
2 replies
Siddharth Singh
@stryder2000
I am not able to remove trailing whitespaces from my commits, it just seems that my commits end with a '\n' by default and thus i am getting this error message: "Issue #7695 : Update doc for RegexpMultiline\n" is invalid. Can someone help me with that please?
3 replies
rnveach
@rnveach
@aryaniiit002 I am not as active as I use to be. You can always reach out to any other admin who is active.
1 reply
Abhishek Kumar
@Abhishek-kumar09
@stryder2000 do:
git commit --amend
You will have a textEditor sort of thing, just remove any extra whitespace or newline from that commit and save and exit
then push the changes to github
Siddharth Singh
@stryder2000
@Abhishek-kumar09 Already tried that.. have tried multiple things since morning.. including pre-commit but this is not resolving.. read an article that mentioned this problem of automatic addition of \n in commit message with vs code. not sure if i should switch to some other IDE
Abhishek Kumar
@Abhishek-kumar09
@stryder2000 If you are using vscode text-editor then there will be problems in the future development. Checkstyle needs an Java IDE for development. It will be way better if you would use IDE. IntelliJ Idea is my personal preference, you could use any.
1 reply
rnveach
@rnveach
@Abhishek-kumar09 @stryder2000 I haven't seen the PR, but are you sure it is the newline causing issues? Checkstyle should work with multiple new lines on the end of the commit message. https://github.com/checkstyle/checkstyle/blob/master/src/test/java/com/puppycrawl/tools/checkstyle/internal/CommitValidationTest.java#L128-L129
the only thing to avoid is any text appearing after the newline.
Siddharth Singh
@stryder2000
'\n' was the only thing that looked like a problem earlier bcz it this thing was mentioned in the rules. Later @Abhishek-kumar09 suggested the space between the issue number and colon might be causing problems, and after that didn't saw the commit message format error
Abhishek Kumar
@Abhishek-kumar09
@rnveach, Actually I didn't see any character after newline at-all, but yes there was multiple lines in the commit message, but every character itself was on the single line.
After that, he renamed his commit message and everything gone superbly well.
Akash Mondal
@AkMo3
Can anyone help me with checkstyle/checkstyle#9174 ? I am facing some coverage issues.
Aryan Bindal
@aryaniiit002
if i want to send 2nd PR should i make changes in another local branch then send PR?
and if i want to talk about some solution of an issue which i am not sure if its correct should i send PR with the solution or just comment in the issue like this?
checkstyle/checkstyle#7878
Abhishek Kumar
@Abhishek-kumar09

if you are willing to create a new PR, when the first PR is already open, then you have to do it on a new branch.

if i want to talk about some solution of an issue which i am not sure if its correct should i send PR

You can talk about the solution in the Issue itself, but if you have an idea of implementation, making a PR or draft is helpful for both the side to discuss the implementation of the code in a better way.

1 reply
Utkarsh Nagar
@Utkarshn10
Hi, I am new to the checkstyle community. I have just forked the repo and am running the mvn clean verify. Could anyone guide me how to proceed after this. Are there any beginner friendly issues or the issues from which I can start?
1 reply
SGanguly1999
@SGanguly1999

CODE(Hello.java):----

package com.company;
import java.io.File;
import com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck;
import com.puppycrawl.tools.checkstyle.checks.imports.ImportOrderCheck;
import java.util.; //#1
import java.util.List; //#2
import java.util.StringTokenizer; //#3
import java.util.concurrent.
; //#4
import java.util.concurrent.AbstractExecutorService; //#5
import java.util.concurrent.locks.LockSupport; //#6
import java.util.regex.Pattern; //#7
import java.util.regex.Matcher; //#8
public class Hello
{
public static void main(String args[])
{
Scanner sc=new Scanner(System.in);
System.out.println("Hi All my name is Soumyadeep Ganguly");
}
}

Configuration file---

<!DOCTYPE module PUBLIC
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">

<module name="CustomImportOrder">
<property name="customImportOrderRules" value="STATIC###STANDARD_JAVA_PACKAGE###SPECIAL_IMPORTS"/>
<property name="specialImportsRegExp" value="^org\."/>
<property name="sortImportsInGroupAlphabetically" value="true"/>
<property name="separateLineBetweenGroups" value="true"/>
</module>

Command line :-----

java -jar checkstyle-8.39-all.jar -c config.xml Hello.java

Exception in thread "main" java.lang.ClassCastException: class com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck cannot be cast to class com.puppycrawl.tools.checks
tyle.api.RootModule (com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck and com.puppycrawl.tools.checkstyle.api.RootModule are in unnamed module of loader 'app')
at com.puppycrawl.tools.checkstyle.Main.getRootModule(Main.java:458)
at com.puppycrawl.tools.checkstyle.Main.runCheckstyle(Main.java:380)
at com.puppycrawl.tools.checkstyle.Main.runCli(Main.java:331)
at com.puppycrawl.tools.checkstyle.Main.execute(Main.java:190)
at com.puppycrawl.tools.checkstyle.Main.main(Main.java:125)

All the files are in :--E:\New folder\Java Dev\src\com\company

Problem:---While executing it is generating a exception ....Can anyone help me with this?

2 replies