Hi. I just installed latest version of CherryPy on Windows 10 and run (as an example) built-in "hello world" tutorial. When I pressed Ctrl+C to shutdown an app (line 32), I got the following exception gist.
So a couple of things I notice. First, I notice that comments like this (https://github.com/cherrypy/cherrypy/pull/1564#discussion_r101898692) are asking for work outside the scope of the request… It’s not appropriate to ask new contributors to fix unrelated issues just because you noticed them. In fact, if the contributor had made these changes as part of the inital request, I would have asked them to be made separately or at least as separate commits to avoid conflating separate issues.
Second, I would have requested an update to the changelog. Without an update to the changelog, this change is incomplete. The entry in the changelog should reference the original issue that this PR fixes. The PR itself should also reference the original issue.
That way, it will be possible to trace the change to the release.