These are chat archives for cherrypy/cherrypy

29th
Aug 2018
Sviatoslav Sydorenko
@webknjaz
Aug 29 2018 21:45
@jaraco we need to heavily refactor cheroot.makefile, but it is sometimes used to encapsulate both writer and reader streams. My idea is to separate this into two classes, but it's being passed as a callable in cheroot.server back and forth, so it's not that easy.
Could you please take a look and tell me your opinion about the idea.
Jason R. Coombs
@jaraco
Aug 29 2018 21:54
@webknjaz I had the same instinct, but when I tried to refactor, I ran into problems. I agree it’s ugly and poorly defined, and at the time, I didn’t have any brilliant ideas. I might be able to revisit it again sometime, but I’m not sure when that’ll be.
Sviatoslav Sydorenko
@webknjaz
Aug 29 2018 21:54
i'm trying to do this now
Jason R. Coombs
@jaraco
Aug 29 2018 21:56
good luck!
Sviatoslav Sydorenko
@webknjaz
Aug 29 2018 23:22
cherrypy/cheroot@864ad1c @jaraco this commit should be safe to cherry-pick to master
it eliminates MakeFile almost everywhere