These are chat archives for cherrypy/cherrypy

30th
Aug 2018
Sviatoslav Sydorenko
@webknjaz
Aug 30 2018 12:06
@jaraco I think we can start from here: cherrypy/cheroot#109
Jeffrey R. Van Voorst
@jeffvanvoorst
Aug 30 2018 12:38
@webknjaz do you still need help refactoring or reviewing the change (refactor cheroot.makefile)? I may have time in the evenings (CDT). Is this the best place to discuss or is there a better option?
Sviatoslav Sydorenko
@webknjaz
Aug 30 2018 12:40
@jeffvanvoorst I'd love to get a review. Use gitter for live discussions, but PR for proper review attached to places in code/diff
and yes, if you have better idea on refactoring - I'd love to hear that too
I expect to merge the above PR "as is" and continue refactoring after that trying to keep patches small
Sviatoslav Sydorenko
@webknjaz
Aug 30 2018 20:00
@jaraco would you please take a look at cherrypy/cheroot#109 ?
Sviatoslav Sydorenko
@webknjaz
Aug 30 2018 22:29
@jaraco also what do you think about this change? cherrypy/cheroot#110