These are chat archives for cherrypy/cherrypy

19th
Sep 2018
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 10:54
:+1:
thanks for investing your time into this!
Ghost
@ghost~5ba232bed73408ce4fa8aa87
Sep 19 2018 11:30
Hi, Not sure if this is the correct place to ask. How is it possible to remove the Python2 black banner at the top of the cherrypy documentation?
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 11:31
@gditu_gitlab I'd like to avoid removal, but we can improve it. Suggestions? Problems?
I assume it's too large and maybe causes problems on mobile browsers, right?
Ghost
@ghost~5ba232bed73408ce4fa8aa87
Sep 19 2018 11:32
It is way too intrusive and it hides the headings on the pages. It does not seem to have a close button...
This is in a regular browser.
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 11:32
no, it doesn't have close
hm
oh, I see. it's reproducible with narrow window size only
use full screen as a workaround
Ghost
@ghost~5ba232bed73408ce4fa8aa87
Sep 19 2018 11:33
Why not show it and have a close button that will keep it closed for that browsing session? Once a person has read it it is sufficient, no?
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 11:34
it's on my list to improve this, but I don't know what I'll have time to work on it personally. you can send a PR if you're familiar with sphinx+alabaster
the only problem is to actually go and do this, I'm not opposed to this idea at all
Ghost
@ghost~5ba232bed73408ce4fa8aa87
Sep 19 2018 11:35
And as for narrow window, I have the window sized to fit the documentation :)
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 11:35
I see
add about 10-20% width and it'll be better
the problem occurs only when you size the window in a way that the text line in banner becomes two lines, effectively resizing the banner height
Ghost
@ghost~5ba232bed73408ce4fa8aa87
Sep 19 2018 11:38
Maybe a quick solution would be to display it at the top of every page, but then allow it to scroll out of view. That way it will be there on every page but won't interfere with the content.
Sviatoslav Sydorenko
@webknjaz
Sep 19 2018 11:39
You can make a PR