Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Sep 26 19:31
    PAk-CatchFire commented #213
  • Sep 20 04:05
    15999698503 opened #220
  • Sep 19 20:56

    chipmuenk on file_io

    add pyinstaller to dependencies… fix name of fixpoint module Sig… fix some spelling bugs Signed-o… and 47 more (compare)

  • Sep 19 20:31

    chipmuenk on v0.7.0a5

    (compare)

  • Sep 19 20:31

    chipmuenk on v0.7.0a6

    (compare)

  • Sep 19 20:31

    chipmuenk on v0.7.0a7

    (compare)

  • Sep 19 20:30

    chipmuenk on v0.7.0a8

    (compare)

  • Sep 19 20:30

    chipmuenk on v0.7.0a9

    (compare)

  • Sep 19 20:30

    chipmuenk on v0.7.0a10

    (compare)

  • Sep 19 20:30

    chipmuenk on v0.7.0a11

    (compare)

  • Sep 19 20:30

    chipmuenk on v0.7.0a12

    (compare)

  • Sep 19 20:29

    chipmuenk on v0.7.0a13

    (compare)

  • Sep 19 20:29

    chipmuenk on v0.7.0a14

    (compare)

  • Sep 19 20:29

    chipmuenk on v0.7.0a15

    (compare)

  • Sep 19 20:29

    chipmuenk on v0.7.0a16

    (compare)

  • Sep 19 18:36

    chipmuenk on v0.7.0a17

    (compare)

  • Sep 19 18:35

    chipmuenk on develop

    rename pyfdax_win.spec -> pyfda… clean up Signed-off-by: Christi… process number of samples Signe… (compare)

  • Sep 19 16:05

    chipmuenk on v0.7.0a16

    (compare)

  • Sep 19 16:05

    chipmuenk on develop

    some formatting Signed-off-by: … add a comment Signed-off-by: Ch… remove illegal command options … and 2 more (compare)

  • Sep 19 11:26

    chipmuenk on v0.7.0a15

    (compare)

Christopher Felton
@cfelton
hey Christian
suggestion for the list, sphinx based documentation and readthedocs integration
many (most) python projects use sphinx and readthedocs
Christian Münker
@chipmuenk
Documentation definitely should be far up on the list, both for developers and users. I have a rough idea about how sphinx works and I'll look up readthedocs - thanx for the suggestions! I'll upload my Latex / PDF-based documentation during the next two weeks (some documentation is better than none), but we should switch to a more collaboration-and automation-friendly system next.
Christopher Felton
@cfelton
@chipmuenk in commit 99fd4d, are you moving or removing?
Christian Münker
@chipmuenk
I've just made the first pre-release - Yay! Basic filter design and analysis is working except for some small issues. Please test - I've only run pyFDA under Windows7.
Christian Münker
@chipmuenk
Parallel to fixing the remaining issues of v0.1 I would like to start working on v0.2 with the focus on myhdl functionality. A colleague of mine with a strong background in fixpoint DSP and software architecture will support us till the end of the year; the myhdl topic should be perfect for him.
One thing that needs to be decided is how we are going to organize different filter topologies. Currently, only a demonstration how general IIR filters could be converted as type 1 and 2 direct form topologies is included in the pyFDA codebase. This file - filter_iir.py - is more or less a copy of @cfelton s example of a second order IIR filter.
Christopher Felton
@cfelton
@chipmuenk congrats on the first release
the "pre-release" I mean, will test on my systems, first chance I get
Christian Münker
@chipmuenk
Great - I'm curious ...
Christopher Felton
@cfelton
@chipmuenk ran basic operations on OSX/Linux
the same shutdown issue occurs on both
also on OSX the tabs act odd intermittently
when hovering over a tab other tabs are randomly selected kind of erratically
another odd thing, the first filter response displayed doesn't match the default settings
an IIR filter is displayed but the default is a lowpass FIR
a future item, might want to set specific pyfda color scheme in matplotlib (maybe? maybe not?)
on one of my systems I have a custom color scheme and pyfda uses that scheme
Christopher Felton
@cfelton
another thing to consider for future enhancements is have worker threads. The GUI can be slow to response when selecting and configuring the filter.
some of the text button on the b,a tab doesn't fit on the buttons
on OSX
the "set zero" button
same screenshot different link https://goo.gl/photos/ncyPcSGxgqaNvAo89
Christian Münker
@chipmuenk
Hovering over a tab: That's strange, I haven't implemented any mouse-over effects in the GUI
Default settings: You're right, I've been sloppy there - pyFDA just reads the default values for b,a from the filter dict and plots the reponses from that, independently of the GUI settings. Reading a default GUI setting, calculating the coefficients and responses from that would be possible, but makes assumptions about the installed filter design modules. Another option would be leaving plotting areas blank when no filter has been designed yet.
Color scheme: I don't quite understand - do you mean we should store and load user matplotlib rc settings like line width, color etc? I thought about that but postponed it
Christian Münker
@chipmuenk
Threads are important, myhdl also can take a while to simulate, blocking user interaction during that time. I would start with simple threading, i.e. one thread for the GUI and one for filter design / simulation. But I would like to understand the shutdown issue first, threads won't make shutting down easier. OTH, maybe the shutdown can be fixed with a proper threading approach. A student of mine has a similar (though better defined) problem in his GUI application with multithreading.
GUI look: The OSX is really different from the Windows look, perhaps it is necessary to define font sizes for tabs, labels, textboxes, plots ... This could / should be part of the user settings?
Christopher Felton
@cfelton
for now I would say keep it simple
not too many user configurable parameters (font, etc)
it is not a big deal thought I would let you know
one simple fix would be to make the button slightly bigger, then it might fit on all platforms
or set a font so it is consistent across platforms?
Threads yes, the HDL simulations will take some time
Christopher Felton
@cfelton
Color scheme: yes this would be an option for the future, if you want consistent look across systems the tool might want to set (explicitly) the color scheme (or maybe leave it as user set?)
Christian Münker
@chipmuenk
I created a new file for user settings, called user_settings.py, to control the look of the UI (font size, line widths etc.). The changes are in a new branch called "user_settings". This should also fix the hover effects you are seeing - my bad, there was a css hover definition which I played around with and forgot about as it had no effect on my system. The new approach should allow easier customization as it bundles all definitions in one place (not finished yet). I don't quite understand yet how Qt handles font size units - it seems only px works properly. Relative sizing would be better.
Christian Münker
@chipmuenk
I created PR #9 distinguishing static and dynamic global settings. I'm afraid the PR has become relatively large as I also fiddled with variable names and the structure of the global dictionaries. The two color schemes are just an intermediate step to achieve a more consistent look across OSs.
@cfelton: could you try whether you can merge the PR (just to check whether you've got the rights)?
Christopher Felton
@cfelton
@chipmuenk yes, I was able to merge the PR.
Christopher Felton
@cfelton
@chipmuenk here is a screenshot of the new color scheme on OSX https://goo.gl/photos/8B7MdZykShKU4ADC7
can't read the text on the yellow button
Christian Münker
@chipmuenk
Thanx - sometimes I still feel like a child marveling at the cogs of git in action ...
Now the layout looks quite similar to the windows version (including the yellow button and except for some elements not explicitly defined). I'll work on that inbetween.
Christopher Felton
@cfelton
@chipmuenk you are not alone, I know just the basics to get what I need done with git, always more to learn
Christopher Felton
@cfelton
@chipmuenk is there a qt (pyqt) version requirement?
Christopher Felton
@cfelton
@chipmuenk you should add the hacktoberfest category
Christian Münker
@chipmuenk
That's a great idea - I'll create two low hanging fruits for you right away
i.e. two myhdl related issues
Christian Münker
@chipmuenk
Pyqt5 works now except for a few rough edges that I'll fix with the next release tonight. I'll also create achanne
N
... bumpy ride on the train ... channel on anaconda for even easier installation. After upgrading one environment to pyqt5 my whole Anaconda installation stopped working, so now everything is PyQt5 on my laptop as well. Downgrading doesn't work.
Christian Münker
@chipmuenk
@cfelton : Issues #55 and #54 are right there waiting for you - the #hacktoberfest T-Shirt looks good :-)
BTW: What did you mean with "hacktoberfest" category? I've added labels with that name.
Christopher Felton
@cfelton
@chipmuenk I had similar issues trying to downgrade, getting the right pkgs can be challenging
Christian Münker
@chipmuenk
Uploaded v0.1rc3 to PyPI, Anaconda channel coming up when I'm less busy. I made my H-D