Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • Aug 03 15:08

    chipmuenk on file_io

    rename export_data -> export_cs… Add file type 'cmsis' Signed-of… add type hints Signed-off-by: C… and 4 more (compare)

  • Aug 03 09:21

    chipmuenk on file_io

    Change label alignment to right… (compare)

  • Aug 02 11:31

    chipmuenk on file_io

    Fine-tune widget margins Signed… emit a signal when quantization… (compare)

  • Aug 02 11:23

    chipmuenk on file_io

    remove logger message Signed-of… use qget_cmb_box instead of rea… improve tooltip Signed-off-by: … and 3 more (compare)

  • Jul 31 16:26

    chipmuenk on file_io

    replace 'ui_changed' -> 'ui_glo… rename 'ui_local' to 'ui_local_… (compare)

  • Jul 30 12:23

    chipmuenk on file_io

    make automatic accu the default… correct behaviour of automatic … update comments Signed-off-by: … and 1 more (compare)

  • Jul 30 11:20

    chipmuenk on file_io

    update formatting Signed-off-by… case "full" doesn't exist here … fix regression (unintended code… and 4 more (compare)

  • Jul 29 15:32

    chipmuenk on file_io

    update formatting Signed-off-by… simple renaming Signed-off-by: … Add combobox for automatic coef… and 4 more (compare)

  • Jul 28 19:41

    chipmuenk on file_io

    Update combo box labels and too… Modify combo box labels and too… update combobox labels and tool… and 1 more (compare)

  • Jul 28 04:31

    chipmuenk on file_io

    improve calculation of accu wid… (compare)

  • Jul 23 16:00

    chipmuenk on file_io

    clean up of obsolete code Signe… More reordering of widgets Sign… make accumulator combobox visib… (compare)

  • Jul 22 18:28

    chipmuenk on file_io

    remove logger message Signed-of… update comments Signed-off-by: … only emit a logger warning when… and 16 more (compare)

  • Jul 21 14:05

    chipmuenk on file_io

    update changelog Signed-off-by:… improve doctrings, change fkey … allow exporting coeffs in CMSIS… (compare)

  • Jul 19 15:16

    chipmuenk on file_io

    reduce logger noise Signed-off-… (compare)

  • Jul 19 12:43

    chipmuenk on file_io

    Fix formatting errors Signed-of… (compare)

  • Jul 19 12:10

    chipmuenk on file_io

    rename _copy_from/to_table to _… Merge branch 'file_io' of https… Rename key 'ui' to 'ui_local' a… and 2 more (compare)

  • Jul 19 08:59

    chipmuenk on file_io

    add cmsis export option Signed-… equalize lengths of xb_q and xa… remove obsolete if case Signed-… and 3 more (compare)

  • Jul 18 20:58

    chipmuenk on file_io

    restored transparency Signed-of… (compare)

  • Jul 18 11:16

    chipmuenk on file_io

    reduce logging noise, update co… Rename accumulator quant. dicti… show LSB value instead of MSB v… (compare)

  • Jul 16 07:29

    chipmuenk on file_io

    fix regression (forgotten updat… (compare)

Christopher Felton
@cfelton
another thing to consider for future enhancements is have worker threads. The GUI can be slow to response when selecting and configuring the filter.
some of the text button on the b,a tab doesn't fit on the buttons
on OSX
the "set zero" button
same screenshot different link https://goo.gl/photos/ncyPcSGxgqaNvAo89
Christian Münker
@chipmuenk
Hovering over a tab: That's strange, I haven't implemented any mouse-over effects in the GUI
Default settings: You're right, I've been sloppy there - pyFDA just reads the default values for b,a from the filter dict and plots the reponses from that, independently of the GUI settings. Reading a default GUI setting, calculating the coefficients and responses from that would be possible, but makes assumptions about the installed filter design modules. Another option would be leaving plotting areas blank when no filter has been designed yet.
Color scheme: I don't quite understand - do you mean we should store and load user matplotlib rc settings like line width, color etc? I thought about that but postponed it
Christian Münker
@chipmuenk
Threads are important, myhdl also can take a while to simulate, blocking user interaction during that time. I would start with simple threading, i.e. one thread for the GUI and one for filter design / simulation. But I would like to understand the shutdown issue first, threads won't make shutting down easier. OTH, maybe the shutdown can be fixed with a proper threading approach. A student of mine has a similar (though better defined) problem in his GUI application with multithreading.
GUI look: The OSX is really different from the Windows look, perhaps it is necessary to define font sizes for tabs, labels, textboxes, plots ... This could / should be part of the user settings?
Christopher Felton
@cfelton
for now I would say keep it simple
not too many user configurable parameters (font, etc)
it is not a big deal thought I would let you know
one simple fix would be to make the button slightly bigger, then it might fit on all platforms
or set a font so it is consistent across platforms?
Threads yes, the HDL simulations will take some time
Christopher Felton
@cfelton
Color scheme: yes this would be an option for the future, if you want consistent look across systems the tool might want to set (explicitly) the color scheme (or maybe leave it as user set?)
Christian Münker
@chipmuenk
I created a new file for user settings, called user_settings.py, to control the look of the UI (font size, line widths etc.). The changes are in a new branch called "user_settings". This should also fix the hover effects you are seeing - my bad, there was a css hover definition which I played around with and forgot about as it had no effect on my system. The new approach should allow easier customization as it bundles all definitions in one place (not finished yet). I don't quite understand yet how Qt handles font size units - it seems only px works properly. Relative sizing would be better.
Christian Münker
@chipmuenk
I created PR #9 distinguishing static and dynamic global settings. I'm afraid the PR has become relatively large as I also fiddled with variable names and the structure of the global dictionaries. The two color schemes are just an intermediate step to achieve a more consistent look across OSs.
@cfelton: could you try whether you can merge the PR (just to check whether you've got the rights)?
Christopher Felton
@cfelton
@chipmuenk yes, I was able to merge the PR.
Christopher Felton
@cfelton
@chipmuenk here is a screenshot of the new color scheme on OSX https://goo.gl/photos/8B7MdZykShKU4ADC7
can't read the text on the yellow button
Christian Münker
@chipmuenk
Thanx - sometimes I still feel like a child marveling at the cogs of git in action ...
Now the layout looks quite similar to the windows version (including the yellow button and except for some elements not explicitly defined). I'll work on that inbetween.
Christopher Felton
@cfelton
@chipmuenk you are not alone, I know just the basics to get what I need done with git, always more to learn
Christopher Felton
@cfelton
@chipmuenk is there a qt (pyqt) version requirement?
Christopher Felton
@cfelton
@chipmuenk you should add the hacktoberfest category
Christian Münker
@chipmuenk
That's a great idea - I'll create two low hanging fruits for you right away
i.e. two myhdl related issues
Christian Münker
@chipmuenk
Pyqt5 works now except for a few rough edges that I'll fix with the next release tonight. I'll also create achanne
N
... bumpy ride on the train ... channel on anaconda for even easier installation. After upgrading one environment to pyqt5 my whole Anaconda installation stopped working, so now everything is PyQt5 on my laptop as well. Downgrading doesn't work.
Christian Münker
@chipmuenk
@cfelton : Issues #55 and #54 are right there waiting for you - the #hacktoberfest T-Shirt looks good :-)
BTW: What did you mean with "hacktoberfest" category? I've added labels with that name.
Christopher Felton
@cfelton
@chipmuenk I had similar issues trying to downgrade, getting the right pkgs can be challenging
Christian Münker
@chipmuenk
Uploaded v0.1rc3 to PyPI, Anaconda channel coming up when I'm less busy. I made my H-D
(sorry) HDL widget pyQt5 compatible (at least I hope so, I can't test as I don't have myhdl installed in my current Anaconda installation).
Christian Münker
@chipmuenk
@cfelton : if you feel you would like to tackle one of the issues above, I can help you with integration into pyfda. For the time being, I would start with separate windows for simulation plots although I have some ideas for displaying myhdl simulation data in the pyfda plotting widgets.
Christopher Felton
@cfelton
@chipmuenk you can install myhdl with pip, pip install myhdl
I will test it out, in the next day or two
Christian Münker
@chipmuenk
Yeah, I know ... I had so much trouble with the permutations of py 2/3 and Qt 4/5 that I didn't want to add around with
This chat is really a pain on my cell phone :worried: / another variable.
Pyfda can also be installed via conda now, the channel is chipmuenk/pyfda
Christian Münker
@chipmuenk
Pyfda can also be installed via conda now, the channel is chipmuenk/pyfda
... still working on the details:, although it says "Linux" and "py3.5"
Christian Münker
@chipmuenk
It should run on any OS and py-Version. Thanx for looking into the myhdl integration -
I'd really like to tackle that for the next major release (@cfelton)
Andrew Tridgell
@tridge
hi All, trying pyFDA for first time. Any simple soln to: RuntimeError: the PyQt4.QtCore and PyQt5.QtCore modules both wrap the QObject class ?
Christian Münker
@chipmuenk
Sounds like a regression that was once fixed with PR #11 and that I reintroduced while adding pyQt5 compatibility. It occurs on systems that have both Qt4 and Qt5 installed, here, the matplotlib backend needs to be specified before it is imported for the first time.
Christian Münker
@chipmuenk
I've created issue #58 for this, let's continue the discussion over there.
Andrew Tridgell
@tridge
works nicely, thanks!
Christian Münker
@chipmuenk
Great & thanks for reporting the bug!
Andrew Tridgell
@tridge
no worries! looks like a great app
Christian Münker
@chipmuenk
Thanks! When I've finally fixed the bugs related to displaying filter parameters and released v0.1, I'd like to improve on the actual filter design routines and HDL export. So, now is a good time to write the wish list :-)