These are chat archives for chocolatey/ChocolateyGUI

23rd
Sep 2014
Gary Ewan Park
@gep13
Sep 23 2014 06:53
ok cool, let me know when you would like to have a chat
I think that it definitely helps in terms of showing that something is happening, as to whether it is required, that I don't know.
You could argue that it is too much information.
@RichiCoder1 would it make sense to have this as a setting that the user could activate if they wanted additional information?
that does lead to the question about what we show instead of this, because we would still want to show "something" to indicate that work was being done behind the scenes
Richard Simpson
@RichiCoder1
Sep 23 2014 18:39
We'd just revert to a "normal" text box instead of the one we have now
progress box*
Gary Ewan Park
@gep13
Sep 23 2014 19:04
sounds fine have me
just something to think about...
Richard Simpson
@RichiCoder1
Sep 23 2014 19:09
Hmm. I may have a nit to pick with the new style rules.
Gary Ewan Park
@gep13
Sep 23 2014 19:09
would it be possible for you to create a fork of ChocolateyGUI into your own GitHub account, and create branches from there? Rather than create branches directly in ChocolateyGUI? This will prevent AppVeyor from kicking off a build for every commit, until we merge directly into develop/master, or create Pull Requests for the work in progress
Richard Simpson
@RichiCoder1
Sep 23 2014 19:09
Oops, I thought I had. Apologies
Gary Ewan Park
@gep13
Sep 23 2014 19:10
coolio :-)
Richard Simpson
@RichiCoder1
Sep 23 2014 19:12
Any reason you went with explicit _this?
this*
Gary Ewan Park
@gep13
Sep 23 2014 19:13
It is one of the core StyleCop tenants. Means that when reading through code, you know exactly the scope of a variable, without relying on some form of variable notation.
Richard Simpson
@RichiCoder1
Sep 23 2014 19:15
Hmm. I'm not sure I'm for it. It adds noise to the code, especially when the "_variableName" notation already does say the same thing.
Of the many idle mistakes I've made, none ever would have been fixed adding "this" xD
Gary Ewan Park
@gep13
Sep 23 2014 19:17
well, that is something that I wanted to talk to you about :-) That is one of the other StyleCop rules that I turned off, as it was a rather large change to fix, was to not allow the _ notation for variables.
I am happy to discuss the merits of each StyleCop rule, and turn them on/off as required, and agreed within the team
Richard Simpson
@RichiCoder1
Sep 23 2014 19:18
Goodness gracious, that's a bizzare rule O.o
Gary Ewan Park
@gep13
Sep 23 2014 19:19
I am guessing you haven't played with StyleCop before, there are a few bizarre rules, or which appear bizarre, until you dig into them
it is really all about enforcing consistency across the code base
each rule can be turned on/off easily though
Richard Simpson
@RichiCoder1
Sep 23 2014 19:20
I admit, the most vigorous rules I've ever applied were resharper's
Gary Ewan Park
@gep13
Sep 23 2014 19:21
ReSharper and StyleCop work in parallel. ReSharper can apply refactoring for the StyleCop rules
Richard Simpson
@RichiCoder1
Sep 23 2014 19:22
Hmmm. I really want to chat about this now, but work calls >_<
Gary Ewan Park
@gep13
Sep 23 2014 19:22
no worries, will catch up soon about it
Richard Simpson
@RichiCoder1
Sep 23 2014 19:33
Pushed the .Net 4.5 changes to a PR for review and comments
Gary Ewan Park
@gep13
Sep 23 2014 19:34
coolio