These are chat archives for chocolatey/ChocolateyGUI

15th
Jan 2017
Manfred Wallner
@mwallner
Jan 15 2017 10:49
hey @RichiCoder1 @gep13 I'm going to do a PR today/tomorrow concerning resx-localization
'naming ok?'
blob
strings.resx in Properties/
blob
(usage like this)
Richard Simpson
@RichiCoder1
Jan 15 2017 11:07
Xml namespace looks fine, though personal preference would that resource string ids are conscise, notationless, and pascal cased.
Manfred Wallner
@mwallner
Jan 15 2017 11:07
please give an example
Richard Simpson
@RichiCoder1
Jan 15 2017 11:08
lang:Strings.SearchBoxLabel
Manfred Wallner
@mwallner
Jan 15 2017 11:09
ok, will do :-)
Richard Simpson
@RichiCoder1
Jan 15 2017 11:09
With underscores were you want to differentiate. Like lang:Strings.RemotesPage_AuthorsLabel
Manfred Wallner
@mwallner
Jan 15 2017 11:11
I'm going with lang:String.<xamlPage>_StringId
Richard Simpson
@RichiCoder1
Jan 15 2017 11:11
Works by me :). If it ends up being confusing later, we can refactor
Hmm, I should probably document that in contributing later.
Manfred Wallner
@mwallner
Jan 15 2017 14:11
hey @RichiCoder1 I'm not a fan of code in comments .. are you going to re-enable the flyouts in ShellView ? - I'd rather throw out the commented code completely ...
Richard Simpson
@RichiCoder1
Jan 15 2017 14:17
Yah, the plan is to simple remove all that once Settings & Company are done.
Manfred Wallner
@mwallner
Jan 15 2017 14:18
yay, so I'm not going to refactor language specific texts in the comments ^^
Richard Simpson
@RichiCoder1
Jan 15 2017 14:18
Yup. If it's commented out, just ignore it
Manfred Wallner
@mwallner
Jan 15 2017 14:40
hey @RichiCoder1 if you've got time - shortly check mwallner/ChocolateyGUI@e9a9ea2 if you find something blocking, otherwise I'll put in a PR tonight... :-)
Richard Simpson
@RichiCoder1
Jan 15 2017 15:13
I'd go ahead and sumbit the PR. Easier review and commenting.
Richard Simpson
@RichiCoder1
Jan 15 2017 15:19
Never be afraid to submit a work in progress PR :). They're designed for reviews and collaboration after all