These are chat archives for chocolatey/ChocolateyGUI

8th
Feb 2017
Richard Simpson
@RichiCoder1
Feb 08 2017 18:24
@gep13 Starter docs are looking good btw :)
Gary Ewan Park
@gep13
Feb 08 2017 19:01
@RichiCoder1 glad you like it! Obviously still needs work, but the framework is there, and it is part of the build now, so should always be up to date as we change things.
Manfred Wallner
@mwallner
Feb 08 2017 19:05
hey @gep13 @RichiCoder1 - working on chocolatey/ChocolateyGUI#397 - you'll see a PR tonight .. I've caught 'choco fever ' :D
Richard Simpson
@RichiCoder1
Feb 08 2017 19:05
Uh oh
Manfred Wallner
@mwallner
Feb 08 2017 19:33
hm .. why is the Issue 397 not referenced in the pr 398 ? I thought adding (GH-398) would be sufficient to link them ..
see chocolatey/ChocolateyGUI#398
Richard Simpson
@RichiCoder1
Feb 08 2017 19:34
I believe it only scans description text & commit messages. I could be wrong though. @gep13?
Speaking of commit messages, mind cleaning up those commit messages ;)?
Manfred Wallner
@mwallner
Feb 08 2017 19:35
nope, will do
@RichiCoder1 can this still be done after creating the PR - or do I have to delete, squash, commit and re-PR it?
Richard Simpson
@RichiCoder1
Feb 08 2017 19:36
If you do a rebase interactive, fixup the commits, and then force push, it'll show up in the PR.
Do that all the time meself.
Manfred Wallner
@mwallner
Feb 08 2017 19:42
I'm one with the force now :sparkles:
Richard Simpson
@RichiCoder1
Feb 08 2017 19:42
Just don't go too crazy. You can seriously mess stuff up if you using force push wrong ;)
dragon788
@dragon788
Feb 08 2017 19:49
I tend to keep a show everything WIP branch, and then make a new branch to rebase and squash down before sending pull requests, that way I can go back and fix my dumb typos
Manfred Wallner
@mwallner
Feb 08 2017 19:54
n1 @dragon788 - will try that from now on!
dragon788
@dragon788
Feb 08 2017 19:59
creating branches is cheap and easy, and deleting them once they are merged is also easy, there is actually a git command to find --merged branches that you can use to clean up local copies that aren't necessary anymore