These are chat archives for chocolatey/ChocolateyGUI

17th
Sep 2017
Richard Simpson
@RichiCoder1
Sep 17 2017 16:46
@ferventcoder what issues if any did you find with that PR? Gonna hope on it here in a little after I knock out some work stuff.
Rob Reynolds
@ferventcoder
Sep 17 2017 16:50
Logging, there was a xaml load issue for pkg view of some pks
Richard Simpson
@RichiCoder1
Sep 17 2017 16:51
Ahh, gotta love those xaml load errors. I really wish that Wpf got fully compiled Xaml like UWP and Xamarin
Rob Reynolds
@ferventcoder
Sep 17 2017 16:52
Still an issue with something in loading the license for non admins, but once logging is solid it should be easier to find
I think @gep13 is going to be looking in there as well.
Gary Ewan Park
@gep13
Sep 17 2017 17:41
I am sitting down to take the PR for a spin just now
will report any issues that I see here
@ferventcoder do you remember which packages that the XAML error was showing up for
Rob Reynolds
@ferventcoder
Sep 17 2017 17:46
Something about run32
I was trying to load 1password package built from package builder and pushed to a local chocolatey.server
Gary Ewan Park
@gep13
Sep 17 2017 17:56
I can reproduce the problem with viewing package details. Investigating now...
Gary Ewan Park
@gep13
Sep 17 2017 18:15
@ferventcoder just to confirm...
is this what you were seeing?
image.png
Richard Simpson
@RichiCoder1
Sep 17 2017 18:19
asdlkjadlkjdlkad
I've fixed that bug 5 times now.
Gary Ewan Park
@gep13
Sep 17 2017 18:20
IsHitTestVisible="false"?
Richard Simpson
@RichiCoder1
Sep 17 2017 18:21
That might work. The issue is the code I use to determine the appropriate bind context assumes everything you might click on is a Visual. I needs a check to determine if it's not, and then walk the tree up
Gary Ewan Park
@gep13
Sep 17 2017 18:21
Yip, adding that seems to have made it work :-D
yeah, that is what I was finding as well
The Run isn't a Visual element, therefore calling GetParent on it was throwing an exception
Richard Simpson
@RichiCoder1
Sep 17 2017 18:22
Merp
Gary Ewan Park
@gep13
Sep 17 2017 18:22
adding IsHitTestVisible="false" means that the Run isn't selected, and therefore the tree can be walked
Richard Simpson
@RichiCoder1
Sep 17 2017 18:22
I guess IsHitTestVisible is the better fi x then haha
Gary Ewan Park
@gep13
Sep 17 2017 18:22
cool
will add that in the places I can see it being a problem, and push a fix to the PR branch
Rob Reynolds
@ferventcoder
Sep 17 2017 18:37
That was the one!!
Gary Ewan Park
@gep13
Sep 17 2017 18:40
okay, i believe that this issue has been corrected :-D
I have pushed a commit onto your branch on your repo
@RichiCoder1 when do you get off work? i.e. when are you planning on taking another look at this PR?
Manfred Wallner
@mwallner
Sep 17 2017 18:46
just started testing, looks great guys!
Gary Ewan Park
@gep13
Sep 17 2017 18:49
@mwallner are you seeing anything getting entered into the Output Console when executing a command?
@ferventcoder are you seeing anything going into there? Or is that related to the logging issue that you mentioned?
Manfred Wallner
@mwallner
Sep 17 2017 18:50
will check right away
have you set the switch in settings though?
image.png
Gary Ewan Park
@gep13
Sep 17 2017 18:51
no, I have just been expanding it when it comes up, which normally showed the text
Manfred Wallner
@mwallner
Sep 17 2017 18:51
well, no - not seeing anything there
Gary Ewan Park
@gep13
Sep 17 2017 18:51
ok, so not just me :-D
Manfred Wallner
@mwallner
Sep 17 2017 18:52
yup, that seems to be currently broken (I'm on 1918eea)
Richard Simpson
@RichiCoder1
Sep 17 2017 18:53
@gep13 Probably here in an hour I'll be done
Just knocking out some work related tasks
Gary Ewan Park
@gep13
Sep 17 2017 18:53
@RichiCoder1 ok, perfect. Might need some help to get the final pieces of this together
Richard Simpson
@RichiCoder1
Sep 17 2017 18:54
If you're not seeing anything in Output Console, that might mean that the log interceptor isn't properly forwarding log messages from ChocolateyService to ProgressService (or, technically, IProgressService)
Gary Ewan Park
@gep13
Sep 17 2017 18:56
gotcha, ok, that gives me something to look at, thanks...
Gary Ewan Park
@gep13
Sep 17 2017 19:26
@RichiCoder1 I have added back in some of the missing interceptor code, so that now when there is an error, the calls to GrabErrors correctly returns a list of errors
however, I am no longer seeing a pop up when the failure occurs
Richard Simpson
@RichiCoder1
Sep 17 2017 19:35
Well
We're halfway there haha
Gary Ewan Park
@gep13
Sep 17 2017 19:35
ok, I think I see where that code has gone...
When we removed the RemotePackageService, it was handling the error response, and showing the dialog box when there was an issue
with that call, all we now have is this...
using (await StartProgressDialog(Resources.PackageViewModel_InstallingPackage, Resources.PackageViewModel_InstallingPackage, Id))
                {
                    await _chocolateyService.InstallPackage(Id, Version.ToString(), Source).ConfigureAwait(false);
                }
i.e. a call to InstallPackage, but the results are not being inspected and displayed
I will add that code back in just now
Richard Simpson
@RichiCoder1
Sep 17 2017 19:37
Yup! That will do it
Lord, there was a lot of layers on that cake.
Gary Ewan Park
@gep13
Sep 17 2017 19:38
ha ha, certainly was :-D
it has been trimmed down some what now though
Gary Ewan Park
@gep13
Sep 17 2017 19:44
2017-09-17_20-43-24.png
ok, that is better :-) Now we are at least seeing the error message that is coming back from the call to Chocolatey
I will go and add back in the handling onto to the other method calls now
still not seeing anything getting added to the console output though
Gary Ewan Park
@gep13
Sep 17 2017 20:06
ok, I have just pushed another commit into the PR branch
@mwallner if you are still around, could you take it for a spin please?
Gary Ewan Park
@gep13
Sep 17 2017 20:26
@RichiCoder1 where is the linking between the Output Console and the logging messages? I don't see how they are hooked up
oh, hold on, I think I found it...
OutputBufferCollection = _progressService.Output
so the question becomes, why is the progressService not updating
Manfred Wallner
@mwallner
Sep 17 2017 20:34
building right now
Richard Simpson
@RichiCoder1
Sep 17 2017 20:34
That whole output routine is a bit of a monster. One of this days I'm going to kill and replace it
Speaking off, should be freeing up my time shortly. Let me know where I should start sniffing first
Gary Ewan Park
@gep13
Sep 17 2017 20:36
so of the issue that I believe were outstanding, I have fixed...
  • issue with double clicking through to package details view
  • GrabErrors was returning an empty array all the time
The things that are remaining are...
  • Output console not being updated
Richard Simpson
@RichiCoder1
Sep 17 2017 20:37
:+1:
I'm pretty familiar with that, so I'll jump on that first
Gary Ewan Park
@gep13
Sep 17 2017 20:37
  • When running as non-admin user, with business edition, failures are still occurring, i.e. not using background service
if you could jump on the console output issue
I can look into the issue with the background service not working correctly
however, this might need input from @ferventcoder but not sure if he has connection just now
Richard Simpson
@RichiCoder1
Sep 17 2017 20:38
Did you figure out the logging issue he mentioned?
Gary Ewan Park
@gep13
Sep 17 2017 20:38
I think the logging issue was that the errors were not being returned to ChocoalteyGUI
which I have resolved
I "think"
unless it was another issue
Manfred Wallner
@mwallner
Sep 17 2017 20:39
I do not yet see any output in the terminal window
Richard Simpson
@RichiCoder1
Sep 17 2017 20:39
It sounded like the ChocolateyLogger also wasn't forwarding Choclatey's logs to Serilog (our logger) properly.
Manfred Wallner
@mwallner
Sep 17 2017 20:39
I'm on commit hash 1550321
Gary Ewan Park
@gep13
Sep 17 2017 20:40
@mwallner nope, that is still an issue. @RichiCoder1 is away to start looking at that one
@RichiCoder1 could be, I haven't/didn't check for that
Manfred Wallner
@mwallner
Sep 17 2017 20:40
right, sorry - tldr - I'm off for today, I'll check back tomorrow. cy in London ;-)
Richard Simpson
@RichiCoder1
Sep 17 2017 20:41
He mentioned he couldn't diagnose the background service issue becaue he couldn't see chocolatey's logs. I guess youll found out @gep13 haha
@mwallner Cya! Thanks for the help :D
Everybody's in London! Haha
Manfred Wallner
@mwallner
Sep 17 2017 20:41
@RichiCoder1 you to?
*too
Richard Simpson
@RichiCoder1
Sep 17 2017 20:41
Well, except me. I wish. Moved this weekend :P
Manfred Wallner
@mwallner
Sep 17 2017 20:42
:D - PM me - I'll get you a shirt :-p
~ cy
Gary Ewan Park
@gep13
Sep 17 2017 20:43
@mwallner see you soon, have a safe trip over
The chocolatiest bot this side of the Mississippi
@choco-bot
Sep 17 2017 20:43
Richard Simpson
@RichiCoder1
Sep 17 2017 20:55
Hmm
Log redirection appears to be working. I can see chocolatey's output in the debug console
Though there are some other weird issues I'm seeing
Gary Ewan Park
@gep13
Sep 17 2017 20:56
such as?
Richard Simpson
@RichiCoder1
Sep 17 2017 20:57
Well, output isn't showing as you found haha. But performing operations like update and pin aren't refreshing the package's state in the local list
I'll keep poking around and see if I can figure out why and find any other issues
Gary Ewan Park
@gep13
Sep 17 2017 20:57
oh, hadn't tested that part
good catch
@RichiCoder1 ok, I know why the UI updates aren't happening
_eventAggregator.BeginPublishOnUIThread(new PackageChangedMessage(id, PackageChangeType.Pinned, version));
Richard Simpson
@RichiCoder1
Sep 17 2017 21:02
You'll have to elaborate
Gary Ewan Park
@gep13
Sep 17 2017 21:02
calls to eventAggregator were also lost in the switch from RemoteService to ChocolateyService
Richard Simpson
@RichiCoder1
Sep 17 2017 21:02
Ahhhhh
Yup, that'd do it
I can add those back in just now
Richard Simpson
@RichiCoder1
Sep 17 2017 21:04
All that !result.Successful business needs to be there too
That's what pops up the error dialog
Gary Ewan Park
@gep13
Sep 17 2017 21:06
yup
those are akready added back in
have pushed commits into rob's branch
Richard Simpson
@RichiCoder1
Sep 17 2017 21:08
Cool :D
Gary Ewan Park
@gep13
Sep 17 2017 21:18
@RichiCoder1 I have just pushed some more changes to address the eventAggregator issues
Gary Ewan Park
@gep13
Sep 17 2017 21:41
@RichiCoder1 I have just added some additional commits, which I think will get the AppVeyor build back to green
going to be calling it a night soon, as I am getting quite tired, but I can pick this up again tomorrow morning
The chocolatiest bot this side of the Mississippi
@choco-bot
Sep 17 2017 21:41
Gary Ewan Park
@gep13
Sep 17 2017 21:41
can you let me know if you dig up anything with the Console Output, and if you find any other problems with the application?
/
Richard Simpson
@RichiCoder1
Sep 17 2017 21:42
:+1:
Gary Ewan Park
@gep13
Sep 17 2017 21:42
@ferventcoder if you have a chance to take a look at what there is now, that would be great. Thanks
Woot! Green build :-D
Rob Reynolds
@ferventcoder
Sep 17 2017 21:46
Just got to my terminal for the LHR leg
So I will be up in a little while
Gary Ewan Park
@gep13
Sep 17 2017 21:46
:+1:
Rob Reynolds
@ferventcoder
Sep 17 2017 21:47
You folks have been busy!
Gary Ewan Park
@gep13
Sep 17 2017 21:47
:-)
Richard Simpson
@RichiCoder1
Sep 17 2017 21:49
@gep13 nice!!!
Gary Ewan Park
@gep13
Sep 17 2017 21:51
@RichiCoder1 @ferventcoder okay, that is me going to call it a night, it has been a long day of travelling, etc. Will pick this up again tomorrow morning, just let me know what the outstanding issues are
@ferventcoder let me know when you get in. You want me to meet you at the underground station?
Rob Reynolds
@ferventcoder
Sep 17 2017 22:10
If you want - I will send you details