These are chat archives for chocolatey/ChocolateyGUI

12th
Oct 2017
Richard Simpson
@RichiCoder1
Oct 12 2017 14:28
My goal for today: evaluate everything marked bug or unmarked
In other news: past me really needs to better at telling future me when he's done something
Richard Simpson
@RichiCoder1
Oct 12 2017 15:41
I think I may have found a way to ditch our CefSharp dependency
Gary Ewan Park
@gep13
Oct 12 2017 16:45
@richicoder1 That would be good. That would allow us to take a dependency on a earlier .net framework, right?
Think we could leave that to the next release though, right?
Richard Simpson
@RichiCoder1
Oct 12 2017 16:47
In theory? Though I'm somewhat against dropping to a lower version
Gary Ewan Park
@gep13
Oct 12 2017 16:48
Just out of interest... Why?
Richard Simpson
@RichiCoder1
Oct 12 2017 16:49
The biggest reason is simply that every version prior to 4.5.2 is completely unsupported as far as I'm aware.
Rob Reynolds
@ferventcoder
Oct 12 2017 17:02
Lowest dependency
Minimum is what I'm thinking
Choco supports .NET 4.x+
Richard Simpson
@RichiCoder1
Oct 12 2017 17:03
I'm about 100% certain we can't drop below 4.5 in gui a big rewrite
Rob Reynolds
@ferventcoder
Oct 12 2017 17:04
And lights up a little with newer versions
Richard Simpson
@RichiCoder1
Oct 12 2017 17:04
A few of the packages we use and the way I use tasks require 4.5.x+
Rob Reynolds
@ferventcoder
Oct 12 2017 17:04
That's fair, but we can get back to 4.5+
Maybe
The idea is to be available in more places
Richard Simpson
@RichiCoder1
Oct 12 2017 17:05
I'm legimately curious what case you'd be using 4.5, and not be patched up to 4.5.2? That seems irresponsible
Rob Reynolds
@ferventcoder
Oct 12 2017 17:06
So first thing to install on a brand new system is what?
Chocolatey
Then you can manage up from there to newer things
But if choco has requirements at minimum higher than where you are, that's a tougher sell
Then let's talk about internal orgs
They are typically slower to move technologies forward or have a legit reason for not doing so
Those machines don't touch the internet typically
So yes, perfect world everyone can just install .NET 4.7 and move up
But we live in worlds with constraints, use cases, and things we are not aware of on the Chocolatey team. For choco we recommend you use newer versions of .NET, but at a minimum we allow it to work with a brand new box
Windows 7, Windows 2008 are still supported until 2020
Richard Simpson
@RichiCoder1
Oct 12 2017 17:12
Hmm. I guess I understand that logic. Though I'd argue that Gui is something you'd install after you've patched up
Rob Reynolds
@ferventcoder
Oct 12 2017 17:12
And it's definitely possible that is the case.
My question is if it is easy enough to support all the frameworks at 4.5+, why not add them to the config?
It's a diff of recommendation vs allowable behaviors
Gary Ewan Park
@gep13
Oct 12 2017 17:34
I step away for a few minutes to bath the girls and I come back to this :-)
Pretty much what I was going to say though :-)
Richard Simpson
@RichiCoder1
Oct 12 2017 18:03
Hmmm. My Markdown to Xaml looks like it's going well, but my test run at replacing Svg rendering w/ SkiaSharp looks like it's going to fall flat
Gary Ewan Park
@gep13
Oct 12 2017 18:34
How exactly are you replacing? By converting svg to something else?
Have you had a chance to look at last bug in 0.15.0 milestone?
Richard Simpson
@RichiCoder1
Oct 12 2017 19:41
@gep13 Yup. Currently we have an itty bitty browser in the background that navigates to a page with the SVG on it, takes a pictre, and then we render that. It's a really messy and frankly stupid solution and but nearly every other alternative has flaws or doesn't work
And yes I did. Couldn't reproduce, though I made some small tweaks to the update all logic while I was there.
Gary Ewan Park
@gep13
Oct 12 2017 19:43
@RichiCoder1 could we not download the svg, convert to something else, and then render that?
i.e. if icon is svg, find in local cache, and show that?
okay, cool, I will close that one out. Any objections to me starting the release process?
i.e. creating a branch and release notes, etc?
Richard Simpson
@RichiCoder1
Oct 12 2017 19:44
@gep13 It's the convert it to something else part that's the issue. WPF has no native support for SVG and nearly every C# library for converting to bitmap is flawed.
@gep13 I believe so. I think we're (finally) ready
Gary Ewan Park
@gep13
Oct 12 2017 19:45
choco install imagemagik.portable and shell out to that :-D
Richard Simpson
@RichiCoder1
Oct 12 2017 19:45
That's basically plan H at this point
Gary Ewan Park
@gep13
Oct 12 2017 19:45
ha ha :-P
Richard Simpson
@RichiCoder1
Oct 12 2017 19:46
The annoying this is that hack works, and it works fast and well. Hence why I haven't replaced it
I'm nervous about anything that involves shelling out as that has a tendency to be fragile
Gary Ewan Park
@gep13
Oct 12 2017 19:47
there is an argument that at some point, the Chocolatey Gallery should stop using SVG's, and perhaps have it return something else. The Visual Studio Gallery recently stopped allowing use of SVG's as icons
that would be a much longer term solution though
Richard Simpson
@RichiCoder1
Oct 12 2017 19:48
Bleh. That would be the sensible solution but I also <3 svgs. One of the very few good responsive formats. None of this make a logo in 27 different pngs business.
Gary Ewan Park
@gep13
Oct 12 2017 19:48
I don't disagree. They cited some security vulnerability for preventing the use of SVG's
Richard Simpson
@RichiCoder1
Oct 12 2017 19:50
I could see that. At least on the web side, there's no easy way (as I understand it), to for SVGs into render only and make them just images.
Gary Ewan Park
@gep13
Oct 12 2017 19:50
We are at the point of no return...
Richard Simpson
@RichiCoder1
Oct 12 2017 19:50
insert dramatic sound here
Gary Ewan Park
@gep13
Oct 12 2017 19:51
ok, first problem....
version number isn't calculating correctly
works locally, but not on AppVeyor
Richard Simpson
@RichiCoder1
Oct 12 2017 19:51
Hrm. That's important
Gary Ewan Park
@gep13
Oct 12 2017 19:51
must have an older version of GitVersion cached or something
let me investigate
Richard Simpson
@RichiCoder1
Oct 12 2017 19:52
This is our first official release in a year and half, so I expect some bumps haha
Gary Ewan Park
@gep13
Oct 12 2017 19:52
oh, and the build actuals fails:
looks like a new issue with the WiX project
Richard Simpson
@RichiCoder1
Oct 12 2017 19:54
Ahh
My fault, sort of. One sec
Gary Ewan Park
@gep13
Oct 12 2017 19:55
:-)
if you are making a change, can you make it on the release branch?
Richard Simpson
@RichiCoder1
Oct 12 2017 19:55
AppVeyor (including our pre versions) always builds in Releas, correct?
and sure thing
Gary Ewan Park
@gep13
Oct 12 2017 19:55
that is correct, yes
Richard Simpson
@RichiCoder1
Oct 12 2017 19:57
Hmm. Need to figure out a way to do Major.Minor.Build in our exe fileversion. That warning is coming from a fix for chocolatey/ChocolateyGUI#366
I'll just revert it for now.
Reverted and pushed.
/cc @gep13
Gary Ewan Park
@gep13
Oct 12 2017 19:59
Major.Minor.Build are asserted from GitVersion as part of the build, so we could create a common.wxi file with the version number in it, and replace as part of the build?
Richard Simpson
@RichiCoder1
Oct 12 2017 19:59
Currently we pull it off the Exe file version <?define Version=!(bind.fileVersion.$(var.MainExe))?> but we might be able to get around that.
GitVersion sets build level env vars right?
that will keep @mwallner very happy
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:00
Gary Ewan Park
@gep13
Oct 12 2017 20:00
@RichiCoder1 hmm, yes and no
Manfred Wallner
@mwallner
Oct 12 2017 20:01
yay! :-)
@gep13++
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:01
gep13 gained a level! (Karma: 37)
Gary Ewan Park
@gep13
Oct 12 2017 20:01
it does, but on AppVeyor they aren't able until starting another process, i.e. they are created but unavailable in the main build process
The GitVersion alias in Cake parses the output from the JSON response though, so we have access to them within the Cake script
@mwallner I am not ignoring your PR by the way...
Richard Simpson
@RichiCoder1
Oct 12 2017 20:03
We could set an env variable right before running the build, but I don't know how that works with our custom system.
Gary Ewan Park
@gep13
Oct 12 2017 20:03
we can pull that into a quick next release once we have all the translations in place
really want to just get this out the door :-D
Manfred Wallner
@mwallner
Oct 12 2017 20:04
nvm, thought you're busy otherwise ;-)
Richard Simpson
@RichiCoder1
Oct 12 2017 20:04
Then we could do <?define Version=$(env.BUILD_VERSION)?>
@mwallner Thanks for the quick turn around on that though :)
Manfred Wallner
@mwallner
Oct 12 2017 20:04
btw, we've been using the current prerelease at work for a couple of days now - all looks good
Gary Ewan Park
@gep13
Oct 12 2017 20:04
but we haven't got the value to put into the environment variable until we run the build though
chicken and the egg
Richard Simpson
@RichiCoder1
Oct 12 2017 20:06
How is ChocolateyGui's AssemblyFileVersion getting set currently?
Or what is it getting set too
Gary Ewan Park
@gep13
Oct 12 2017 20:07
That is happening here...
GitVersion is asserting the version number, and then updating the SolutionInfo.cs file
which then flows through into the generated exe
Richard Simpson
@RichiCoder1
Oct 12 2017 20:12
bleh. And git version isn't aware of AppVeyor build number. Ahh well. I keep thinking about a fix.
Gary Ewan Park
@gep13
Oct 12 2017 20:12
Why do we need the AppVeyor build number?
Richard Simpson
@RichiCoder1
Oct 12 2017 20:13
Basically so our released MSIs have an always incremented patch number, so that two alphas don't aciddentally get treated the same.
Gary Ewan Park
@gep13
Oct 12 2017 20:14
hmmm, not sure I like that...
Richard Simpson
@RichiCoder1
Oct 12 2017 20:14
Though honestly the best fix my be to unrevert that change and just silence the warning. It's a well meaning error, but I don't think it applies to our case.
Gary Ewan Park
@gep13
Oct 12 2017 20:14
from a Semantic Version point of view, teh Patch number should only bump for a bug fix
Richard Simpson
@RichiCoder1
Oct 12 2017 20:15
Yup yup. AllowSameVersionUpgrades="yes" basically says if it's the same Major.Minor.Patch, treat it the same and install over it like installing a new version rather than installing SxS
@gep13 Haha, fixing our issue labels?
Gary Ewan Park
@gep13
Oct 12 2017 20:16
ah, gotcha, in which case, I agree with you. Silence the error
@RichiCoder1 yip, away to generate the release notes
Richard Simpson
@RichiCoder1
Oct 12 2017 20:25
@gep13 Reverted
Build will be happy, I just accidentally only silenced the error on Debug at first.
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:26
Richard Simpson
@RichiCoder1
Oct 12 2017 20:27
I take it issue-labels-include is the labels should be using moving forward?
Gary Ewan Park
@gep13
Oct 12 2017 20:28
They are the ones that will be pulled into the release notes, we can change this however we want going forward.
I like the idea of the grouping that you were doing, but GitReleaseManager doesn't support that currently
Richard Simpson
@RichiCoder1
Oct 12 2017 20:28
Yup. I think I already filed an issue
Gary Ewan Park
@gep13
Oct 12 2017 20:28
there is an Open PR for it to start to support it, so going forward, I think we can switch to that
yes, yes you did :-D
for now, I am reverting to the basic single level grouping
Richard Simpson
@RichiCoder1
Oct 12 2017 20:29
:+1:
Gary Ewan Park
@gep13
Oct 12 2017 20:29
with the standard labels, and then we can rationalise from there
DAMN!
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:31
You have been fined one credit for a violation of the verbal morality statute.
the 2 commits part is wrong, but...
Richard Simpson
@RichiCoder1
Oct 12 2017 20:32
Whoop. It's almost smaller than I expected after all this time haha
Gary Ewan Park
@gep13
Oct 12 2017 20:32
since the tag for 0.15.0 isn't in place yet, teh commit count is wrong, but we can change that later
not all issues are pulled into the notes, i.e. Build and Internal Refactoring are not included
Richard Simpson
@RichiCoder1
Oct 12 2017 20:33
Yup. An there was a lot of that haha
Gary Ewan Park
@gep13
Oct 12 2017 20:33
indeed :-)
Richard Simpson
@RichiCoder1
Oct 12 2017 20:33
Very cool! What's next up?
Gary Ewan Park
@gep13
Oct 12 2017 20:34
if you are happy with the notes, we can merge the branch, that will create the final artifacts, which we can then hand over to @ferventcoder for signing and pushing
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:34
Gary Ewan Park
@gep13
Oct 12 2017 20:37
image.png
just verified that the exe is being stamped correctly with version number
Richard Simpson
@RichiCoder1
Oct 12 2017 20:37
I feel like #267 Intergrate with Chocolatey API should be prominent, but we're probably covering that in a blog post, right?
Excellent!
I can't think of anything else. I vote merge and let's get this signed and pushed
Gary Ewan Park
@gep13
Oct 12 2017 20:37
yes, I was planning on covering a lot of stuff, i.e. that, the new branding, etc, in a blog post
Richard Simpson
@RichiCoder1
Oct 12 2017 20:37
Sounds good!
Moving forward, we'll probably want a more automated signing processes. Don't want to it be too painful to make point and patch releases.
Gary Ewan Park
@gep13
Oct 12 2017 20:43
yes, we will need to work out that process
Gary Ewan Park
@gep13
Oct 12 2017 20:49
okay, moment of truth time...
tagged build is just away to kick off
Richard Simpson
@RichiCoder1
Oct 12 2017 20:49
:sparkles:
Gary Ewan Park
@gep13
Oct 12 2017 20:51
so it was 347 commits in the end
Richard Simpson
@RichiCoder1
Oct 12 2017 20:51
That sounds about right
Wyam is noisy
Gary Ewan Park
@gep13
Oct 12 2017 20:55
:-D
Richard Simpson
@RichiCoder1
Oct 12 2017 20:55
But we have green!
Gui 0.15 is officially unofficially released!
Gary Ewan Park
@gep13
Oct 12 2017 20:56
just verifying one last thing...
Richard Simpson
@RichiCoder1
Oct 12 2017 20:56
@choco-bot happy
Gary Ewan Park
@gep13
Oct 12 2017 20:56
then we can get it signed and pushed
Richard Simpson
@RichiCoder1
Oct 12 2017 20:56
:+1:
What's that?
Gary Ewan Park
@gep13
Oct 12 2017 20:56
That the release notes were correctly exported, and included in the about page of the application
Richard Simpson
@RichiCoder1
Oct 12 2017 20:57
Ah, I didn't even consider that
Gary Ewan Park
@gep13
Oct 12 2017 20:57
it "should" be done automagically...
arse!
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 20:58
You have been fined one credit for a violation of the verbal morality statute.
Gary Ewan Park
@gep13
Oct 12 2017 20:58
image.png
it must have pulled it "after" I changed it to 347
will know for next time
everything else worked though
Richard Simpson
@RichiCoder1
Oct 12 2017 20:59
Haha, indeed. I can live with that being off for now. At least it pulled the rest correctly
Gary Ewan Park
@gep13
Oct 12 2017 20:59
not sure I like the Title: Credits either
we can look to changing that as well though
Richard Simpson
@RichiCoder1
Oct 12 2017 21:00
Huh. That is def weird
Gary Ewan Park
@gep13
Oct 12 2017 21:00
I think that is a Wyam thing
will have to look at it
Richard Simpson
@RichiCoder1
Oct 12 2017 21:00
:+1:
Gary Ewan Park
@gep13
Oct 12 2017 21:00
all in all though, those are cosmetic
it build successfully
that is the main thing
great job everyone!
I need to step off now
but if @ferventcoder can get that pushed out, that would be great
Richard Simpson
@RichiCoder1
Oct 12 2017 21:01
Hehe, sounds good. @gep13 Thanks for the great work :)
Gary Ewan Park
@gep13
Oct 12 2017 21:01
you are very welcome, but you did most of the heavy lifting, so credit to you
@RichiCoder1++
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 21:01
richicoder1 gained a level! (Karma: 13)
Gary Ewan Park
@gep13
Oct 12 2017 21:01
and thanks to everyone else involved in this release
too many to mention here, but I will include everyone in the blog post
that will be tomorrow, or perhaps at the weekend, once the package is pushed to chocolatey.org
Richard Simpson
@RichiCoder1
Oct 12 2017 21:02
Sounds good :)
I'll wait until we have a post before I spam the announcement
Installed from the myget feed with no -pre without any issues. Working perfectly
:balloon: :star2:
Gary Ewan Park
@gep13
Oct 12 2017 21:04
SWEET!
The chocolatiest bot this side of the Mississippi
@choco-bot
Oct 12 2017 21:04
Dude!
Gary Ewan Park
@gep13
Oct 12 2017 21:04
right, need to go...
talk to you later
Richard Simpson
@RichiCoder1
Oct 12 2017 21:04
Sounds good! Have a good one :)
Chocolatey_Pord.PNG
@/all Coming soon to a Chocolatey near you!
Rob Reynolds
@ferventcoder
Oct 12 2017 21:34
@RichiCoder1 @gep13 awesome, blog post but also needs queued up for the release announcements list
If you want to write that Gary, we can get you queued up to send
Gary Ewan Park
@gep13
Oct 12 2017 21:35
yip, I will try to start that tomorrow, and get some input from both of you
will send a PR through to the website repository
Rob Reynolds
@ferventcoder
Oct 12 2017 21:47
Website, but also the release announcements - https://groups.google.com/group/chocolatey-announce